Re: [Open64-devel] code review for bug 716

2011-01-12 Thread Jian-Xin Lai
Hi Sun, The original code cuased a segmentation fault in ipa_link because the string passed in is readonly. I made another change to resolve this issue: Index: ipc_compile.cxx === --- ipc_compile.cxx (revision 3454) +++ ipc_compil

Re: [Open64-devel] code review for bug 716

2011-01-11 Thread Sun Chan
please go ahead (although I would have made "-" and "_" and #define in types.h or whichever host specific config file.) Sun On Tue, Jan 11, 2011 at 10:27 PM, Jian-Xin Lai wrote: > Hi, > > Can a gatekeeper review the patch to bug 716? Thank you very much. The bug > 716 is caused by the special cha

[Open64-devel] code review for bug 716

2011-01-11 Thread Jian-Xin Lai
Hi, Can a gatekeeper review the patch to bug 716? Thank you very much. The bug 716 is caused by the special character '+', which is legal in file names but illegal in identifiers. The original code only replaces the '-' by '_'. This patch will replace all these kind of characters. Index: common/i