Hi Yongchong,
After further review, I don't think that issue #2 is actually a
regression. Instead, I think it is a problem that has always been
there but was masked by the bug that you are fixing with the patch.
(There is some code merged from PathScale that looks related -- search
for -I in driv
Hi, David
Here is another patch, it will not add -default_options now. Instead,
it will give a warning, but not an error.
On Wed, Jan 5, 2011 at 5:49 AM, David Coakley wrote:
> Hi Yongchong,
>
> Sorry for the delay in the review and thanks for tracking down this
> bug. I still see a few minor
Hi Yongchong,
Sorry for the delay in the review and thanks for tracking down this
bug. I still see a few minor issues:
1) In the generated code, please follow the existing formatting
conventions: "char* path" should be "char *path" and "path=..." should
be "path = ..." (with spaces).
2) There
Here is another patch which do not use want_directory,
this patch will remove the dead codes in table.c, and just use
is_directory for generate a warning.
Index: osprey/driver/table.c
===
--- osprey/driver/table.c (revision 344
Yes, it's strange to have a boolean function that always return TRUE.
This want_directory function just want to do a check of the path, if
the path is not a directory, then it will print a warning. BTW, I
have a mistake in my patch, the condition in want_directory should be
if (!is_directory(path
pen64-devel
Subject: Re: [Open64-devel] patch for fixing bug introduce in revision 3437
I will not have a chance to look closely until next week, but I have a
few minor complaints... we can always address these later if the bug
is blocking progress.
The comment for want_directory() is exactly the sa
I will not have a chance to look closely until next week, but I have a
few minor complaints... we can always address these later if the bug
is blocking progress.
The comment for want_directory() is exactly the same as the comment
for is_directory(). This looks like an error.
Also, I think it is
go ahead.
Sun
On Tue, Dec 28, 2010 at 11:31 PM, Wu Yongchong wrote:
> Hi, David
>
> Could you please help review this patch
> See https://bugs.open64.net/show_bug.cgi?id=709
>
> In revision 3437 , the function want_directory has been remove
> considering it's a dead function, but it's not true. T
Hi, David
Could you please help review this patch
See https://bugs.open64.net/show_bug.cgi?id=709
In revision 3437 , the function want_directory has been remove
considering it's a dead function, but it's not true. This function
will always return TRUE no matter the path is a directory or not.
If
