Re: [Open64-devel] Code review for bug 746

2011-03-26 Thread Jian-Xin Lai
If the user doesn't initialize the field, its value should be 0 by default. In that case, it's safe to place the data into .bss section. 2011/3/26 Sun Chan > but you are bypassing the FLD > Sun > > On Sat, Mar 26, 2011 at 1:19 AM, Jian-Xin Lai wrote: > > Yes. The function Is_Aggregate_Init_Zero

Re: [Open64-devel] Code review for bug 746

2011-03-26 Thread Jian-Xin Lai
Hi, I updated the patch. In general, the GCC tree for struct initialization contains two chains. One is for field information (name, type, size, etc) and the other is for the initial value. For example: struct A { int f1; int f2; }; struct B { struct A f3; int f4; }; struct B b = {1, 2, 3}; The GC

Re: [Open64-devel] Code review for bug 746

2011-03-26 Thread Sun Chan
but you are bypassing the FLD Sun On Sat, Mar 26, 2011 at 1:19 AM, Jian-Xin Lai wrote: > Yes. The function Is_Aggregate_Init_Zero_Struct() will call > Is_Aggregate_Init_Zero() if meet a nested data structure (nested struct or > array). > > 2011/3/26 Sun Chan >> >> will your fix handle nested str

Re: [Open64-devel] Code review for bug 746

2011-03-26 Thread Jian-Xin Lai
Yes. The function Is_Aggregate_Init_Zero_Struct() will call Is_Aggregate_Init_Zero() if meet a nested data structure (nested struct or array). 2011/3/26 Sun Chan > will your fix handle nested structs correctly? > Sun > > On Fri, Mar 25, 2011 at 9:33 PM, Jian-Xin Lai wrote: > > Hi, > > > > Could

Re: [Open64-devel] Code review for bug 746

2011-03-25 Thread Sun Chan
will your fix handle nested structs correctly? Sun On Fri, Mar 25, 2011 at 9:33 PM, Jian-Xin Lai wrote: > Hi, > > Could a gate keeper review the patch for #746? > For the first case, the TY for c4 is: > [54]: c4    : (f: 0x1800 return_in_mem content_seen) size 4 M: > STRUCT >