Re: [Open64-devel] code review request bug fix 767

2011-05-10 Thread Jian-Xin Lai
This patch looks fine to me. 2011/5/6 Hui Shi > Hi Jianxin, > > Thanks for your review. > I did some complement for previous patch. > Also modify StInfo::applyModulus, avoid collpase parent into its kid cg > node. > > would you help review this? > > > On Fri, May 6, 2011 at 1:25 PM, Jian-Xin Lai

Re: [Open64-devel] code review request bug fix 767

2011-05-06 Thread Hui Shi
Hi Jianxin, Thanks for your review. I did some complement for previous patch. Also modify StInfo::applyModulus, avoid collpase parent into its kid cg node. would you help review this? On Fri, May 6, 2011 at 1:25 PM, Jian-Xin Lai wrote: > This patch looks fine to me. Please check it in. > > 201

Re: [Open64-devel] code review request bug fix 767

2011-05-05 Thread Jian-Xin Lai
This patch looks fine to me. Please check it in. 2011/4/29 Hui Shi > Would gatekeeper help review this patch? > > https://bugs.open64.net/show_bug.cgi?id=767 > Nystrom alias issue: 456.gobmk base output difference on train data > > The wrong alias is caused in > ConstraintGraphNode::collapseType