Re: [Open64-devel] request code review

2010-12-02 Thread Gautam Chakrabarti
Looks fine, go ahead check it in, and please add the bug# in your checkin message. Gautam From: shuxin yang To: Gautam Chakrabarti Cc: open64-devel@lists.sourceforge.net Sent: Thu, December 2, 2010 4:10:29 PM Subject: Re: [Open64-devel] request code review

Re: [Open64-devel] request code review

2010-12-02 Thread shuxin yang
You are right. How about this one? Thanks Shuxin Index: gcc/tree.c === --- gcc/tree.c (revision 3413) +++ gcc/tree.c (working copy) @@ -10522,6 +10522,23 @@ if (CPR()) { /* C++ */ switch (TREE_CODE(t)) {

Re: [Open64-devel] request code review

2010-12-02 Thread Gautam Chakrabarti
Hi, Could you use the conditional to guard code at a smaller granularity, i.e., maybe guard only the code under the FUNCTION_DECL case statement (ideally enclose the smallest chunk of code depending on this)? The reason is there is some other code under the CPR() conditional that needs DECL_LAN