Re: [Open64-devel] review request for a fix to bug649

2010-12-09 Thread Jian-Xin Lai
It looks fine to me. Please go ahead and commit it. Thank you very much. 2010/12/8 朱庆 > Hi all, > > Can gatekeeper help review this fix? > > Bug link: https://bugs.open64.net/show_bug.cgi?id=649 > > A small case: > > 1 namespace pcrecpp { > 2 class Arg { public: Arg(); Arg(void*); }; > 3 class R

Re: [Open64-devel] review request to a fix to bug 586

2010-12-09 Thread shuxin yang
Second call for code review. My boss asked me to check-in a fix to this blocker ASAP... Thanks Shuxin On Wed, Dec 8, 2010 at 10:48 AM, shuxin yang wrote: > Hi, there: > > Bug 586 is about back-end folding gcc extension __builtin_object_size() > into a compile time constant. > >If I under

Re: [Open64-devel] review request to a fix to bug 586

2010-12-09 Thread Jian-Xin Lai
Basically this patch looks fine to me. You can check it in at first then try to optimize it later. 2010/12/8 shuxin yang > This intrinsic is slightly different from others in that it needs some data > flow analysis to tell the constant it folded to. In the long run, I think > the BE try to fold

[Open64-devel] r3427 - in trunk/osprey: common/com wgen

2010-12-09 Thread svn
Author: syang Date: 2010-12-09 14:17:22 -0500 (Thu, 09 Dec 2010) New Revision: 3427 Modified: trunk/osprey/common/com/intrn_entry.def trunk/osprey/wgen/wgen_expr.cxx Log: Fix to bug #586 about "unresolved symbol of __builtin_object_size()". Approved by: Jianxin Modified: trunk/osprey/com

[Open64-devel] r3428 - in trunk/osprey: common/com wgen

2010-12-09 Thread svn
Author: syang Date: 2010-12-09 14:43:00 -0500 (Thu, 09 Dec 2010) New Revision: 3428 Modified: trunk/osprey/common/com/intrn_entry.def trunk/osprey/wgen/wgen_expr.cxx Log: Change intrinsic id from INTRN_OBJ_SZ to INTRN_OBJECT_SIZE in order to be congruent with a convesion which didn't know a

[Open64-devel] review request for IPA tracing fixes

2010-12-09 Thread Gilmore, Doug
Bob Scollard is in the process of fixing the IPA line/file numbering problem: https://bugs.open64.net/show_bug.cgi?id=675 and I noticed that I couldn't enable DevWarn messages, or enable the generating ID/address information in WHIRL trace output when the appropriate flags were passed to ipa_li

Re: [Open64-devel] review request for IPA tracing fixes

2010-12-09 Thread Sun Chan
the change is fine Sun On Fri, Dec 10, 2010 at 4:16 AM, Gilmore, Doug wrote: > Bob Scollard is in the process of fixing the IPA line/file numbering problem: > > https://bugs.open64.net/show_bug.cgi?id=675 > > and I noticed that I couldn't enable DevWarn messages, or enable the > generating ID/ad

[Open64-devel] r3430 - in trunk/osprey: common/com ipa/main/analyze

2010-12-09 Thread svn
Author: dgilmore Date: 2010-12-09 18:55:41 -0500 (Thu, 09 Dec 2010) New Revision: 3430 Modified: trunk/osprey/common/com/config.cxx trunk/osprey/common/com/config.h trunk/osprey/common/com/ir_reader.cxx trunk/osprey/ipa/main/analyze/ipa_option.cxx Log: Enable DevWarn messages, and enab