Re: [Open64-devel] Code Review request for fix bug953[CG]

2012-03-06 Thread Sun Chan
why don't you bite the bullet and figure out why you got that assertion. I used your same reasoning and conclude that you should always do -O0 and you have no answer. Sun On Mon, Mar 5, 2012 at 9:54 PM, Gang Yu wrote: > Some reasons to defend the fix suggestion: > > a.) it's a bug due to aggressi

Re: [Open64-devel] Code Review request for fix bug952[CG]

2012-03-06 Thread Jian-Xin Lai
Two comments: 1. This patch is not generic enough. If the type tenths is shor or other, it still fails. I think there are some other case (the parent is not STID) also causes the same problem. 2. The function prototype change can be applied to all architecture. 2012/2/24 Gang Yu : > Hi, > >   Coul

Re: [Open64-devel] cleanup patch to remove PROMPF code [LNO+]

2012-03-06 Thread David Coakley
Thanks, Sun. I tested extensively, including running SPEC CPU2006 with -apo and did not see any changes. I'll commit the change in a few days if there are no objections. 2012/3/5 Sun Chan : > I did not review the changes since it's all about removing code, which > is always a good thing. As long