The following commit has been merged in the master branch: commit b1eb6a7a3f80500f0187cc6a1dd2013e1a5e154a Author: Simon Wilkinson <s...@inf.ed.ac.uk> Date: Fri Jan 22 20:11:21 2010 +0000
Don't throw data away in afs_StoreMini afs_StoreMini had some interesting error handling. Instead of returning the error code from StoreData, it would return the error from EndCall, potentially masking the StoreData error. When it encountered an error it would discard all of the cached data. StoreMini's only caller is afs_StoreAllSegments. If StoreAllSegments is called from DoPartialWrite, then it squashes the error code. This combination could lead to the user's data being disposed of, without an error being reported. Fix all of this by not invalidating segments in StoreMini. Make StoreMini static to make it clear its only used by StoreAllSegments, and fix the error handling in StoreMini so that StoreData errors always take priority. Change-Id: I41f0c753655fac343485d2a473ad70b6ae96bb78 Reviewed-on: http://gerrit.openafs.org/1147 Reviewed-by: Derrick Brashear <sha...@dementia.org> Tested-by: Derrick Brashear <sha...@dementia.org> src/afs/afs_prototypes.h | 1 - src/afs/afs_segments.c | 16 +++++++--------- 2 files changed, 7 insertions(+), 10 deletions(-) -- OpenAFS Master Repository _______________________________________________ OpenAFS-cvs mailing list OpenAFS-cvs@openafs.org https://lists.openafs.org/mailman/listinfo/openafs-cvs