Re: [Openais] corosync crash and a hang

2008-11-04 Thread Christine Caulfield
Steven Dake wrote: Find attached a patch which fixes the segfault you are seeing with objctl. The issue was that strncpy was not null terminating a string if the src length and the copy length were the same (as per manpage). This resulted in negative length memcpy (which is actually a

Re: [Openais] [Cluster-devel] cluster/logging settings

2008-11-04 Thread David Teigland
On Thu, Oct 30, 2008 at 11:26:14PM -0700, Steven Dake wrote: There are two types of messages. Those intended for users/admins and those intended for developers. Both of these message types should always be recorded *somewhere*. The entire concept of LOG_LEVEL_DEBUG is dubious to me. If

Re: [Openais] [Cluster-devel] cluster/logging settings

2008-11-04 Thread David Teigland
On Tue, Nov 04, 2008 at 02:58:47PM -0600, David Teigland wrote: the cluster.conf logging/ section? My suggestion is: syslog_level=foo logfile_level=bar FWIW, I'm not set on this if someone has a better suggestion. I just want something unambiguous. debug=on has been shown to mean

Re: [Openais] [PATCH] cleanup the last of the SAF headers anf types

2008-11-04 Thread angus salkeld
P.S: the lint warnings have gone from 487 to 231 Now there are 114 warnings of the following: Return value (type corosync_error_t) ignored -Angus On Wed, 2008-11-05 at 14:22 +1300, angus salkeld wrote: Hi This was easy enough, lots of sed'ing :) note: -I have not changed the test c