Re: [Openais] [PATCHES][openais-whiteank][corosync-trunk]

2009-04-24 Thread Steven Dake
great work! please merge the corosync patch. I will take care of merging the openais compat patch. thanks! -steve On Fri, 2009-04-24 at 14:34 +0100, Chrissie Caulfield wrote: > The attached patches should fix all the things mentioned so far ... > > Chrissie > > Steven Dake wrote: > > really g

Re: [Openais] [PATCH]: openais/trunk: Add timeouts for pending saMsgMessageGet operations

2009-04-24 Thread Steven Dake
good for merge regards -steve On Fri, 2009-04-24 at 14:38 -0500, Ryan O'Hara wrote: > This patch implements timeout for saMsgMessageGet operations. > > A list of connections that have pending get operations for a given > queue is kept in that queue's data structure. If no message is > available,

[Openais] [PATCH]: openais/trunk: Add timeouts for pending saMsgMessageGet operations

2009-04-24 Thread Ryan O'Hara
This patch implements timeout for saMsgMessageGet operations. A list of connections that have pending get operations for a given queue is kept in that queue's data structure. If no message is available, saMsgMessageGet will block until either 1) a message arrives or 2) the timer expires. An SA_AI

Re: [Openais] [PATCH]: openais/trunk: Decrement queue_used when getting message from queue

2009-04-24 Thread Steven Dake
looks good for merge On Fri, 2009-04-24 at 12:59 -0500, Ryan O'Hara wrote: > Here is an obvious bug where queue_used is not being decremented when > we get a message from a queue/priorioty area. > > The queue_used variable tells us how many bytes in a priority area are > used. When we send a mess

[Openais] [PATCH]: openais/trunk: Decrement queue_used when getting message from queue

2009-04-24 Thread Ryan O'Hara
Here is an obvious bug where queue_used is not being decremented when we get a message from a queue/priorioty area. The queue_used variable tells us how many bytes in a priority area are used. When we send a message to the queue/priority area, which increment by the size of the message. When we r

Re: [Openais] [PATCHES][openais-whiteank][corosync-trunk]

2009-04-24 Thread Chrissie Caulfield
The attached patches should fix all the things mentioned so far ... Chrissie Steven Dake wrote: > really great work! can you address the following things? > > corosync nss patch: > > 1) please remove all capitalization except where required by nss. > Yikes. > > 2) totemnet_crypto_set should t

Re: [Openais] [PATCH] openais/trunk: fixed evt service

2009-04-24 Thread Steven Dake
nice work! I'm going to merge this since you likely wont be back in before 0.96 is cut. On Fri, 2009-04-24 at 13:12 +0200, Jan Friesse wrote: > Patch fixes evt service. Main problem is in hdb_handle_* functions, > which expect 64bits handle number, but request has 32bits. So using > hdb_nochec

Re: [Openais] [PATCH] openais/trunk: rename example configs

2009-04-24 Thread Steven Dake
looks good On Fri, 2009-04-24 at 12:52 +0200, Fabio M. Di Nitto wrote: > Similar to the patch that's in corosync, rename example configs > to .example. > > This avoids make install to overwrite custom running configs. > > Note that svn diff doesn't properly show renamed files. > > Fabio > __

[Openais] [PATCH] openais/trunk: fixed evt service

2009-04-24 Thread Jan Friesse
Patch fixes evt service. Main problem is in hdb_handle_* functions, which expect 64bits handle number, but request has 32bits. So using hdb_nocheck_convert in service/evt.c makes test/testevt works again. Regards, Honza Index: services/evt.c ==

[Openais] [PATCH] openais/trunk: rename example configs

2009-04-24 Thread Fabio M. Di Nitto
Similar to the patch that's in corosync, rename example configs to .example. This avoids make install to overwrite custom running configs. Note that svn diff doesn't properly show renamed files. Fabio Index: conf/openais.conf === --

[Openais] [PATCH] openais/trunk: link properly with -lpthread

2009-04-24 Thread Fabio M. Di Nitto
see $subject 000link.dpatch Description: application/shellscript ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

Re: [Openais] [PATCH] openais/trunk: revert incorrect use of pkgconfig

2009-04-24 Thread Steven Dake
looks good regards -steve On Fri, 2009-04-24 at 10:27 +0200, Fabio M. Di Nitto wrote: > This removes the automatic detection of lcrsodir from configure.ac. > > A better version will be done later on but for now this one simply > doesn't work as it should. > > Fabio > ___

[Openais] [PATCH] openais/trunk: revert incorrect use of pkgconfig

2009-04-24 Thread Fabio M. Di Nitto
This removes the automatic detection of lcrsodir from configure.ac. A better version will be done later on but for now this one simply doesn't work as it should. Fabio Index: configure.ac === --- configure.ac (revision 1855) +++ conf

Re: [Openais] make corosync and openais work together with arbitrary --prefix

2009-04-24 Thread Steven Dake
looks good Regards -steve On Fri, 2009-04-24 at 09:19 +0200, Jim Meyering wrote: > Steven Dake wrote: > > what is corosync_LIBS defined to? > > > > I only want libcoroipcc.so linked to files in the lib directory. > > corosync_LIBS was always empty. > I've adjusted the patch accordingly: > > Fro

Re: [Openais] make corosync and openais work together with arbitrary --prefix

2009-04-24 Thread Jim Meyering
Steven Dake wrote: > what is corosync_LIBS defined to? > > I only want libcoroipcc.so linked to files in the lib directory. corosync_LIBS was always empty. I've adjusted the patch accordingly: >From 4668b6361551d73799cc14a2db99fd4ae7076e4f Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 2