Re: [Openais] [PATCH]: openais/trunk: Remove unnecessary lock grant callback

2009-06-22 Thread Ryan O'Hara
On Sun, Jun 21, 2009 at 09:09:25PM -0700, Steven Dake wrote: If this doesn't introduce regressions why not remove the entire else statement? I just left it there as a reminder that I changed this detail of the code. I'm confident that this change is correct, but want to wait and see if we

Re: [Openais] [corosync trunk] add void * casts for iovecs

2009-06-22 Thread Wojtek Meler
Steven Dake pisze: Many iovecs are missing (const *) casts which results in lots of warnings on various compilers. This patch fixes that problem. Two more casts missing. Regards, Wojtek Index: exec/totempg.c === ---

Re: [Openais] [corosync trunk] add void * casts for iovecs

2009-06-22 Thread Wojtek Meler
Actually it was strange for me. Is corosync meant to work in heterogeneous environments ? I have both sparc and x86 systems in production and wonder if they will be able to talk each other. Regards, Wojtek Steven Dake pisze: Wojtek I didn't recast these because the code there is defective.

Re: [Openais] [corosync trunk] add void * casts for iovecs

2009-06-22 Thread Steven Dake
On Mon, 2009-06-22 at 16:26 +0200, Wojtek Meler wrote: Actually it was strange for me. Is corosync meant to work in heterogeneous environments ? I have both sparc and x86 systems in production and wonder if they will be able to talk each other. Yes. It is designed to support cross endian

Re: [Openais] [corosync trunk] add void * casts for iovecs

2009-06-22 Thread Fabio M. Di Nitto
On Mon, 2009-06-22 at 16:26 +0200, Wojtek Meler wrote: Actually it was strange for me. Is corosync meant to work in heterogeneous environments ? I have both sparc and x86 systems in production and wonder if they will be able to talk each other. I do test in heterogeneous environments from

Re: [Openais] call for roadmap features for future releases

2009-06-22 Thread David Teigland
On Mon, Jun 22, 2009 at 09:26:06AM -0700, Steven Dake wrote: On Mon, 2009-06-22 at 10:59 -0500, David Teigland wrote: On Sat, Jun 20, 2009 at 11:51:40AM -0700, Steven Dake wrote: I invite all of our contributors to help define the X.Y roadmap of both corosync and openais. Please submit

[Openais] [corosync trunk] remove totemnet compile warning by casting properly

2009-06-22 Thread Steven Dake
remove warning by casting properly in few places in totemnet Index: exec/totemnet.c === --- exec/totemnet.c (revision 2282) +++ exec/totemnet.c (working copy) @@ -585,7 +585,7 @@ unsigned char *data; unsigned char *inbuf; size_t

[Openais] openais trunk - use void * cast for lib ckpt iov_base

2009-06-22 Thread Steven Dake
Index: lib/ckpt.c === --- lib/ckpt.c (revision 1983) +++ lib/ckpt.c (working copy) @@ -564,7 +564,7 @@ } req_lib_ckpt_checkpointopen.checkpoint_open_flags = checkpointOpenFlags; - iov.iov_base = req_lib_ckpt_checkpointopen; +

[Openais] openais trunk - use void * cast for lib lck iov_base

2009-06-22 Thread Steven Dake
Index: lib/lck.c === --- lib/lck.c (revision 1983) +++ lib/lck.c (working copy) @@ -543,7 +543,7 @@ req_lib_lck_resourceopen.open_flags = resourceFlags; req_lib_lck_resourceopen.resource_handle = *lckResourceHandle; -

[Openais] openais trunk - use void * cast for lib evt iov_base

2009-06-22 Thread Steven Dake
Index: lib/evt.c === --- lib/evt.c (revision 1983) +++ lib/evt.c (working copy) @@ -281,7 +281,7 @@ req.evd_head.id = MESSAGE_REQ_EVT_EVENT_DATA; req.evd_head.size = sizeof(res); - iov.iov_base = req; + iov.iov_base = (void

[Openais] openais trunk - use void * cast for lib msg iov_base

2009-06-22 Thread Steven Dake
Index: lib/msg.c === --- lib/msg.c (revision 1983) +++ lib/msg.c (working copy) @@ -484,7 +484,7 @@ req_lib_msg_queueopen.create_attrs_flag = 0; } - iov.iov_base = req_lib_msg_queueopen; + iov.iov_base = (void

[Openais] openais trunk - use void * cast for lib tmr iov_base

2009-06-22 Thread Steven Dake
Index: lib/tmr.c === --- lib/tmr.c (revision 1983) +++ lib/tmr.c (working copy) @@ -358,7 +358,7 @@ req_lib_tmr_timerstart.timer_data = (void *)timerData; - iov.iov_base = req_lib_tmr_timerstart; + iov.iov_base = (void

[Openais] [openais trunk] remove shadow warning from testmsg

2009-06-22 Thread Steven Dake
Index: test/testmsg.c === --- test/testmsg.c (revision 1983) +++ test/testmsg.c (working copy) @@ -134,7 +134,7 @@ SaNameT async_name; SaNameT queue_name; SaNameT queue_group_name; - SaTimeT time; + SaTimeT msg_time;

[Openais] openais trunk - use void * cast for lib amf iov_base

2009-06-22 Thread Steven Dake
Index: lib/amf.c === --- lib/amf.c (revision 1983) +++ lib/amf.c (working copy) @@ -406,7 +406,7 @@ sizeof (SaNameT)); } - iov.iov_base = req_lib_amf_componentregister; + iov.iov_base = (void *)req_lib_amf_componentregister;

[Openais] openais trunk - use void * cast for service ckpt iov_base

2009-06-22 Thread Steven Dake
Index: services/ckpt.c === --- services/ckpt.c (revision 1983) +++ services/ckpt.c (working copy) @@ -1019,7 +1019,7 @@ memset (req_exec_ckpt_checkpointclose.source, 0, sizeof (mar_message_source_t)); - iovec.iov_base = (char

[Openais] openais trunk - use void * cast for service lck iov_base

2009-06-22 Thread Steven Dake
Index: services/lck.c === --- services/lck.c (revision 1983) +++ services/lck.c (working copy) @@ -1010,7 +1010,7 @@ req_exec_lck_resourceclose.resource_id = resource_id; req_exec_lck_resourceclose.exit_flag = 1; -

[Openais] openais trunk - use void * cast for service msg iov_base

2009-06-22 Thread Steven Dake
Index: services/msg.c === --- services/msg.c (revision 1983) +++ services/msg.c (working copy) @@ -1330,7 +1330,7 @@ res_lib_msg_messageget.send_time = 0; res_lib_msg_messageget.sender_id = 0; - iov.iov_base =

[Openais] openais trunk - use void * cast for service ckpt iov_base

2009-06-22 Thread Steven Dake
Index: services/evt.c === --- services/evt.c (revision 1983) +++ services/evt.c (working copy) @@ -1266,7 +1266,7 @@ cpkt.chc_op = EVT_OPEN_CHAN_OP; cpkt.u.chc_chan.ocr_name = *cn; cpkt.u.chc_chan.ocr_serial_no =

[Openais] openais trunk - evt service uses alloca - include alloca.h

2009-06-22 Thread Steven Dake
Index: evt.c === --- services/evt.c (revision 1996) +++ services/evt.c (working copy) @@ -43,6 +43,9 @@ #define REMOTE_OP_DEBUG LOGSYS_LEVEL_DEBUG #define RETENTION_TIME_DEBUG LOGSYS_LEVEL_DEBUG +#ifdef HAVE_ALLOCA_H +#include