Re: [Openais] logsys patch

2008-07-10 Thread Steven Dake
Dave, Looks good - applied Thanks again! -steve On Thu, 2008-07-10 at 15:16 -0500, David Teigland wrote: On Wed, Jul 02, 2008 at 09:32:45AM -0500, David Teigland wrote: It doesn't address the setting of logsys_subsys_id but defines it. I want to avoid the situation where

Re: [Openais] logsys patch

2008-07-02 Thread David Teigland
On Tue, Jul 01, 2008 at 03:11:26PM -0700, Steven Dake wrote: Dave, Your patch looks reasonable but has a few issues which need to be addressed. It doesn't address the setting of logsys_subsys_id but defines it. I want to avoid the situation where logsys_subsys_id is defined, but then not

Re: [Openais] logsys patch

2008-07-02 Thread Steven Dake
looks good committed thanks for the patch dave regards -steve On Wed, 2008-07-02 at 16:00 -0500, David Teigland wrote: Problem with assert.h in previous patch fixed here. ___ Openais mailing list Openais@lists.linux-foundation.org

Re: [Openais] logsys patch

2008-07-01 Thread Lon Hohberger
On Tue, 2008-07-01 at 14:32 -0500, David Teigland wrote: The attached patch adds a simple, function-based api to logsys, allowing simple programs to use it more cleanly (without macros). I'd like to see this included as well; single-subsystem utilities (such as fence agents) would certainly

Re: [Openais] logsys patch

2008-07-01 Thread Steven Dake
Dave, Your patch looks reasonable but has a few issues which need to be addressed. It doesn't address the setting of logsys_subsys_id but defines it. I want to avoid the situation where logsys_subsys_id is defined, but then not set. What I suggest here is to set logsys_subsys_id to some known