Re: [Openais] totemrrp.h, totemsrp.h, totemnet.h: const+size_t

2009-04-15 Thread Jim Meyering
Steven Dake wrote: > Try using this patch with your patchset. > > It makes a copy of the constant void *msg into a new merge_detect > struct. > > If it looks good go ahead and merge in with your changes on wednesday. That looks fine and confirms that msg should remain "const". I've just committed

Re: [Openais] totemrrp.h, totemsrp.h, totemnet.h: const+size_t

2009-04-13 Thread Steven Dake
Jim, Try using this patch with your patchset. It makes a copy of the constant void *msg into a new merge_detect struct. If it looks good go ahead and merge in with your changes on wednesday. Regards -steve On Mon, 2009-04-13 at 17:02 +0200, Jim Meyering wrote: > Steven Dake wrote: > > On Fri,

Re: [Openais] totemrrp.h, totemsrp.h, totemnet.h: const+size_t

2009-04-13 Thread Jim Meyering
Steven Dake wrote: > On Fri, 2009-04-10 at 18:57 +0200, Jim Meyering wrote: >> Here's a big const-adding change that doesn't touch APIs much. >> However, it's important for internal consistency. >> >> There is one snag, though, which means this patch isn't quite >> committable: >> >> The first clue

Re: [Openais] totemrrp.h, totemsrp.h, totemnet.h: const+size_t

2009-04-10 Thread Steven Dake
On Fri, 2009-04-10 at 18:57 +0200, Jim Meyering wrote: > Here's a big const-adding change that doesn't touch APIs much. > However, it's important for internal consistency. > > There is one snag, though, which means this patch isn't quite > committable: > > The first clue was a prototype mismatch

[Openais] totemrrp.h, totemsrp.h, totemnet.h: const+size_t

2009-04-10 Thread Jim Meyering
Here's a big const-adding change that doesn't touch APIs much. However, it's important for internal consistency. There is one snag, though, which means this patch isn't quite committable: The first clue was a prototype mismatch for message_handler_memb_merge_detect. It seemed like it should be l