[Openais] mcastport port not correctly handled

2008-09-23 Thread Mathieu Virbel
Hi In trunk branch, if you have mcastport:5405 in corosync.conf, the listen port are 7701 and 7445. We got 2 bugs in trunk-branch : A/ corosync is missing htons() when using mcastport. B/ ports are not contiguous. Whitetank-branch use htons() when configuration is read : the bug B are also

Re: [Openais] mcastport port not correctly handled

2008-09-23 Thread Steven Dake
Fabien, Please give me an hour to look at why/how this is different then whitetank. I'd like to maintain compatibility. Thanks -steve On Tue, 2008-09-23 at 18:24 +0200, Fabien Thomas wrote: Is there a problem to commit this fix in trunk ? Another bonus question is why the 2nd port is not

Re: [Openais] mcastport port not correctly handled

2008-09-23 Thread Steven Dake
Fabien, The root of the problem is two fold. First I ported all of the whitetank totem code to corosync minus the totemconfig code. The totemconfig code does the htons operation instead of it being done in lower level code as is done in the patch. I think the patch is the proper solution but