Re: [Open Babel] distgeom.cpp vs Eigen2

2012-08-11 Thread Noel O'Boyle
On 10 August 2012 17:41, Jeff Janes wrote: > On Wed, Aug 8, 2012 at 3:15 PM, Tim Vandermeersch > wrote: >> HI, >> >> On Thu, Aug 9, 2012 at 12:01 AM, Jeff Janes wrote: >>> On Wed, Aug 8, 2012 at 5:49 AM, Noel O'Boyle wrote: I fixed the Eigen2 problem with a cast. Hopefully it still works f

Re: [Open Babel] distgeom.cpp vs Eigen2

2012-08-10 Thread Jeff Janes
On Wed, Aug 8, 2012 at 3:15 PM, Tim Vandermeersch wrote: > HI, > > On Thu, Aug 9, 2012 at 12:01 AM, Jeff Janes wrote: >> On Wed, Aug 8, 2012 at 5:49 AM, Noel O'Boyle wrote: >>> I fixed the Eigen2 problem with a cast. Hopefully it still works for Eigen3. >> >> I've verified revision 4976 against

Re: [Open Babel] distgeom.cpp vs Eigen2

2012-08-08 Thread Tim Vandermeersch
HI, On Thu, Aug 9, 2012 at 12:01 AM, Jeff Janes wrote: > On Wed, Aug 8, 2012 at 5:49 AM, Noel O'Boyle wrote: >> I fixed the Eigen2 problem with a cast. Hopefully it still works for Eigen3. > > I've verified revision 4976 against Eigen2 > > but against Eigen 3 it now fails with: > > [ 82%] Buildi

Re: [Open Babel] distgeom.cpp vs Eigen2

2012-08-08 Thread Jeff Janes
On Wed, Aug 8, 2012 at 5:49 AM, Noel O'Boyle wrote: > I fixed the Eigen2 problem with a cast. Hopefully it still works for Eigen3. I've verified revision 4976 against Eigen2 but against Eigen 3 it now fails with: [ 82%] Building CXX object tools/CMakeFiles/obrms.dir/obrms.o /home/ec2-user/openb

Re: [Open Babel] distgeom.cpp vs Eigen2

2012-08-08 Thread Noel O'Boyle
I fixed the Eigen2 problem with a cast. Hopefully it still works for Eigen3. I'm getting quite a few trivial compile warnings though, Geoff, with MSVC - maybe you can look into these: 1>..\..\..\src\distgeom.cpp(126) : warning C4244: 'initializing' : conversion from 'double' to 'float', possible l

Re: [Open Babel] distgeom.cpp vs Eigen2

2012-07-26 Thread Jeff Janes
On Thu, Jul 26, 2012 at 10:35 AM, Geoff Hutchison wrote: >> When I build the most recent revision in SVN, 4965, with Eigen2 >> installed, it fails to compile due to an ambiguous overloaded call to >> Matrix. But with Eigen3 installed, it works. > > That's my mistake, since I only have Eigen3 ins

Re: [Open Babel] distgeom.cpp vs Eigen2

2012-07-26 Thread Geoff Hutchison
> When I build the most recent revision in SVN, 4965, with Eigen2 > installed, it fails to compile due to an ambiguous overloaded call to > Matrix. But with Eigen3 installed, it works. That's my mistake, since I only have Eigen3 installed on my machines. If you can give me the compile error, I

[Open Babel] distgeom.cpp vs Eigen2

2012-07-25 Thread Jeff Janes
When I build the most recent revision in SVN, 4965, with Eigen2 installed, it fails to compile due to an ambiguous overloaded call to Matrix. But with Eigen3 installed, it works. The below patch seems to fix by building distgeom.cpp when only Eigen3 specifically is present. I don't really under