Re: [OE-core] [PATCH v2] oeqa/selftest/devtool: add test for modifying recipes using go.bbclass

2024-05-17 Thread Ola x Nilsson
On Fri, May 17 2024, ol...@axis.com wrote: > From: Ola x Nilsson > > go.bbclass uses a special do_unpack function that causes the git root > to be different from S. Verify that it unpacks as expected. > > [ YOCTO #15483 ] > > Signed-off-by: Ola x Nilsson > --- > &

[OE-core] [PATCH v2] oeqa/selftest/devtool: add test for modifying recipes using go.bbclass

2024-05-17 Thread Ola x Nilsson
From: Ola x Nilsson go.bbclass uses a special do_unpack function that causes the git root to be different from S. Verify that it unpacks as expected. [ YOCTO #15483 ] Signed-off-by: Ola x Nilsson --- Changes since v1: Correct author meta/lib/oeqa/selftest/cases/devtool.py | 19

[OE-core] [PATCH] oeqa/selftest/devtool: add test for modifying recipes using go.bbclass

2024-05-17 Thread Ola x Nilsson
From: Julien Stephan go.bbclass uses a special do_unpack function that causes the git root to be different from S. Verify that it unpacks as expected. [ YOCTO #15483 ] Signed-off-by: Ola x Nilsson --- meta/lib/oeqa/selftest/cases/devtool.py | 19 +++ 1 file changed, 19

[OE-core] [PATCH] devtool: modify: Catch git submodule error for go code

2024-05-14 Thread Ola x Nilsson
the git submodule support. The extracted source will still have two .git folders, one in S created by devtool and one in the go path which will contain the tru git history. [ YOCTO #15483 ] Signed-off-by: Anton Almqvist Signed-off-by: Ola x Nilsson --- scripts/lib/devtool/standard.py | 5 - 1

[OE-core] [PATCH] binutils: Remove conflict markers from 0008-Use-libtool-2.4.patch

2024-04-24 Thread Ola x Nilsson
From: Ola x Nilsson The diff hunks were not doing anything important, just remove them. Signed-off-by: Ola x Nilsson --- .../binutils/0008-Use-libtool-2.4.patch | 24 --- 1 file changed, 24 deletions(-) diff --git a/meta/recipes-devtools/binutils/binutils/0008-Use

[OE-core] [PATCH v2] python3-numpy: Use Large File Support version of fallocate

2024-01-26 Thread Ola x Nilsson
This was supposed to always be the case from upstream but was exposed by the 64-bit-time QA checker when file function scanning was enabled. Signed-off-by: Ola x Nilsson --- ...le-fallocate-on-32-bit-linux-platfor.patch | 51 +++ .../python/python3-numpy_1.26.3.bb

[OE-core] [PATCH] python3-numpy: Use Large File Support version of fallocate

2024-01-25 Thread Ola x Nilsson
This was supposed to always be the case from upstream but was exposed by the 64-bit-time QA checker when file function scanning was enabled. Signed-off-by: Ola x Nilsson --- ...le-fallocate-on-32-bit-linux-platfor.patch | 49 +++ .../python/python3-numpy_1.26.2.bb

Re: [OE-core] [PATCH v2 2/3] insane.bbclass: Make check_32bit_symbols check for file functions too

2024-01-16 Thread Ola x Nilsson
yscan uses 32-bit api 'mkstemp' >> >> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/8436/steps/12/logs/warnings >> >> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: >> /usr/lib/openssh/ptest/regress/unittests/hostkeys/test_hostkeys use

Re: [OE-core] [PATCH 3/3] insane.bbclass: Python code cleanup in check_32bit_symbols

2024-01-12 Thread Ola x Nilsson
Forgot the signed-off footer, v2 sent /Ola On Fri, Jan 12 2024, Ola x Nilsson wrote: > --- > meta/classes-global/insane.bbclass | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/classes-global/insane.bbclass > b/meta/classes-global/insa

[OE-core] [PATCH v2 3/3] insane.bbclass: Python code cleanup in check_32bit_symbols

2024-01-12 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/classes-global/insane.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 1ff6a319c4..26457764ce 100644 --- a/meta/classes-global/insane.bbclass

[OE-core] [PATCH v2 1/3] insane.bbclass: Check for adjtime in check_32_bit_symbols

2024-01-12 Thread Ola x Nilsson
adjtime was overlooked in the original commit. Signed-off-by: Ola x Nilsson --- meta/classes-global/insane.bbclass | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 6f3cd3026d..69741a6a79 100644 --- a/meta/classes

[OE-core] [PATCH v2 2/3] insane.bbclass: Make check_32bit_symbols check for file functions too

2024-01-12 Thread Ola x Nilsson
Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64, also check for functions redirected only based on _FILE_OFFSET_BITS and __USE_FILE_OFFSET64. Signed-off-by: Ola x Nilsson --- meta/classes-global/insane.bbclass | 31 ++ 1 file changed, 31 insertions

[OE-core] [PATCH 3/3] insane.bbclass: Python code cleanup in check_32bit_symbols

2024-01-12 Thread Ola x Nilsson
--- meta/classes-global/insane.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 1ff6a319c4..26457764ce 100644 --- a/meta/classes-global/insane.bbclass +++

[OE-core] [PATCH 1/3] insane.bbclass: Check for adjtime in check_32_bit_symbols

2024-01-12 Thread Ola x Nilsson
adjtime was overlooked in the original commit. Signed-off-by: Ola x Nilsson --- meta/classes-global/insane.bbclass | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 6f3cd3026d..69741a6a79 100644 --- a/meta/classes

[OE-core] [PATCH 2/3] insane.bbclass: Make check_32bit_symbols check for file functions too

2024-01-12 Thread Ola x Nilsson
Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64, also check for functions redirected only based on _FILE_OFFSET_BITS and __USE_FILE_OFFSET64. Signed-off-by: Ola x Nilsson --- meta/classes-global/insane.bbclass | 31 ++ 1 file changed, 31 insertions

Re: [OE-core] [PATCH V2 1/2] kernel-module-split: make autoload and probeconf distribution specific

2023-06-20 Thread Ola x Nilsson
n files in /lib/modprobe.d > > [1] https://www.freedesktop.org/software/systemd/man/modules-load.d.html > [2] https://www.man7.org/linux/man-pages//man5/modprobe.d.5.html > > [YOCTO #12212] https://bugzilla.yoctoproject.org/show_bug.cgi?id=12212 > > CC: Ola x Nilsson > CC: Pe

Re: [OE-core] [PATCH V3] kbd: Add ptest support

2023-06-09 Thread Ola x Nilsson
Ola > >> -Original Message----- >> From: Ola x Nilsson >> Sent: Friday, June 9, 2023 3:59 PM >> To: alexandre.bell...@bootlin.com >> Cc: Qiu, Tingting/仇 婷婷 ; Alexandre Belloni via >> lists.openembedded.org >> ; >> openembedded-core@lists.openembedded.o

Re: [OE-core] [PATCH V3] kbd: Add ptest support

2023-06-09 Thread Ola x Nilsson
PATH}/tests/data/findfile/test_0/keymaps/ >> +install ${S}/tests/data/findfile/test_0/keymaps/include/* >> ${D}${PTEST_PATH}/tests/data/findfile/test_0/keymaps/include/ >> +install -d >> ${D}${PTEST_PATH}/tests/data/findfile/test_0/keymaps/i386/include/ >> +

[OE-core] time64.inc

2023-04-18 Thread Ola x Nilsson
that is https://github.com/rust-lang/libc/pull/3175 . Unfortunately I have not had any feedback so far. I have not even tried applying that change to the stdlib-rs recipe yet. I think there are 3 or 4 instances of the libc crate that have to be patched in the rustc release. -- Ola x Nilsson

[OE-core] [PATCH 2/2] package: Use shlex instead of deprecated pipe

2023-04-13 Thread Ola x Nilsson
The pipe library is deprecated in Python 3.11 and will be removed in Python 3.13. pipe.quote is just an import of shlex.quote anyway. Signed-off-by: Ola x Nilsson --- meta/lib/oe/package.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/meta/lib/oe/package.py b/meta

[OE-core] [PATCH 1/2] patch.py: Use shlex instead of deprecated pipe

2023-04-13 Thread Ola x Nilsson
The pipe library is deprecated in Python 3.11 and will be removed in Python 3.13. pipe.quote is just an import of shlex.quote anyway. Clean up imports while we're at it. Signed-off-by: Ola x Nilsson --- meta/lib/oe/patch.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions

Re: [OE-core][PATCH 1/2] kernel-module-split: make autoload and probeconf distribution specific

2023-02-16 Thread Ola x Nilsson
669c40ed8ebf480c95ce36135104e474e361a7e6#n658 > > So I need to implement this in another way, maybe relocating the files from > /etc only when systemd is enabled. > > Thanks for raising the issue. > > Jose > Hi, Please consider https://bugzilla.yoctoproject.org/

Re: [OE-core] v2: Y2038: Sanity checker for non-64-bit time and file functions

2022-12-16 Thread Ola x Nilsson
On Fri, Dec 16 2022, Ola x Nilsson wrote: > v2: > > Renamed conf/distro/time64.conf -> conf/distro/time64.inc > Use SITEINFO_BITS to select when to apply GLIBC_64BIT_TIME_FLAGS. > > > I did not add _LARGEFILE to the option yet as I do not believe it is > the right

[OE-core] [PATCH RFC v2 1/2] Add QA check for 32 bit time and file offset functions

2022-12-16 Thread Ola x Nilsson
Check for known symbols that should have been redirected to 64bit variants when -D_FILE_OFFSET_BITS=64 and -D_TIME_BITS=64 are set. Signed-off-by: Ola x Nilsson --- meta/classes-global/insane.bbclass | 132 + 1 file changed, 132 insertions(+) diff --git a/meta

[OE-core] v2: Y2038: Sanity checker for non-64-bit time and file functions

2022-12-16 Thread Ola x Nilsson
v2: Renamed conf/distro/time64.conf -> conf/distro/time64.inc Use SITEINFO_BITS to select when to apply GLIBC_64BIT_TIME_FLAGS. I did not add _LARGEFILE to the option yet as I do not believe it is the right place. The _TIME_BITS=64 and _FILE_OFFSET_BITS=64 option redefine types and functions.

[OE-core] [PATCH RFC v2 2/2] time64.inc: Include to enable 64 bit time flags

2022-12-16 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/conf/distro/include/time64.inc | 20 1 file changed, 20 insertions(+) create mode 100644 meta/conf/distro/include/time64.inc diff --git a/meta/conf/distro/include/time64.inc b/meta/conf/distro/include/time64.inc new file mode 100644

Re: [OE-core] [PATCH RFC 3/3] time64.conf: Include to enable 64 bit time flags

2022-12-09 Thread Ola x Nilsson
On Thu, Dec 08 2022, Alexander Kanavin wrote: > On Thu, 8 Dec 2022 at 08:11, Ola x Nilsson wrote: >> +GLIBC_64BIT_TIME_FLAGS:pn-glibc = "" >> +GLIBC_64BIT_TIME_FLAGS:pn-glibc-tests = "" >> +# pipewire-v4l2 explicitly sets _FILE_OFFSET_BITS=32 to get acc

Re: [OE-core] [PATCH RFC 3/3] time64.conf: Include to enable 64 bit time flags

2022-12-09 Thread Ola x Nilsson
On Thu, Dec 08 2022, Richard Purdie wrote: > On Thu, 2022-12-08 at 11:00 +0100, Alexander Kanavin wrote: >> On Thu, 8 Dec 2022 at 08:11, Ola x Nilsson wrote: >> > +# TODO: Only for 32-bit architectures? >> > +TARGET_CC_ARCH:append:arm =

Re: [OE-core] [PATCH RFC 3/3] time64.conf: Include to enable 64 bit time flags

2022-12-09 Thread Ola x Nilsson
On Fri, Dec 09 2022, Khem Raj wrote: > Thanks for the patches > > On 12/7/22 23:11, Ola x Nilsson wrote: >> Signed-off-by: Ola x Nilsson >> --- >> meta/conf/distro/time64.conf | 23 +++ >> 1 file changed, 23 insertions(+) >> cre

[OE-core] [PATCH RFC 1/3] glibc: Add ppoll fortify symbol for 64 bit time_t

2022-12-07 Thread Ola x Nilsson
Patch so ppoll is properly redirected to it's 64bit time variant even when source fortification is active. Signed-off-by: Ola x Nilsson --- ...fortify-symbol-for-64-bit-time_t-BZ-.patch | 528 ++ meta/recipes-core/glibc/glibc_2.36.bb | 1 + 2 files changed, 529

[OE-core] [PATCH RFC 3/3] time64.conf: Include to enable 64 bit time flags

2022-12-07 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/conf/distro/time64.conf | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 meta/conf/distro/time64.conf diff --git a/meta/conf/distro/time64.conf b/meta/conf/distro/time64.conf new file mode 100644 index 00

[OE-core] [PATCH RFC 2/3] Add QA check for 32 bit time and file offset functions

2022-12-07 Thread Ola x Nilsson
Check for known symbols that should have been redirected to 64bit variants when -D_FILE_OFFSET_BITS=64 and -D_TIME_BITS=64 are set. Signed-off-by: Ola x Nilsson --- meta/classes-global/insane.bbclass | 132 + 1 file changed, 132 insertions(+) diff --git a/meta

[OE-core] Y2038: Sanity checker for non-64-bit time and file functions

2022-12-07 Thread Ola x Nilsson
Here is my sanity checker that check for glibc symbols that use 32-bit time_t or file offsets. I include one glibc patch that fixes a problem where the redirect for ppoll did not work when fortify_source was enabled. Also include some distro settings for the -F_TIME_BITS=64 flags that I have

Re: [yocto] [OE-core] [Openembedded-architecture] Y2038 proposal

2022-12-05 Thread Ola x Nilsson
On Mon, Dec 05 2022, Richard Purdie wrote: > On Mon, 2022-12-05 at 11:00 +0100, Ola x Nilsson wrote: >> On Wed, Nov 30 2022, Richard Purdie wrote: >> >> > On Wed, 2022-11-30 at 17:56 +0100, Alexandre Belloni wrote: >> > > On 30/11/2022 16:46:17+, Ross B

Re: [yocto] [OE-core] [Openembedded-architecture] Y2038 proposal

2022-12-05 Thread Ola x Nilsson
we actually use so far so we could get to a testable system. My biggest worry at the moment is rust, I know to little to know if it is an actual problem and how to fix it. I would like to be part of any "y2038 team" for Yocto. -- Ola x Nilsson -=-=-=-=-=-=-=-=-=-=-=- Links: You

[OE-core] [PATCH v2] kbd: Don't build tests

2022-11-24 Thread Ola x Nilsson
Add --disable-tests to EXTRA_OECONF as the tests are not usable in ptest - they can only run in-situ - and fails to build when building with -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64. Signed-off-by: Ola x Nilsson --- meta/recipes-core/kbd/kbd_2.5.1.bb | 1 + 1 file changed, 1 insertion(+) diff

Re: [OE-core] [PATCH] kbd: DEPEND on bison-native and don't build tests

2022-11-24 Thread Ola x Nilsson
On Thu, Nov 24 2022, Richard Purdie wrote: > On Thu, 2022-11-24 at 17:52 +0100, Ola x Nilsson wrote: >> bison-native is required if any .y-file is changed, by patch or in >> devtool. Otherwise the build will fail with > > The key point is that we don't patch any .

[OE-core] [PATCH] kbd: DEPEND on bison-native and don't build tests

2022-11-24 Thread Ola x Nilsson
in-situ - and fails when building with -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64. Signed-off-by: Ola x Nilsson --- meta/recipes-core/kbd/kbd_2.5.1.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/recipes-core/kbd/kbd_2.5.1.bb b/meta/recipes-core/kbd/kbd_2.5.1.bb index

Re: [OE-core] [RFC PATCH 2/3] kbd: Disable 64 bit time with 32 bit glibc

2022-11-08 Thread Ola x Nilsson
uld be ready > for it. > > Alex > > > > > On Tue, 8 Nov 2022 at 18:58, Ola x Nilsson wrote: >> >> >> And here is a link to the documentation for the _TIME_BITS Feature Test >> Macro >> https://www.gnu.org/software/libc/manual/html_node/Fea

Re: [OE-core] [RFC PATCH 2/3] kbd: Disable 64 bit time with 32 bit glibc

2022-11-08 Thread Ola x Nilsson
And here is a link to the documentation for the _TIME_BITS Feature Test Macro https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html#index-_005fTIME_005fBITS The docs for _FILE_OFFSET_BITS is just above. /Ola On Tue, Nov 08 2022, Ola x Nilsson wrote: > Sorry, that l

Re: [OE-core] [RFC PATCH 2/3] kbd: Disable 64 bit time with 32 bit glibc

2022-11-08 Thread Ola x Nilsson
Sorry, that link did not explain the -D_USE_TIME_BITS=64 flag. I was sure I had read official docs of this somewhere but now I can only find https://sourceware.org/glibc/wiki/Y2038ProofnessDesign#Detailed_implementation /Ola On Tue, Nov 08 2022, Ola x Nilsson wrote: > As far as I can t

Re: [OE-core] [RFC PATCH 2/3] kbd: Disable 64 bit time with 32 bit glibc

2022-11-08 Thread Ola x Nilsson
As far as I can tell from glibc's documentation, this is how you are supposed to do it. glibc chose to always support both 32 and 64 bit APIs for time and file offset and make the normal int size the default. musl chose to switch to 64bit altogether.

Re: [OE-core] [RFC PATCH 1/3] Try to ensure 64 bit time on 32 bit glibcful hosts

2022-11-08 Thread Ola x Nilsson
I'm working on the same thing, but I put GLIBC_64BIT_TIME_CPPFLAGS in TARGET_CC_ARCH instead to make sure they applied everywhere. I'd be interested to hear what others think is the best place to put these flags. I'm also looking at QA tests to make sure that no application or shared object is

[OE-core] [PATCH 4/9] lib/oe/package_manager: Use with to control file handle lifetime

2019-10-21 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/lib/oe/package_manager.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py index 7c373715ad..c841fdbf29 100644 --- a/meta/lib/oe/package_manager.py +++ b/meta/lib/oe

[OE-core] [PATCH 8/9] devtool-source.bbclass: Use with to manage file handle lifetime

2019-10-21 Thread Ola x Nilsson
Replace copy-and-if with a filtering list comprehension. Signed-off-by: Ola x Nilsson --- meta/classes/devtool-source.bbclass | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/meta/classes/devtool-source.bbclass b/meta/classes/devtool-source.bbclass index a8110006fb

[OE-core] [PATCH 3/9] lib/oe/packagedata: Use with to control file handle lifetime

2019-10-21 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/lib/oe/packagedata.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/meta/lib/oe/packagedata.py b/meta/lib/oe/packagedata.py index cbde380b03..a82085a792 100644 --- a/meta/lib/oe/packagedata.py +++ b/meta/lib/oe/packagedata.py

[OE-core] [PATCH 2/9] oe.types.path: Use with to control file handle lifetime

2019-10-21 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/lib/oe/types.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/lib/oe/types.py b/meta/lib/oe/types.py index 77ee7ee541..bbbabafbf6 100644 --- a/meta/lib/oe/types.py +++ b/meta/lib/oe/types.py @@ -154,7 +154,8 @@ def path(value

[OE-core] [PATCH 5/9] tinderbox.bbclass: Use with to control file handle lifetime

2019-10-21 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/classes/tinderclient.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/tinderclient.bbclass b/meta/classes/tinderclient.bbclass index 00f453cec1..f7e41f2959 100644 --- a/meta/classes/tinderclient.bbclass +++ b

[OE-core] [PATCH 7/9] package.bbclass: Use with to manage file handle lifetimes

2019-10-21 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/classes/package.bbclass | 76 1 file changed, 34 insertions(+), 42 deletions(-) diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index d8bef3afb0..f955df 100644 --- a/meta/classes

[OE-core] [PATCH 9/9] libc-package.bbclass: Use with to manage filehandle in do_spit_gconvs

2019-10-21 Thread Ola x Nilsson
Tweak the write loop slightly to avoid dict lookups that can easily be done in the for loop. Signed-off-by: Ola x Nilsson --- meta/classes/libc-package.bbclass | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/meta/classes/libc-package.bbclass b/meta/classes

[OE-core] [PATCH 1/9] oeqa/selftest/recipetool: Use with to control file handle lifetime

2019-10-21 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/lib/oeqa/selftest/cases/recipetool.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meta/lib/oeqa/selftest/cases/recipetool.py b/meta/lib/oeqa/selftest/cases/recipetool.py index 1c701a40bf..c1562c63b2 100644 --- a/meta/lib/oeqa

[OE-core] [PATCH 6/9] report-error.bbclass: Use with to control file handle lifetime

2019-10-21 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/classes/report-error.bbclass | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass index ea043b23e1..1a12db1206 100644 --- a/meta/classes/report-error.bbclass +++ b

[OE-core] [PATCH v2] selftest/package: Correct format arguments in test_gdb_hardlink_debug

2018-12-11 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/lib/oeqa/selftest/cases/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oeqa/selftest/cases/package.py b/meta/lib/oeqa/selftest/cases/package.py index 0a88dc25b3..6596dabc32 100644 --- a/meta/lib/oeqa/selftest/cases

Re: [OE-core] [PATCH] selftest/package: Correct format arguments in test_gdb_hardlink_debug

2018-12-11 Thread Ola x Nilsson
On Tue, Dec 11 2018, Burton, Ross wrote: > On Tue, 11 Dec 2018 at 08:58, Ola x Nilsson wrote: >> -self.logger.error("GDB result:\n%s: %s" % output) >> +self.logger.error("GDB result:\n%s: %s", status, output) > > Isn't status

[OE-core] [PATCH] selftest/package: Correct format arguments in test_gdb_hardlink_debug

2018-12-11 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson --- meta/lib/oeqa/selftest/cases/package.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oeqa/selftest/cases/package.py b/meta/lib/oeqa/selftest/cases/package.py index 0a88dc25b3..b0abc2f4ee 100644 --- a/meta/lib/oeqa/selftest/cases

Re: [OE-core] oe-selftest : Unset SANITY_TESTED_DISTROS bugzilla: 11933

2018-11-23 Thread Ola x Nilsson
inal: > > self.remove_variables() > > the function will comment the the unset SANITY_TESTED_DISTROS in local.conf > I would keep/modify the message that SANITY_TESTED_DISTROS is needed, so the user could set it before running oe-selftest the next time. Ju

Re: [OE-core] [PATCH v2] rootfs: possibility to add packages to debug rootfs

2018-10-17 Thread Ola x Nilsson
> diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py > index ddda552263..bf3d4bcf38 100644 > --- a/meta/lib/oe/rootfs.py > +++ b/meta/lib/oe/rootfs.py > @@ -148,6 +148,9 @@ class Rootfs(object, metaclass=ABCMeta): > bb.note(" Install complementary '*-src'

[OE-core] [PATCH] externalsrc.bbclass: Set BB_DONT_CACHE for non-target recipes

2018-10-04 Thread Ola x Nilsson
BB_DONT_CACHE was not set for non-virtual recipes where PN != BPN, such as quilt-native. Recipes that do not set BBCLASSEXTEND should always have BB_DONT_CACHE set by externalsrc. Signed-off-by: Ola x Nilsson --- meta/classes/externalsrc.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [OE-core] [PATCH 1/1] feat(dbg-packages): possibility to add packages to debug rootfs

2018-10-03 Thread Ola x Nilsson
complementary_pkgs += "\n%s-dbg" % add_dbg_pkgs > self.install(complementary_pkgs.split(), attempt_only=True) > except subprocess.CalledProcessError as e: > bb.fatal("Could not compute complementary packages

[OE-core] [PATCH] package.bbclass: Make staticlib problems non-fatal

2018-04-23 Thread Ola x Nilsson
Allow debugsource listing using dwarfsourcefiles to fail for static libraries when the archive content is not as expected. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/classes/package.bbclass | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/meta/c

[OE-core] [PATCH v2] package.bbclass: Include dbgsrc for static libs

2018-04-19 Thread Ola x Nilsson
The debugsource must be added from the package providing the static lib, because any package using that lib does not have access to the source code. Fixes [YOCTO #12558] Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/classes/package.bbclas

Re: [OE-core] [PATCH] package.bbclass: Include dbgsrc for static libs

2018-04-19 Thread Ola x Nilsson
You were right, I needed to check if it was a proper file. I stumbled into another issue, that golang .a files can not be read by dwarfsrcfiles. I'm not familiar with go, so I don't really know what to do about it. This patch is still an improvement in my book, even if it cannot handle go

Re: [OE-core] [PATCH] package.bbclass: Include dbgsrc for static libs

2018-03-27 Thread Ola x Nilsson
ping? -- Ola Nilsson From: openembedded-core-boun...@lists.openembedded.org <openembedded-core-boun...@lists.openembedded.org> on behalf of Ola x Nilsson <ol...@axis.com> Sent: Friday, February 23, 2018 08:46 To: openembedded-core@lists.open

[OE-core] [PATCH] libcgroup: Various fixes

2018-03-06 Thread Ola x Nilsson
* Use PACKAGECONFIG for pam instead of two bb.utils.contains * Add leading whitespace to EXTRA_OEMAKE_append_libc_musl * Usr lnr in do_install_append rather than a sed generated ../-sequence. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/recipes-core/libcgroup/libcgroup_0.41.b

Re: [OE-core] [PATCH 1/8] lib/oe/path: implement is_path_under()

2018-02-22 Thread Ola x Nilsson
> From: openembedded-core-boun...@lists.openembedded.org > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf > Of Paul Eggleton > Sent: den 23 februari 2018 04:02 > To: openembedded-core@lists.openembedded.org > > Signed-off-by: Paul Eggleton >

[OE-core] [PATCH] package.bbclass: Include dbgsrc for static libs

2018-02-22 Thread Ola x Nilsson
The debugsource must be added from the package providing the static lib, because any package using that lib does not have access to the source code. Fixes [YOCTO #12558] Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/classes/package.bbclas

[OE-core] [PATCH] alsa-utils: Install and delete from the same udev-rules-dir

2017-09-21 Thread Ola x Nilsson
The --with-udev-rules-dir option used with udev is exactly what the configure script uses, so there is no need for it. On the other hand, if we do not have an udev.pc file we should tell alsa-utils where to install the rules so we know where they should be deleted from. Signed-off-by: Ola x

Re: [OE-core] [PATCH 2/2] externalsrc.bbclass: Avoid symlink clashes for virtclasses

2017-09-13 Thread Ola x Nilsson
> From: Richard Purdie <richard.pur...@linuxfoundation.org> > Sent: Wednesday, September 13, 2017 12:41 > >On Tue, 2017-09-12 at 11:23 +0000, Ola x Nilsson wrote: >> I noticed that the preceding commit has been merged. &

Re: [OE-core] [PATCH 2/2] externalsrc.bbclass: Avoid symlink clashes for virtclasses

2017-09-12 Thread Ola x Nilsson
I noticed that the preceding commit has been merged. Is there some problem with this one? -- Ola Nilsson From: openembedded-core-boun...@lists.openembedded.org <openembedded-core-boun...@lists.openembedded.org> on behalf of Ola x Nilsson <ol...

[OE-core] [PATCH] devtool: status: Sort entries before printing

2017-09-04 Thread Ola x Nilsson
Sorted entries are easier to read. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- scripts/lib/devtool/standard.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py index 174cc861e1..0998fa7055

[OE-core] [PATCH 2/2] externalsrc.bbclass: Avoid symlink clashes for virtclasses

2017-08-28 Thread Ola x Nilsson
to protect the .git/info/exclude file. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/classes/externalsrc.bbclass| 16 ++- meta/lib/oeqa/selftest/cases/devtool.py | 48 + 2 files changed, 63 insertions(+), 1 deletion(-)

[OE-core] [PATCH 1/2] oeqa/selftest/case: Add recipeinc method

2017-08-28 Thread Ola x Nilsson
to the file in case that is useful. The test_recipe.inc file is usually cleaned up in a finally block, but that block executes before any teardown operations. This blocks any teardown that requires the presence of the test_recipe.inc file. Signed-off-by: Ola x Nilsson <ol...@axis.com> ---

[OE-core] [PATCH] devtool: Compare abspath of both B and S

2017-05-30 Thread Ola x Nilsson
{B} != ${S} but the abspaths are equal. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- scripts/lib/devtool/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lib/devtool/__init__.py b/scripts/lib/devtool/__init__.py index d646b0cf63..29c4c05071 100644 -

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

2017-01-30 Thread Ola x Nilsson
Please name the class image_wic.bbclass instead. As dashes are not allowed in function names, you cannot use the image_wic_do_write_wks_template pattern of function names if you use a class name with a dash in it. -- Ola x Nilsson > -Original Message- > From: openembedded-cor

[OE-core] [PATCH] externalsrc: Hide created symlinks with .git/info/exclude

2017-01-25 Thread Ola x Nilsson
Add created symlinks to the exclude file. This will both make them less distracting and hide them from the srctree_hash_files function. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/classes/externalsrc.bbclass | 17 - 1 file changed, 16 insertions(+), 1 de

[OE-core] [PATCH v3 2/2] oe-selftest: devtool: Add test for externalsrc buildclean

2017-01-09 Thread Ola x Nilsson
Test both for S == B and S != B. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/lib/oeqa/selftest/devtool.py | 46 +++ 1 file changed, 46 insertions(+) diff --git a/meta/lib/oeqa/selftest/devtool.py b/meta/lib/oeqa/selftest/devtool.py index 2

[OE-core] [PATCH v3 1/2] externalsrc.bbclass: Add task buildclean

2017-01-09 Thread Ola x Nilsson
when calling bitbake -c clean. For S != B, do not add it before clean as it is not needed and may take some time. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/classes/externalsrc.bbclass | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/meta/c

[OE-core] [PATCH v2 2/2] oe-selftest: devtool: Add test for externalsrc buildclean

2017-01-09 Thread Ola x Nilsson
Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/lib/oeqa/selftest/devtool.py | 46 +++ 1 file changed, 46 insertions(+) diff --git a/meta/lib/oeqa/selftest/devtool.py b/meta/lib/oeqa/selftest/devtool.py index 19c5ccf..c37d194 100644 --- a/meta/li

[OE-core] [PATCH v2 1/2] externalsrc.bbclass: Add task buildclean

2017-01-09 Thread Ola x Nilsson
when calling bitbake -c clean. For S != B, do not add it before clean as it is not needed and may take some time. Signed-off-by: Ola x Nilsson <ol...@axis.com> --- meta/classes/externalsrc.bbclass | 17 + 1 file changed, 17 insertions(+) diff --git a/meta/c

[OE-core] [PATCH v2 0/2] Set STAMPCLEAN for externalsrc when S == B

2017-01-08 Thread Ola x Nilsson
nothing. Fix by setting STAMPCLEAN. Add tests. Ola x Nilsson (2): oe-selftest: devtool: Reverting a change should trigger rebuild externalsrc: Set STAMPCLEAN to match STAMP meta/classes/externalsrc.bbclass | 1 + meta/lib/oeqa/selftest/devtool.py | 54

[OE-core] [PATCH v2 2/2] externalsrc: Set STAMPCLEAN to match STAMP

2017-01-08 Thread Ola x Nilsson
Only the last stamp file should be kept, but unless STAMPCLEAN matches files generated using STAMP old stamp files may linger. This may cause false positives for skipping tasks. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- meta/classes/externalsrc.bbclass | 1 + 1 file chan

[OE-core] [PATCH v2 1/2] oe-selftest: devtool: Reverting a change should trigger rebuild

2017-01-08 Thread Ola x Nilsson
-by: Ola x Nilsson <ola.x.nils...@axis.com> --- meta/lib/oeqa/selftest/devtool.py | 54 +++ 1 file changed, 38 insertions(+), 16 deletions(-) diff --git a/meta/lib/oeqa/selftest/devtool.py b/meta/lib/oeqa/selftest/devtool.py index 19c5ccf..a3beefa 100644 ---

Re: [OE-core] [PATCH] externalsrc.bbclass: Add task buildclean

2016-12-22 Thread Ola x Nilsson
Paul Eggleton wrote > Hi Ola, > > I like this, thanks. Just one thing commented below. > > On Thu, 22 Dec 2016 14:28:03 Ola x Nilsson wrote: > > > > + bb.build.addtask('do_makeclean', 'do_clean', None, d) > > + > > Shouldn't this be do_

[OE-core] [PATCH] externalsrc: Add optional srcdir arg to srctree_hash_files

2016-12-22 Thread Ola x Nilsson
Make it easier to reuse the function for other dirs than EXTERNALSRC. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- meta/classes/externalsrc.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/externalsrc.bbclass b/meta/c

[OE-core] [PATCH] externalsrc.bbclass: Add task buildclean

2016-12-22 Thread Ola x Nilsson
bitbake -c clean. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- meta/classes/externalsrc.bbclass | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass index e115a47..bc82f1f

[OE-core] [PATCH 0/2] Set STAMPCLEAN for externalsrc when S == B

2016-12-22 Thread Ola x Nilsson
nothing. Fix by setting STAMPCLEAN. Add tests. Ola x Nilsson (2): oe-selftest: devtool: Reverting a change should trigger rebuild externalsrc: Set STAMPCLEAN to match STAMP meta/classes/externalsrc.bbclass | 1 + meta/lib/oeqa/selftest/devtool.py | 54

[OE-core] [PATCH 2/2] externalsrc: Set STAMPCLEAN to match STAMP

2016-12-22 Thread Ola x Nilsson
Only the last stamp file should be kept, but unless STAMPCLEAN matches files generated using STAMP old stamp files may linger. This may cause false positives for skipping tasks. --- meta/classes/externalsrc.bbclass | 1 + 1 file changed, 1 insertion(+) diff --git

[OE-core] [PATCH 1/2] oe-selftest: devtool: Reverting a change should trigger rebuild

2016-12-22 Thread Ola x Nilsson
Add code to verify that not only does a change trigger a build, but so does reverting that change. Reverting a change in a devtool managed git repo may cause the current checksum to match the checksum of a previous build, which will cause bitbake to skip builds that are needed. ---

[OE-core] [PATCH] oe-pkgdata-util: Make read-value handle override variables

2016-12-12 Thread Ola x Nilsson
Some variables in pkgdata files have a package-name override. When the bare variable can not be found, try with the override-variant. PKGSIZE is one such variable, and already had special code to handle this. Test included. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- me

Re: [OE-core] [PATCH 0/4] Load devtool and reciptool plugins in a well-defined manner

2016-12-05 Thread Ola x Nilsson
Ping? -- Ola x Nilsson > -Original Message- > From: Ola x Nilsson [mailto:ol...@axis.com] > Sent: den 25 oktober 2016 13:04 > To: Ola x Nilsson; openembedded-core@lists.openembedded.org > Subject: [PATCH 0/4] Load devtool and reciptool plugins in a well-defined > manne

[OE-core] [PATCH 0/4] Load devtool and reciptool plugins in a well-defined manner

2016-10-25 Thread Ola x Nilsson
From: Ola x Nilsson <ola.x.nils...@axis.com> Make devtool and recipetool load plugins in a well-defined and expected manner. devtool and reciptool search for pluings first in scripts/lib/ and then in BBPATH. Each found plugin is loaded, which means that any plugin found later in BBPATH s

[OE-core] [PATCH 3/4] devtool: Load plugins in a well defined order

2016-10-25 Thread Ola x Nilsson
From: Ola x Nilsson <ola.x.nils...@axis.com> To allow devtool plugins in one layer to shadow another in a well defined way, first search BBPATH/lib/devtool directories and then scripts/lib/devool and load only the first found. The previous search and load loop would load all found p

[OE-core] [PATCH 4/4] recipetool: Load plugins in a well defined order

2016-10-25 Thread Ola x Nilsson
From: Ola x Nilsson <ola.x.nils...@axis.com> To allow recipetool plugins in one layer to shadow another in a well defined way, first search BBPATH/lib/recipetool directories and then scripts/lib/recipetool and load only the first found. The previous search and load loop would load all

[OE-core] [PATCH 2/4] recipetool: selftest: Add test for recipetool plugin loading

2016-10-25 Thread Ola x Nilsson
From: Ola x Nilsson <ola.x.nils...@axis.com> Test that recipetool plugins are loaded in a well defined order. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- meta-selftest/lib/recipetool/bbpath.py | 41 +++ meta/lib/oeqa/selftest/recipeto

[OE-core] [PATCH 1/4] devtool: selftest: add test for devtool plugin loading

2016-10-25 Thread Ola x Nilsson
From: Ola x Nilsson <ola.x.nils...@axis.com> Test that devtool plugins are loaded in a well defined order. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- meta-selftest/lib/devtool/bbpath.py | 44 + meta/lib/oeqa/selftest/devto

Re: [OE-core] [PATCH] devtool: Only register each plugin once

2016-10-11 Thread Ola x Nilsson
> From: kerg...@gmail.com [mailto:kerg...@gmail.com] On Behalf Of Christopher > Larson > Sent: den 10 oktober 2016 21:13 >> On Mon, Oct 10, 2016 at 7:19 AM, Ola x Nilsson <ola.x.nils...@axis.com> >> wrote: >> When a devtool plugin is shadowed in a higher-prior

[OE-core] [PATCH] devtool: Only register each plugin once

2016-10-10 Thread Ola x Nilsson
- shadowed or not - is loaded and initialized. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- scripts/devtool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/devtool b/scripts/devtool index 0c32c50..7b134a6 100755 --- a/scripts/devtool +++ b/scripts/devtool @@

Re: [OE-core] [PATCH 5/9] recipetool: create: support git submodules

2016-09-07 Thread Ola x Nilsson
> From: openembedded-core-boun...@lists.openembedded.org > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf > Of Paul Eggleton > Sent: den 6 september 2016 12:03 > > Ensure we fetch submodules and set SRC_URI correctly when pointing to a > git repository that contains

[OE-core] [PATCH] devtool: build_image: Fix recipe filter

2016-08-23 Thread Ola x Nilsson
The missing split() causes dev and dbg packages to match. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- scripts/lib/devtool/build_image.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lib/devtool/build_image.py b/scripts/lib/devtool/build_im

[OE-core] [PATCH] devtool: Use the wildcard flag in update_recipe_patch

2016-08-23 Thread Ola x Nilsson
The --wilcard-version flag was only used in the srcrev variant of the update-recipe command. Signed-off-by: Ola x Nilsson <ola.x.nils...@axis.com> --- scripts/lib/devtool/standard.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/d

  1   2   >