Re: [OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2014-06-04 Thread yzhu1
Hi, Saul Sorry. I do not understand. What does the patch fix? After this patch is applied, what is the difference? Zhu Yanjun On 01/23/2014 02:50 PM, Saul Wold wrote: From: Joao Henrique Ferreira de Freitas Previous change (086ce22b88f5ef5f75a83119a32c8b3fdcfa296d) broke the creating of vmd

Re: [OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2014-01-23 Thread Otavio Salvador
On Thu, Jan 23, 2014 at 10:21 AM, Richard Purdie wrote: > On Thu, 2014-01-23 at 07:04 +, Phil Blundell wrote: >> On Wed, 2014-01-22 at 22:50 -0800, Saul Wold wrote: >> > +IS_VMDK = '${@base_contains("IMAGE_FSTYPES", "vmdk", "true", "false", d)}' >> > + >> > + if [ "${IS_VMDK}" ]; then >> >>

Re: [OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2014-01-23 Thread Richard Purdie
On Thu, 2014-01-23 at 07:04 +, Phil Blundell wrote: > On Wed, 2014-01-22 at 22:50 -0800, Saul Wold wrote: > > +IS_VMDK = '${@base_contains("IMAGE_FSTYPES", "vmdk", "true", "false", d)}' > > + > > + if [ "${IS_VMDK}" ]; then > > Does that really work? I can't quite see how it would, but I mi

Re: [OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2014-01-23 Thread Otavio Salvador
On Thu, Jan 23, 2014 at 4:50 AM, Saul Wold wrote: > From: Joao Henrique Ferreira de Freitas > > Previous change (086ce22b88f5ef5f75a83119a32c8b3fdcfa296d) broke > the creating of vmdk images. This protects shell expansion variables > and let dd generate the image to be transformed to vmdk by imag

Re: [OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2014-01-22 Thread Phil Blundell
On Wed, 2014-01-22 at 22:50 -0800, Saul Wold wrote: > +IS_VMDK = '${@base_contains("IMAGE_FSTYPES", "vmdk", "true", "false", d)}' > + > + if [ "${IS_VMDK}" ]; then Does that really work? I can't quite see how it would, but I might be overlooking something. Presumably you did test this, right

[OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2014-01-22 Thread Saul Wold
From: Joao Henrique Ferreira de Freitas Previous change (086ce22b88f5ef5f75a83119a32c8b3fdcfa296d) broke the creating of vmdk images. This protects shell expansion variables and let dd generate the image to be transformed to vmdk by image-vmdk.class. Signed-off-by: Joao Henrique Ferreira de Frei

Re: [OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2013-12-20 Thread Paul Eggleton
On Friday 20 December 2013 12:32:38 Martin Jansa wrote: > On Fri, Dec 20, 2013 at 08:10:24AM -0200, Joao Henrique Ferreira de Freitas > wrote: > > Previous change (086ce22b88f5ef5f75a83119a32c8b3fdcfa296d) broke > > the creating of vmdk images. This protects shell expansion variables > > and let dd

Re: [OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2013-12-20 Thread Martin Jansa
On Fri, Dec 20, 2013 at 08:10:24AM -0200, Joao Henrique Ferreira de Freitas wrote: > Previous change (086ce22b88f5ef5f75a83119a32c8b3fdcfa296d) broke > the creating of vmdk images. This protects shell expansion variables > and let dd generate the image to be transformed to vmdk by image-vmdk.class

[OE-core] [PATCH] boot-directdisk: fix the support of vmdk

2013-12-20 Thread Joao Henrique Ferreira de Freitas
Previous change (086ce22b88f5ef5f75a83119a32c8b3fdcfa296d) broke the creating of vmdk images. This protects shell expansion variables and let dd generate the image to be transformed to vmdk by image-vmdk.class. --- meta/classes/boot-directdisk.bbclass | 16 ++-- 1 file changed, 6 inser