Re: [OE-core] [PATCH] gcc-runtime: do_check should execute before do_build

2021-07-30 Thread bkylerussell
I see. I had forgotten that the autobuilders don't run do_check as part of the normal build. We have a customization in our distro layer to run do_check on normal builds. Internally, we use that as a hook to allow per-package test suites to fail our integration pipeline during our normal builds. M

Re: [OE-core] [PATCH] gcc-runtime: do_check should execute before do_build

2021-07-30 Thread Richard Purdie
On Fri, 2021-07-30 at 14:16 -0700, Christopher Larson wrote: > This will result in a behavior change, making it so `bitbake gcc-runtime` will > run the check task. Are there implications to this? We definitely do not want to do that. This is used to run the testsuite which isn't part of a normal b

Re: [OE-core] [PATCH] gcc-runtime: do_check should execute before do_build

2021-07-30 Thread Christopher Larson
This will result in a behavior change, making it so `bitbake gcc-runtime` will run the check task. Are there implications to this? On Fri, Jul 30, 2021 at 12:04 PM wrote: > Otherwise, when rm_work is used, do_check may not execute before rm_work > causing do_check failures if the workdir has bee

[OE-core] [PATCH] gcc-runtime: do_check should execute before do_build

2021-07-30 Thread bkylerussell
Otherwise, when rm_work is used, do_check may not execute before rm_work causing do_check failures if the workdir has been removed underneath it. Signed-off-by: Kyle Russell --- meta/recipes-devtools/gcc/gcc-runtime.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/rec