Re: [OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-13 Thread Peter Kjellerstedt
> -Original Message- > From: openembedded-core@lists.openembedded.org > On Behalf Of Richard Purdie > Sent: den 12 september 2022 10:44 > To: Ross Burton ; > openembedded-core@lists.openembedded.org > Cc: schnitzelt...@gmail.com > Subject: Re: [OE-core] [PATCH]

Re: [OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-12 Thread Andreas Müller
On Mon, Sep 12, 2022 at 11:43 AM Richard Purdie wrote: > > On Sun, 2022-09-11 at 23:21 +0100, Richard Purdie via > lists.openembedded.org wrote: > > On Fri, 2022-09-09 at 23:54 +0100, Richard Purdie via > > lists.openembedded.org wrote: > > > On Fri, 2022-09-09 at 17:36 +0100, Ross Burton wrote:

Re: [OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-12 Thread Richard Purdie
On Sun, 2022-09-11 at 23:21 +0100, Richard Purdie via lists.openembedded.org wrote: > On Fri, 2022-09-09 at 23:54 +0100, Richard Purdie via > lists.openembedded.org wrote: > > On Fri, 2022-09-09 at 17:36 +0100, Ross Burton wrote: > > > The KDE build uses custom catalogs by setting

Re: [OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-11 Thread Richard Purdie
On Fri, 2022-09-09 at 23:54 +0100, Richard Purdie via lists.openembedded.org wrote: > On Fri, 2022-09-09 at 17:36 +0100, Ross Burton wrote: > > The KDE build uses custom catalogs by setting XML_CATALOG_FILES, so this > > wrapper should not override that value if it has already been set. > > > >

Re: [OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-09 Thread Richard Purdie
On Fri, 2022-09-09 at 17:36 +0100, Ross Burton wrote: > The KDE build uses custom catalogs by setting XML_CATALOG_FILES, so this > wrapper should not override that value if it has already been set. > > Signed-off-by: Ross Burton > --- > meta/recipes-core/libxml/libxml2_2.9.14.bb | 2 +- > 1

Re: [OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-09 Thread Jacob Kroon
On 9/9/22 19:00, Ross Burton wrote: - create_wrapper ${D}${bindir}/xmllint XML_CATALOG_FILES=${sysconfdir}/xml/catalog + create_wrapper ${D}${bindir}/xmllint 'XML_CATALOG_FILES=${XML_CATALOG_FILES:-${sysconfdir}/xml/catalog}' That ...:-${sysconfdir}/... looks odd. Is that hyphen

Re: [OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-09 Thread Ross Burton
>> - create_wrapper ${D}${bindir}/xmllint >> XML_CATALOG_FILES=${sysconfdir}/xml/catalog >> +create_wrapper ${D}${bindir}/xmllint >> 'XML_CATALOG_FILES=${XML_CATALOG_FILES:-${sysconfdir}/xml/catalog}' > > That ...:-${sysconfdir}/... looks odd. Is that hyphen intentional ? Yes:

Re: [OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-09 Thread Jacob Kroon
On 9/9/22 18:36, Ross Burton wrote: The KDE build uses custom catalogs by setting XML_CATALOG_FILES, so this wrapper should not override that value if it has already been set. Signed-off-by: Ross Burton --- meta/recipes-core/libxml/libxml2_2.9.14.bb | 2 +- 1 file changed, 1 insertion(+), 1

[OE-core] [PATCH] libxml2: don't override XML_CATALOG_FILES in xmllint wrapper if already set

2022-09-09 Thread Ross Burton
The KDE build uses custom catalogs by setting XML_CATALOG_FILES, so this wrapper should not override that value if it has already been set. Signed-off-by: Ross Burton --- meta/recipes-core/libxml/libxml2_2.9.14.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git