Re: [OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-09 Thread Richard Purdie
On Tue, 2021-02-09 at 16:37 +0100, Tomasz Dziendzielski wrote: > > Thanks for the answer. > > > I've been giving this some thought and I really don't like having > > to > > remember to manually add special cases like this, it sounds/looks > > like > > something we should really fix in a better

Re: [OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-09 Thread Tomasz Dziendzielski
Thanks for the answer. >I've been giving this some thought and I really don't like having to >remember to manually add special cases like this, it sounds/looks like >something we should really fix in a better way. The other way that comes to my mind would be to loop over all dependencies and

Re: [OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-09 Thread Richard Purdie
On Thu, 2021-02-04 at 13:13 +0100, Tomasz Dziendzielski wrote: > If image recipe depends on another image recipe it will try to use > license recipeinfo that is not deployed. It will result in: > > Exception: FileNotFoundError: [Errno 2] No such file or directory: > >

Re: [OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-04 Thread Tomasz Dziendzielski
>I didn't see anything on the docs mailing list, but we should also >have a matching update to the docs for the new variable (unless it is >already in the docs, I didn't check for that). Thanks, please check now: https://lists.yoctoproject.org/g/docs/message/860 Best regards, Tomasz

Re: [OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-04 Thread Bruce Ashfield
On Thu, Feb 4, 2021 at 7:10 AM Tomasz Dziendzielski wrote: > > If image recipe depends on another image recipe it will try to use > license recipeinfo that is not deployed. It will result in: > | Exception: FileNotFoundError: [Errno 2] No such file or directory: > |

Re: [OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-04 Thread Tomasz Dziendzielski
>I guess I mean should my change (not dep[0] == pn) be removed and yours >take its place as yours should cover that case. Hi Michael, I would say we should keep both. Your change would be enough for most cases and most developers wouldn't even need to care about that problem. I think image

Re: [OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-04 Thread Michael Ho
(Sorry, didn't read your patch correctly, it already included my change). I guess I mean should my change (not dep[0] == pn) be removed and yours take its place as yours should cover that case. Kind regards, Michael Ho -- BMW Car IT GmbH Michael Ho Spezialist Entwicklung – Build and Release

Re: [OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-04 Thread Michael Ho
Hi, I submitted something similar awhile back to this mailing list. https://lists.openembedded.org/g/openembedded-core/message/146607?p=,,,20,0,0,0::relevance,,Michael.Ho%40bmw.de,20,2,0,79619287 If yours makes more sense (I didn't think there's ever a case where an image recipe actually has a

[OE-core] [PATCH] license_image: Introduce SKIP_LICENSE_MANIFEST_RECIPES variable to prevent from trying to use license recipeinfo file from image recipes

2021-02-04 Thread Tomasz Dziendzielski
If image recipe depends on another image recipe it will try to use license recipeinfo that is not deployed. It will result in: | Exception: FileNotFoundError: [Errno 2] No such file or directory: | 'TMPDIR/deploy/licenses/foo-image/recipeinfo' We can't determine in a simple and efficient way if