Re: [OE-core] [PATCH] openssl10: Fix mutliple include assumptions for bn.h in opensslconf.h

2019-03-01 Thread Khem Raj
On Fri, Mar 1, 2019 at 9:35 AM Denys Dmytriyenko wrote: > > On Wed, Feb 27, 2019 at 05:51:23PM -0800, Khem Raj wrote: > > On Mon, Feb 25, 2019 at 7:19 PM Denys Dmytriyenko wrote: > > > > > > Khem, Richard, > > > > > > Sorry for belated reply. I haven't had time for master yet, but since this > >

Re: [OE-core] [PATCH] openssl10: Fix mutliple include assumptions for bn.h in opensslconf.h

2019-03-01 Thread Denys Dmytriyenko
On Wed, Feb 27, 2019 at 05:51:23PM -0800, Khem Raj wrote: > On Mon, Feb 25, 2019 at 7:19 PM Denys Dmytriyenko wrote: > > > > Khem, Richard, > > > > Sorry for belated reply. I haven't had time for master yet, but since this > > just got backported to thud, I'm seeing a similar breakage. > > > >

Re: [OE-core] [PATCH] openssl10: Fix mutliple include assumptions for bn.h in opensslconf.h

2019-02-27 Thread Khem Raj
On Mon, Feb 25, 2019 at 7:19 PM Denys Dmytriyenko wrote: > > Khem, Richard, > > Sorry for belated reply. I haven't had time for master yet, but since this > just got backported to thud, I'm seeing a similar breakage. > > First of all, BN_LLONG not being defined does seem to be "fixed" by this >

Re: [OE-core] [PATCH] openssl10: Fix mutliple include assumptions for bn.h in opensslconf.h

2019-02-27 Thread Denys Dmytriyenko
Ping. Any comments here? Thanks! On Mon, Feb 25, 2019 at 10:19:51PM -0500, Denys Dmytriyenko wrote: > Khem, Richard, > > Sorry for belated reply. I haven't had time for master yet, but since this > just got backported to thud, I'm seeing a similar breakage. > > First of all, BN_LLONG not

Re: [OE-core] [PATCH] openssl10: Fix mutliple include assumptions for bn.h in opensslconf.h

2019-02-25 Thread Denys Dmytriyenko
Khem, Richard, Sorry for belated reply. I haven't had time for master yet, but since this just got backported to thud, I'm seeing a similar breakage. First of all, BN_LLONG not being defined does seem to be "fixed" by this patch, but I'm not entirely sure why it now checks for OPENSSL_SYS_UEFI

[OE-core] [PATCH] openssl10: Fix mutliple include assumptions for bn.h in opensslconf.h

2019-02-06 Thread Khem Raj
After adding #pragma once to wrapper header ( opensslconf.h ) this latent issue got to bite us, where it expect bn.h to be including openssl.h to define BN_* defines, which is fragile. This patch removes the contraints for nested includes for bn.h Signed-off-by: Khem Raj ---