Re: [OE-core] [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES

2022-05-16 Thread Jacob Kroon
On 5/16/22 15:01, Quentin Schulz wrote: Hi Jacob, On 5/16/22 14:52, Jacob Kroon wrote: On 5/16/22 14:38, richard.pur...@linuxfoundation.org wrote: On Mon, 2022-05-16 at 13:43 +0200, Jacob Kroon wrote: Hi Richard, On 5/16/22 13:28, Richard Purdie wrote: Using += unintentionally removes all

Re: [OE-core] [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES

2022-05-16 Thread Quentin Schulz
Hi Jacob, On 5/16/22 14:52, Jacob Kroon wrote: On 5/16/22 14:38, richard.pur...@linuxfoundation.org wrote: On Mon, 2022-05-16 at 13:43 +0200, Jacob Kroon wrote: Hi Richard, On 5/16/22 13:28, Richard Purdie wrote: Using += unintentionally removes all over entries from DISTRO_FEATURES and

Re: [OE-core] [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES

2022-05-16 Thread Richard Purdie
On Mon, 2022-05-16 at 14:52 +0200, Jacob Kroon wrote: > On 5/16/22 14:38, richard.pur...@linuxfoundation.org wrote: > > On Mon, 2022-05-16 at 13:43 +0200, Jacob Kroon wrote: > > > Hi Richard, > > > > > > On 5/16/22 13:28, Richard Purdie wrote: > > > > Using += unintentionally removes all over

Re: [OE-core] [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES

2022-05-16 Thread Jacob Kroon
On 5/16/22 14:38, richard.pur...@linuxfoundation.org wrote: On Mon, 2022-05-16 at 13:43 +0200, Jacob Kroon wrote: Hi Richard, On 5/16/22 13:28, Richard Purdie wrote: Using += unintentionally removes all over entries from DISTRO_FEATURES and "over", you mean "other" ? If so, how is that

Re: [OE-core] [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES

2022-05-16 Thread Richard Purdie
On Mon, 2022-05-16 at 13:43 +0200, Jacob Kroon wrote: > Hi Richard, > > On 5/16/22 13:28, Richard Purdie wrote: > > Using += unintentionally removes all over entries from DISTRO_FEATURES and > > "over", you mean "other" ? If so, how is that possible ? I mean other, I'll fix the typo. It happens

Re: [OE-core] [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES

2022-05-16 Thread Jacob Kroon
Hi Richard, On 5/16/22 13:28, Richard Purdie wrote: Using += unintentionally removes all over entries from DISTRO_FEATURES and "over", you mean "other" ? If so, how is that possible ? this reduces sstate reusage on the autobuilder. Fix this to speed up builds. /Jacob

[OE-core] [PATCH] selftest/imagefeatures/overlayfs: Always append to DISTRO_FEATURES

2022-05-16 Thread Richard Purdie
Using += unintentionally removes all over entries from DISTRO_FEATURES and this reduces sstate reusage on the autobuilder. Fix this to speed up builds. Signed-off-by: Richard Purdie --- meta/lib/oeqa/selftest/cases/imagefeatures.py | 2 +- meta/lib/oeqa/selftest/cases/overlayfs.py | 16