[OE-core] [PATCH] tzcode-native: quote ${CC}

2017-06-23 Thread Enrico Scholz
build fails else with | + make -j 8 -l 6 cc=ccache gcc | make: *** No rule to make target 'gcc'. Stop. Signed-off-by: Enrico Scholz --- meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-19 Thread Khem Raj
On Fri, May 19, 2017 at 11:07 AM, Denys Dmytriyenko wrote: > On Fri, May 19, 2017 at 01:37:59AM +0200, Enrico Scholz wrote: >> Denys Dmytriyenko writes: >> >> >> -EXTRA_OEMAKE += "cc=${CC}" >> >> +EXTRA_OEMAKE += "cc='${CC}'" >> > >> > Should these be

Re: [OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-19 Thread Denys Dmytriyenko
On Fri, May 19, 2017 at 01:37:59AM +0200, Enrico Scholz wrote: > Denys Dmytriyenko writes: > > >> -EXTRA_OEMAKE += "cc=${CC}" > >> +EXTRA_OEMAKE += "cc='${CC}'" > > > > Should these be double-quotes around ${CC}? > > I wrote it in this way: > > - to 60%, because '' is more

Re: [OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-18 Thread Enrico Scholz
Denys Dmytriyenko writes: >> -EXTRA_OEMAKE += "cc=${CC}" >> +EXTRA_OEMAKE += "cc='${CC}'" > > Should these be double-quotes around ${CC}? I wrote it in this way: - to 60%, because '' is more correct than "" in this context (see below) - to 40%, because "" would clutter code

Re: [OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-18 Thread Christopher Larson
On Thu, May 18, 2017 at 2:54 PM, Denys Dmytriyenko wrote: > On Thu, May 18, 2017 at 02:37:29PM -0700, Christopher Larson wrote: > > On Thu, May 18, 2017 at 11:57 AM, Khem Raj wrote: > > > > > On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko

Re: [OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-18 Thread Denys Dmytriyenko
On Thu, May 18, 2017 at 02:37:29PM -0700, Christopher Larson wrote: > On Thu, May 18, 2017 at 11:57 AM, Khem Raj wrote: > > > On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko > > wrote: > > > On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote:

Re: [OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-18 Thread Christopher Larson
On Thu, May 18, 2017 at 11:57 AM, Khem Raj wrote: > On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko > wrote: > > On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote: > >> build fails else with > >> > >> | + make -j 8 -l 6 cc=ccache gcc > >> |

Re: [OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-18 Thread Khem Raj
On Thu, May 18, 2017 at 11:19 AM, Denys Dmytriyenko wrote: > On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote: >> build fails else with >> >> | + make -j 8 -l 6 cc=ccache gcc >> | make: *** No rule to make target 'gcc'. Stop. >> >> Signed-off-by: Enrico Scholz

Re: [OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-18 Thread Denys Dmytriyenko
On Thu, May 18, 2017 at 07:34:23PM +0200, Enrico Scholz wrote: > build fails else with > > | + make -j 8 -l 6 cc=ccache gcc > | make: *** No rule to make target 'gcc'. Stop. > > Signed-off-by: Enrico Scholz > --- >

[OE-core] [PATCH] tzcode-native: quote ${CC}

2017-05-18 Thread Enrico Scholz
build fails else with | + make -j 8 -l 6 cc=ccache gcc | make: *** No rule to make target 'gcc'. Stop. Signed-off-by: Enrico Scholz --- meta/recipes-extended/tzcode/tzcode-native_2017b.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git