Re: [OE-core] [PATCH] u-boot: do_compile depends on the value of UBOOT_LOCALVERSION

2023-05-30 Thread Denys Dmytriyenko
On Tue, May 30, 2023 at 03:47:07PM +0100, Richard Purdie wrote: > On Mon, 2023-05-29 at 12:06 -0400, Denys Dmytriyenko wrote: > > On Mon, May 29, 2023 at 01:41:00PM +0100, Richard Purdie wrote: > > > On Sun, 2023-05-28 at 17:15 +, Denys Dmytriyenko wrote: > > > > UBOOT_LOCALVERSION is often

Re: [OE-core] [PATCH] u-boot: do_compile depends on the value of UBOOT_LOCALVERSION

2023-05-30 Thread Richard Purdie
On Mon, 2023-05-29 at 12:06 -0400, Denys Dmytriyenko wrote: > On Mon, May 29, 2023 at 01:41:00PM +0100, Richard Purdie wrote: > > On Sun, 2023-05-28 at 17:15 +, Denys Dmytriyenko wrote: > > > UBOOT_LOCALVERSION is often used to pass SCM commit SHA to the code > > > via populating .scmversion

Re: [OE-core] [PATCH] u-boot: do_compile depends on the value of UBOOT_LOCALVERSION

2023-05-29 Thread Denys Dmytriyenko
On Mon, May 29, 2023 at 01:41:00PM +0100, Richard Purdie wrote: > On Sun, 2023-05-28 at 17:15 +, Denys Dmytriyenko wrote: > > UBOOT_LOCALVERSION is often used to pass SCM commit SHA to the code > > via populating .scmversion file at the start of do_compile(). Let's > > explicitly mark

Re: [OE-core] [PATCH] u-boot: do_compile depends on the value of UBOOT_LOCALVERSION

2023-05-29 Thread Richard Purdie
On Sun, 2023-05-28 at 17:15 +, Denys Dmytriyenko wrote: > UBOOT_LOCALVERSION is often used to pass SCM commit SHA to the code > via populating .scmversion file at the start of do_compile(). Let's > explicitly mark do_compile() as depending on the the value of this > variable to avoid errors

[OE-core] [PATCH] u-boot: do_compile depends on the value of UBOOT_LOCALVERSION

2023-05-28 Thread Denys Dmytriyenko
UBOOT_LOCALVERSION is often used to pass SCM commit SHA to the code via populating .scmversion file at the start of do_compile(). Let's explicitly mark do_compile() as depending on the the value of this variable to avoid errors like this: $ echo 'UBOOT_LOCALVERSION = "${SRCPV}"' >>