Re: [OE-core] [PATCH] update-rc.d.bbclass: fix inhibit check

2014-02-21 Thread Burton, Ross
On 20 February 2014 02:11, Kai Kang kai.k...@windriver.com wrote: In update-rc.d.bbclass it checks variable INHIBIT_UPDATERCD_BBCLASS to inhibit from inheriting this class. But it is wrong logic that when 'sysvinit' is in 'DISTRO_FEATURES', INHIBIT_UPDATERCD_BBCLASS will not be checked. Not

[OE-core] [PATCH] update-rc.d.bbclass: fix inhibit check

2014-02-19 Thread Kai Kang
In update-rc.d.bbclass it checks variable INITSCRIPT_PACKAGES to avoid inherit this class. But it is wrong logic to check INITSCRIPT_PACKAGES. When 'sysvinit' is in 'DISTRO_FEATURES', INITSCRIPT_PACKAGES will not be checked. Replace 'or' with 'and' to fix it. Signed-off-by: Kai Kang

Re: [OE-core] [PATCH] update-rc.d.bbclass: fix inhibit check

2014-02-19 Thread Phil Blundell
On Wed, 2014-02-19 at 18:59 +0800, Kai Kang wrote: In update-rc.d.bbclass it checks variable INITSCRIPT_PACKAGES to avoid inherit this class. But it is wrong logic to check INITSCRIPT_PACKAGES. When 'sysvinit' is in 'DISTRO_FEATURES', INITSCRIPT_PACKAGES will not be checked. Er, really? From

Re: [OE-core] [PATCH] update-rc.d.bbclass: fix inhibit check

2014-02-19 Thread Laurentiu Palcu
On Wed, Feb 19, 2014 at 06:59:26PM +0800, Kai Kang wrote: In update-rc.d.bbclass it checks variable INITSCRIPT_PACKAGES to avoid inherit this class. But it is wrong logic to check INITSCRIPT_PACKAGES. When 'sysvinit' is in 'DISTRO_FEATURES', INITSCRIPT_PACKAGES will not be checked.

Re: [OE-core] [PATCH] update-rc.d.bbclass: fix inhibit check

2014-02-19 Thread Kang Kai
On 2014年02月19日 19:43, Phil Blundell wrote: On Wed, 2014-02-19 at 18:59 +0800, Kai Kang wrote: In update-rc.d.bbclass it checks variable INITSCRIPT_PACKAGES to avoid inherit this class. But it is wrong logic to check INITSCRIPT_PACKAGES. When 'sysvinit' is in 'DISTRO_FEATURES',

[OE-core] [PATCH] update-rc.d.bbclass: fix inhibit check

2014-02-19 Thread Kai Kang
In update-rc.d.bbclass it checks variable INHIBIT_UPDATERCD_BBCLASS to inhibit from inheriting this class. But it is wrong logic that when 'sysvinit' is in 'DISTRO_FEATURES', INHIBIT_UPDATERCD_BBCLASS will not be checked. Replace 'or' with 'and' to fix it. Signed-off-by: Kai Kang