Re: [OE-core] [PATCH 0/8] runqemu: refactor it and remove machine knowledge

2016-08-18 Thread Robert Yang
On 08/19/2016 09:45 AM, Mark Hatle wrote: On 8/18/16 8:06 PM, Robert Yang wrote: On 08/19/2016 05:47 AM, Mark Hatle wrote: General comment on the patch set. I do like what this change is trying to accomplish. However, I think putting QEMU knowledge into the 'arch' is a bad idea -- unless

Re: [OE-core] [PATCH 0/8] runqemu: refactor it and remove machine knowledge

2016-08-18 Thread Mark Hatle
On 8/18/16 8:06 PM, Robert Yang wrote: > > > On 08/19/2016 05:47 AM, Mark Hatle wrote: >> General comment on the patch set. >> >> I do like what this change is trying to accomplish. However, I think putting >> QEMU knowledge into the 'arch' is a bad idea -- unless it's being used to run >> the e

Re: [OE-core] [PATCH 0/8] runqemu: refactor it and remove machine knowledge

2016-08-18 Thread Robert Yang
On 08/19/2016 05:47 AM, Mark Hatle wrote: General comment on the patch set. I do like what this change is trying to accomplish. However, I think putting QEMU knowledge into the 'arch' is a bad idea -- unless it's being used to run the emulator for build-time work. The arch could very well be

Re: [OE-core] [PATCH 0/8] runqemu: refactor it and remove machine knowledge

2016-08-18 Thread Mark Hatle
General comment on the patch set. I do like what this change is trying to accomplish. However, I think putting QEMU knowledge into the 'arch' is a bad idea -- unless it's being used to run the emulator for build-time work. The arch could very well be used by kernels that simply can't run in QEMU

Re: [OE-core] [PATCH 0/8] runqemu: refactor it and remove machine knowledge

2016-08-18 Thread Alistair Francis
On Thu, Aug 18, 2016 at 2:36 PM, Alistair Francis wrote: > On Wed, Aug 17, 2016 at 11:15 PM, Robert Yang > wrote: >> Previously, runqemu had hard coded machine knowledge, which limited its >> usage, for example, qemu can boot genericx86, but runqemu can't, we need >> edit runqemu/runqemu-interna

Re: [OE-core] [PATCH 0/8] runqemu: refactor it and remove machine knowledge

2016-08-18 Thread Alistair Francis
On Wed, Aug 17, 2016 at 11:15 PM, Robert Yang wrote: > Previously, runqemu had hard coded machine knowledge, which limited its > usage, for example, qemu can boot genericx86, but runqemu can't, we need > edit runqemu/runqemu-internal a lot if we want to boot genericx86. > > Now bsp conf files can

[OE-core] [PATCH 0/8] runqemu: refactor it and remove machine knowledge

2016-08-17 Thread Robert Yang
Previously, runqemu had hard coded machine knowledge, which limited its usage, for example, qemu can boot genericx86, but runqemu can't, we need edit runqemu/runqemu-internal a lot if we want to boot genericx86. Now bsp conf files can set vars to make it can be boot by runqemu, and qemuboot.bbclas