[OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Peter Seebach
In the usual case, the computed path used for debugedit to fix up path references for the target filesystem is correct. However, prebuilt binary components, such as prebuilt toolchains, can have debug paths that do not reflect paths within the local build directory. Providing an override lets us co

Re: [OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Richard Purdie
On Wed, 2012-07-11 at 20:54 +0100, Burton, Ross wrote: > On 11 July 2012 20:01, Chris Larson wrote: > > That's one possibility. The other would be to treat _append/_prepended > > functions as independent entities. Rather than concatenating > > functions, it'd add them to the prefuncs/postfuncs or

Re: [OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Burton, Ross
On 11 July 2012 20:01, Chris Larson wrote: > That's one possibility. The other would be to treat _append/_prepended > functions as independent entities. Rather than concatenating > functions, it'd add them to the prefuncs/postfuncs or equivalent. > Without concatenation, there'd be no issues with

Re: [OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Chris Larson
On Wed, Jul 11, 2012 at 11:54 AM, Peter Seebach wrote: > Okay, crazy thought. Imagine that we were to make a modified parser, > with the following behavior: > > Whenever reading a python function, count the indentation of the first > line (N), then replace every N spaces of indentation with 4 spa

Re: [OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Peter Seebach
On Wed, 11 Jul 2012 18:36:50 +0100 Richard Purdie wrote: > It should all use 4 space for python functions. There is however a > twist which is due to the way we handle _prepend and _append. Those > prepends and appends have whitespace too and I seem to remember > issues with whitespace matching.

Re: [OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Ross Burton
Incredibly sorry for top-posting, but a build history diff should show any delta and assuming none will give a lot more confidence in the changes being complete. In theory a simple change of indentation shouldn't result in any changes to the image, right? Ross -- Ross Burton Sent with Sparrow

Re: [OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Richard Purdie
On Wed, 2012-07-11 at 11:33 -0500, Peter Seebach wrote: > On Wed, 11 Jul 2012 17:12:29 +0100 > Richard Purdie wrote: > > > I think I at least would find this slightly less confusing as: > > > > workparentdir = d.getVar("DEBUGSRC_OVERRIDE_PATH", True) or > > os.path.dirname(workdir) > > Wait, LE

Re: [OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Peter Seebach
On Wed, 11 Jul 2012 17:12:29 +0100 Richard Purdie wrote: > I think I at least would find this slightly less confusing as: > > workparentdir = d.getVar("DEBUGSRC_OVERRIDE_PATH", True) or > os.path.dirname(workdir) Wait, LESS confusing? I appear to have tragically misunderstood the design goals

Re: [OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Richard Purdie
On Wed, 2012-07-11 at 11:00 -0500, Peter Seebach wrote: > In the usual case, the computed path used for debugedit to fix > up path references for the target filesystem is correct. However, > prebuilt binary components, such as prebuilt toolchains, can > have debug paths that do not reflect paths wi

[OE-core] [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path

2012-07-11 Thread Peter Seebach
In the usual case, the computed path used for debugedit to fix up path references for the target filesystem is correct. However, prebuilt binary components, such as prebuilt toolchains, can have debug paths that do not reflect paths within the local build directory. Providing an override lets us co