Re: [OE-core] [PATCH 1/3] lib/oe/package: Improve filedeprunner subprocess handling

2017-09-01 Thread Richard Purdie
On Fri, 2017-09-01 at 16:32 +, Peter Kjellerstedt wrote: > Even with these changes applied, I still see texinfo succeed to > build  > even when it should not (i.e., without having applied the patch to  > package_deb.bbclass that I just sent). Right, there are some nasty bugs with python's

Re: [OE-core] [PATCH 1/3] lib/oe/package: Improve filedeprunner subprocess handling

2017-09-01 Thread Peter Kjellerstedt
> -Original Message- > From: openembedded-core-boun...@lists.openembedded.org > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of > Richard Purdie > Sent: den 1 september 2017 16:21 > To: openembedded-core@lists.openembedded.org > Subject: [OE-cor

[OE-core] [PATCH 1/3] lib/oe/package: Improve filedeprunner subprocess handling

2017-09-01 Thread Richard Purdie
Currently the exit code of the spawned program isn't checked so it can fail and the do_package task will continue merrily upon its way. Use subprocess.check_output() to ensure we check the exit code and redirect stderr to stdout so if it fails, we see the error output. We can then drop the