Re: [OE-core] [PATCH 2/2] npm: Remove unnecessary configs argument from npm run command

2021-10-20 Thread Stefan Herbrechtsmeier
Am 20.10.2021 um 10:05 schrieb Konrad Weihmann via lists.openembedded.org: Jutst out of interest, why is this unnecessary? That might be worth an explanation as part of the commit message, esp as I think the assignments to 'configs' are still part of the class and now being unused This is a

Re: [OE-core] [PATCH 2/2] npm: Remove unnecessary configs argument from npm run command

2021-10-20 Thread Konrad Weihmann
Jutst out of interest, why is this unnecessary? That might be worth an explanation as part of the commit message, esp as I think the assignments to 'configs' are still part of the class and now being unused On 20.10.21 09:40, Stefan Herbrechtsmeier wrote: From: Stefan Herbrechtsmeier

[OE-core] [PATCH 2/2] npm: Remove unnecessary configs argument from npm run command

2021-10-20 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier Signed-off-by: Stefan Herbrechtsmeier --- meta/classes/npm.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass index 547c531883..ba50fcac20 100644 --- a/meta/classes/npm.bbclass +++