Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-14 Thread Alejandro Hernandez
On 11/13/2018 1:10 AM, Yu, Mingli wrote: On 2018年11月13日 16:25, Alejandro Hernandez wrote: On 11/12/2018 7:03 PM, Yu, Mingli wrote: Hi Alejandro, Many thanks for your comments, please check my comments inline. On 2018年11月12日 23:28, Alejandro Hernandez wrote: Hey Yu, On 11/11/2018 6:28

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-14 Thread Yu, Mingli
On 2018年11月14日 05:26, Alejandro Hernandez wrote: On 11/13/2018 1:10 AM, Yu, Mingli wrote: On 2018年11月13日 16:25, Alejandro Hernandez wrote: On 11/12/2018 7:03 PM, Yu, Mingli wrote: Hi Alejandro, Many thanks for your comments, please check my comments inline. On 2018年11月12日 23:28,

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-13 Thread Alejandro Hernandez
Hey Yu, On 11/11/2018 6:28 PM, Yu, Mingli wrote: On 2018年11月09日 21:02, Burton, Ross wrote: On Fri, 9 Nov 2018 at 01:39, Yu, Mingli wrote: Why is this here and not in the manifest? It's because we can optionally enable or disable tk via PACKAGECONFIG, if add it to manifest then we need

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-13 Thread Yu, Mingli
On 2018年11月13日 16:25, Alejandro Hernandez wrote: On 11/12/2018 7:03 PM, Yu, Mingli wrote: Hi Alejandro, Many thanks for your comments, please check my comments inline. On 2018年11月12日 23:28, Alejandro Hernandez wrote: Hey Yu, On 11/11/2018 6:28 PM, Yu, Mingli wrote: On 2018年11月09日

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-13 Thread Alejandro Hernandez
On 11/12/2018 7:03 PM, Yu, Mingli wrote: Hi Alejandro, Many thanks for your comments, please check my comments inline. On 2018年11月12日 23:28, Alejandro Hernandez wrote: Hey Yu, On 11/11/2018 6:28 PM, Yu, Mingli wrote: On 2018年11月09日 21:02, Burton, Ross wrote: On Fri, 9 Nov 2018 at 01:39,

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-12 Thread Yu, Mingli
Hi Alejandro, Many thanks for your comments, please check my comments inline. On 2018年11月12日 23:28, Alejandro Hernandez wrote: Hey Yu, On 11/11/2018 6:28 PM, Yu, Mingli wrote: On 2018年11月09日 21:02, Burton, Ross wrote: On Fri, 9 Nov 2018 at 01:39, Yu, Mingli wrote: Why is this here and

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-11 Thread Yu, Mingli
On 2018年11月09日 21:02, Burton, Ross wrote: On Fri, 9 Nov 2018 at 01:39, Yu, Mingli wrote: Why is this here and not in the manifest? It's because we can optionally enable or disable tk via PACKAGECONFIG, if add it to manifest then we need to always enable tk which is also the implement in

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-09 Thread Burton, Ross
On Fri, 9 Nov 2018 at 01:39, Yu, Mingli wrote: > > Why is this here and not in the manifest? > > It's because we can optionally enable or disable tk via PACKAGECONFIG, > if add it to manifest then we need to always enable tk which is also the > implement in v1. Are you sure? As I understand it

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-08 Thread Yu, Mingli
On 2018年11月08日 21:49, Burton, Ross wrote: On Thu, 8 Nov 2018 at 06:09, wrote: +if "tkinter" in pypackage and "tk" in pkgconfig: +d.appendVar('FILES_' + pypackage, ' ' + "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so") +if "tkinter" in

Re: [OE-core] [PATCH 2/7] python3: add tk support

2018-11-08 Thread Burton, Ross
On Thu, 8 Nov 2018 at 06:09, wrote: > +if "tkinter" in pypackage and "tk" in pkgconfig: > +d.appendVar('FILES_' + pypackage, ' ' + > "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter*.so") > +if "tkinter" in pypackage and "tk" in pkgconfig: > +

[OE-core] [PATCH 2/7] python3: add tk support

2018-11-07 Thread mingli.yu
From: Mingli Yu Add support to enable tk via PACKAGECONFIG. before this patch: # python3 Python 3.5.6 (default, Nov 8 2018, 04:53:45) [GCC 8.2.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import tkinter Traceback (most recent call last): File