Re: [OE-core] [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon

2019-09-17 Thread Adrian Bunk
On Mon, Sep 16, 2019 at 03:43:42PM -0700, Andre McCurdy wrote: > On Mon, Sep 16, 2019 at 3:34 PM Adrian Bunk wrote: > > > > On Mon, Sep 16, 2019 at 03:08:01PM -0700, Andre McCurdy wrote: > > > On Mon, Sep 16, 2019 at 2:33 PM Christopher Larson > > > wrote: > > > > > > > > This seems like somethi

Re: [OE-core] [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon

2019-09-16 Thread Andre McCurdy
On Mon, Sep 16, 2019 at 3:34 PM Adrian Bunk wrote: > > On Mon, Sep 16, 2019 at 03:08:01PM -0700, Andre McCurdy wrote: > > On Mon, Sep 16, 2019 at 2:33 PM Christopher Larson > > wrote: > > > > > > This seems like something that could do with a ‘why’ in the commit > > > message and/or comments, t

Re: [OE-core] [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon

2019-09-16 Thread Adrian Bunk
On Mon, Sep 16, 2019 at 03:08:01PM -0700, Andre McCurdy wrote: > On Mon, Sep 16, 2019 at 2:33 PM Christopher Larson wrote: > > > > This seems like something that could do with a ‘why’ in the commit message > > and/or comments, to me. > > To be consistent with: > > > https://git.openembedded.

Re: [OE-core] [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon

2019-09-16 Thread Andre McCurdy
On Mon, Sep 16, 2019 at 2:33 PM Christopher Larson wrote: > > This seems like something that could do with a ‘why’ in the commit message > and/or comments, to me. To be consistent with: https://git.openembedded.org/openembedded-core/commit/?id=1a563214caf6bd5b3a026ebe953f8c692ebd640a > On S

Re: [OE-core] [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon

2019-09-16 Thread Christopher Larson
This seems like something that could do with a ‘why’ in the commit message and/or comments, to me. On Sep 16, 2019, 12:25 PM -0700, Andre McCurdy , wrote: > Signed-off-by: Andre McCurdy > --- > meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb | 11 ++- > 1 file changed, 10 insertions(+), 1 del

[OE-core] [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon

2019-09-16 Thread Andre McCurdy
Signed-off-by: Andre McCurdy --- meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb index 307e37e3fe..c4261248b6 100644 --- a/meta