Re: [OE-core] [PATCH pseudo 4/4] Do not return address of local variable - unverified

2021-07-29 Thread Seebs
On Thu, 29 Jul 2021 14:37:28 +0200 "Damian Wrobel" wrote: > the PSEUDO_MSG_OP is being unconditionally assigned to the msg.type > before any real usage of the 'msg' structure. So, if I'm not mistaken > that code was already tested and didn't work well and was reverted > here[1]. I don't think

Re: [OE-core] [PATCH pseudo 4/4] Do not return address of local variable - unverified

2021-07-29 Thread Damian Wrobel
On Wed, 28 Jul 2021 22:16:41 +0200 Seebs wrote > On Wed, 28 Jul 2021 11:36:22 +0200 > "Damian Wrobel" wrote: > > > Do I correctly assume that pseudo_client_op() has to be fully > > reentrant? > > No. It's never been even a tiny bit reentrant. We used to do the > allocate