Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-29 Thread Richard Purdie
On Mon, 2017-05-29 at 18:54 +0300, Alexander Kanavin wrote: > I see. You are right here. I admit I don't fully understand if it's  > generally okay for -native recipes to look around in (and later use)  > host include  directories like that, as we're striving towards  > reproducible builds, and thi

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-29 Thread Alexander Kanavin
On 05/29/2017 04:06 PM, Max Krummenacher wrote: +- # check if rpm contains a bundled berkeley db +- CHECK_INCLUDE_FILE(rpm/db.h HAVE_RPM_DB_H) ++ set(HAVE_RPM_DB_H 0) Have you looked into what CHECK_INCLUDE_FILE does, and whether it can be fixed? I'd like to hear about your findings. Yes,

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-29 Thread Max Krummenacher
2017-05-29 15:00 GMT+02:00 Max Krummenacher : > 2017-05-29 12:50 GMT+02:00 Alexander Kanavin > : >> On 05/26/2017 11:35 PM, Max Krummenacher wrote: >>> >>> +- # check if rpm contains a bundled berkeley db >>> +- CHECK_INCLUDE_FILE(rpm/db.h HAVE_RPM_DB_H) >>> ++ set(HAVE_RPM_DB_H 0) >> >> >> Have

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-29 Thread Max Krummenacher
2017-05-29 12:50 GMT+02:00 Alexander Kanavin : > On 05/26/2017 11:35 PM, Max Krummenacher wrote: >> >> +- # check if rpm contains a bundled berkeley db >> +- CHECK_INCLUDE_FILE(rpm/db.h HAVE_RPM_DB_H) >> ++ set(HAVE_RPM_DB_H 0) > > > Have you looked into what CHECK_INCLUDE_FILE does, and whether

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-29 Thread Alexander Kanavin
On 05/26/2017 11:35 PM, Max Krummenacher wrote: +- # check if rpm contains a bundled berkeley db +- CHECK_INCLUDE_FILE(rpm/db.h HAVE_RPM_DB_H) ++ set(HAVE_RPM_DB_H 0) Have you looked into what CHECK_INCLUDE_FILE does, and whether it can be fixed? I'd like to hear about your findings. Alex

[OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-26 Thread Max Krummenacher
With rpm v4 in openembedded but on a host with existing /usr/include/rpm/db.h the native build fails to compile. Signed-off-by: Max Krummenacher --- ...01-don-t-pick-up-bundled-db-from-host-rpm.patch | 43 ++ meta/recipes-extended/libsolv/libsolv_0.6.27.bb| 3 +- 2 files

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-23 Thread Alexander Kanavin
On 05/23/2017 12:32 AM, Max Krummenacher wrote: Sorry Max, this is actually worse than the first version. HAVE_RPM_DB_H has to accurately reflect the presence or absence of the header, as that header is later included or not included depending on that. You cannot set it based on checking some lib

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-22 Thread Max Krummenacher
Hi Alex Am Montag, den 22.05.2017, 16:08 +0300 schrieb Alexander Kanavin: > On 05/19/2017 06:48 PM, Max Krummenacher wrote: > > + # check if rpm contains a bundled berkeley db > > +- CHECK_INCLUDE_FILE(rpm/db.h HAVE_RPM_DB_H) > > ++ CHECK_LIBRARY_EXISTS(rpm.so db_create_rpmdb "" HAVE_RPM_DB_H)

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-22 Thread Alexander Kanavin
On 05/19/2017 06:48 PM, Max Krummenacher wrote: + # check if rpm contains a bundled berkeley db +- CHECK_INCLUDE_FILE(rpm/db.h HAVE_RPM_DB_H) ++ CHECK_LIBRARY_EXISTS(rpm.so db_create_rpmdb "" HAVE_RPM_DB_H) Sorry Max, this is actually worse than the first version. HAVE_RPM_DB_H has to accu

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-19 Thread Max Krummenacher
Am Freitag, den 19.05.2017, 16:51 +0100 schrieb Burton, Ross: > On 19 May 2017 at 16:48, Max Krummenacher wrote: > > > +Upstream-Status: Inappropriate [oe build specific] > > > > Is this really inappropriate? We're finding a bug in the build system but > that doesn't mean we're the cause of th

Re: [OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-19 Thread Burton, Ross
On 19 May 2017 at 16:48, Max Krummenacher wrote: > +Upstream-Status: Inappropriate [oe build specific] > Is this really inappropriate? We're finding a bug in the build system but that doesn't mean we're the cause of the breakage. Ross -- ___ Openemb

[OE-core] [PATCH v2] libsolv: don't pick up bundled db from host rpm

2017-05-19 Thread Max Krummenacher
With rpm v4 in openembedded but on a host with existing /usr/include/rpm/db.h the native build fails to compile. Signed-off-by: Max Krummenacher --- ...01-don-t-pick-up-bundled-db-from-host-rpm.patch | 51 ++ meta/recipes-extended/libsolv/libsolv_0.6.26.bb| 3 +- 2 files