Re: [OE-core] [PATCH v2 5/5] shutdown-desktop: give entire path in Exec field

2013-07-04 Thread Laurentiu Palcu
On Thu, Jul 04, 2013 at 04:56:45PM +0100, Tomas Frydrych wrote: > On 04/07/13 16:39, Laurentiu Palcu wrote: > > On 07/04/2013 05:58 PM, Burton, Ross wrote: > >> On 4 July 2013 11:58, Laurentiu Palcu wrote: > > Even though the change you're proposing is OK, involves changing the > > desktop file to

Re: [OE-core] [PATCH v2 5/5] shutdown-desktop: give entire path in Exec field

2013-07-04 Thread Tomas Frydrych
On 04/07/13 16:39, Laurentiu Palcu wrote: > On 07/04/2013 05:58 PM, Burton, Ross wrote: >> On 4 July 2013 11:58, Laurentiu Palcu wrote: > Even though the change you're proposing is OK, involves changing the > desktop file to add the @SBIN@ pattern and move the sed line to > do_install(). Compared

Re: [OE-core] [PATCH v2 5/5] shutdown-desktop: give entire path in Exec field

2013-07-04 Thread Burton, Ross
On 4 July 2013 16:39, Laurentiu Palcu wrote: >> Doing this in postinst is pretty nasty, > Nasty, in what way? How is this line different from the previous line in > the same postinstall? That one is also using sed to change 'halt' to > 'reboot' for qemuarm. Is it the sed you're worried about? This

Re: [OE-core] [PATCH v2 5/5] shutdown-desktop: give entire path in Exec field

2013-07-04 Thread Laurentiu Palcu
On 07/04/2013 05:58 PM, Burton, Ross wrote: > On 4 July 2013 11:58, Laurentiu Palcu wrote: >> +sed -i $D${datadir}/applications/shutdown.desktop -e >> 's#^Exec=\(.*\)#Exec=${base_sbindir}/\1#' > > Doing this in postinst is pretty nasty, Nasty, in what way? How is this line different from

Re: [OE-core] [PATCH v2 5/5] shutdown-desktop: give entire path in Exec field

2013-07-04 Thread Burton, Ross
On 4 July 2013 11:58, Laurentiu Palcu wrote: > +sed -i $D${datadir}/applications/shutdown.desktop -e > 's#^Exec=\(.*\)#Exec=${base_sbindir}/\1#' Doing this in postinst is pretty nasty, instead change the desktop file to contain something like @SBIN@ and run it through sed in do_install. Ros

[OE-core] [PATCH v2 5/5] shutdown-desktop: give entire path in Exec field

2013-07-04 Thread Laurentiu Palcu
A normal user does not have /sbin in its PATH, by default, so having the entire path here allows the correct execution when run as regular user. [YOCTO #4345] Signed-off-by: Laurentiu Palcu --- .../shutdown-desktop/shutdown-desktop.bb |2 ++ 1 file changed, 2 insertions(+) diff -