Re: [OE-core] [PATCH v3] wic: ensure generated disk system identifier is non-zero

2017-07-31 Thread Ed Bartosh
On Mon, Jul 31, 2017 at 06:04:47PM +1000, Jonathan Liu wrote: > > > > How about random.SystemRandom().randrange(1, 0x) ? > > > > random.SystemRandom().randint(1, 0x) actually > This looks ok to me. Thanks. -- Regards, Ed -- ___

Re: [OE-core] [PATCH v3] wic: ensure generated disk system identifier is non-zero

2017-07-31 Thread Jonathan Liu
On 31 July 2017 at 17:58, Jonathan Liu wrote: > Hi Ed, > > On 31 July 2017 at 17:28, Ed Bartosh wrote: >> On Sun, Jul 30, 2017 at 08:37:26PM +1000, Jonathan Liu wrote: >>> Hi Ed, >>> >>> On 30 July 2017 at 20:02, Ed Bartosh

Re: [OE-core] [PATCH v3] wic: ensure generated disk system identifier is non-zero

2017-07-31 Thread Jonathan Liu
Hi Ed, On 31 July 2017 at 17:28, Ed Bartosh wrote: > On Sun, Jul 30, 2017 at 08:37:26PM +1000, Jonathan Liu wrote: >> Hi Ed, >> >> On 30 July 2017 at 20:02, Ed Bartosh wrote: >> > On Sat, Jul 29, 2017 at 12:45:27AM +1000, Jonathan Liu

Re: [OE-core] [PATCH v3] wic: ensure generated disk system identifier is non-zero

2017-07-31 Thread Ed Bartosh
On Sun, Jul 30, 2017 at 08:37:26PM +1000, Jonathan Liu wrote: > Hi Ed, > > On 30 July 2017 at 20:02, Ed Bartosh wrote: > > On Sat, Jul 29, 2017 at 12:45:27AM +1000, Jonathan Liu wrote: > >> Zero may be interpreted as no MBR signature present and another > >>

Re: [OE-core] [PATCH v3] wic: ensure generated disk system identifier is non-zero

2017-07-30 Thread Jonathan Liu
Hi Ed, On 30 July 2017 at 20:02, Ed Bartosh wrote: > On Sat, Jul 29, 2017 at 12:45:27AM +1000, Jonathan Liu wrote: >> Zero may be interpreted as no MBR signature present and another >> partitioning program might install a new MBR signature. >> >> Signed-off-by:

Re: [OE-core] [PATCH v3] wic: ensure generated disk system identifier is non-zero

2017-07-30 Thread Ed Bartosh
On Sat, Jul 29, 2017 at 12:45:27AM +1000, Jonathan Liu wrote: > Zero may be interpreted as no MBR signature present and another > partitioning program might install a new MBR signature. > > Signed-off-by: Jonathan Liu > --- > scripts/lib/wic/plugins/imager/direct.py | 2 +- >

[OE-core] [PATCH v3] wic: ensure generated disk system identifier is non-zero

2017-07-28 Thread Jonathan Liu
Zero may be interpreted as no MBR signature present and another partitioning program might install a new MBR signature. Signed-off-by: Jonathan Liu --- scripts/lib/wic/plugins/imager/direct.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git