Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

BTW, to be consistent with this approach we also need to rename image-live and image-vm, right? Actually, image-live name was the reason for me to name image-wic. On Mon, Jan 30, 2017 at 11:07:22AM -0800, Rick Altherr wrote: > LGTM > > On Mon, Jan 30, 2017 at 10:42 AM, Ed Bartosh

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

On Mon, Jan 30, 2017 at 10:41:27AM -0800, Rick Altherr wrote: > Agreed. What if it was image_types_wic.bbclass and you did something > similar to build_uboot() in image.bbclass? > I can do this for now: IMAGE_TYPE_wic = "image_type_wic" inherit ${IMAGE_TYPE_wic} which is the same as 'inherit

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

On Mon, Jan 30, 2017 at 10:25:59AM -0800, Rick Altherr wrote: > I'm not clear on which path is the preferred one. There are lots of bits > and pieces in image_types.bbclass that implement various image types. > uboot got added as a separate class at some point. The comments in >

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

I'm not clear on which path is the preferred one. There are lots of bits and pieces in image_types.bbclass that implement various image types. uboot got added as a separate class at some point. The comments in local.conf.sample.extended imply IMAGE_CLASSES should be used to load additional

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

On Mon, Jan 30, 2017 at 09:47:42AM -0800, Rick Altherr wrote: > Hmm. In local.conf.sample.extended, I find: > > # Additional image generation features > # > # The following is a list of classes to import to use in the generation of > images > # currently an example class is image_types_uboot > #

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

Hmm. In local.conf.sample.extended, I find: # Additional image generation features # # The following is a list of classes to import to use in the generation of images # currently an example class is image_types_uboot # IMAGE_CLASSES = " image_types_uboot" Indeed, image_types_uboot isn't part of

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

On Mon, Jan 30, 2017 at 09:27:54AM -0800, Rick Altherr wrote: > Why didn't you make this image_types_wic.bbclass and use IMAGE_CLASSES to > load it? Because of the following: - IMAGE_CLASSES[doc] = "A list of classes that all images should inherit." I'm not sure all images should include wic

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

Why didn't you make this image_types_wic.bbclass and use IMAGE_CLASSES to load it? On Fri, Jan 27, 2017 at 12:19 PM, Ed Bartosh wrote: > There is a lot of wic code in image.bbclass and image_types.bbclass > Having all code separated in one file should make it more

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

On Behalf > > Of Ed Bartosh > > Sent: den 27 januari 2017 21:20 > > To: openembedded-core@lists.openembedded.org > > Subject: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image- > > wic.bbclass > > > > There is a lot of wic code in image.bbc

Re: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

e-boun...@lists.openembedded.org > [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf > Of Ed Bartosh > Sent: den 27 januari 2017 21:20 > To: openembedded-core@lists.openembedded.org > Subject: [OE-core] [PATCH v3 01/11] image-wic: move wic code to image- > wic.bbc

[OE-core] [PATCH v3 01/11] image-wic: move wic code to image-wic.bbclass

There is a lot of wic code in image.bbclass and image_types.bbclass Having all code separated in one file should make it more readable and easier to maintain. Signed-off-by: Ed Bartosh --- meta/classes/image-wic.bbclass | 120 +++