Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-03-03 Thread Jate Sujjavanich
Jose, Yes, I forgot to add a sentence saying that my testing confirmed what you said. Your explanation was helpful in learning about this meson build. - Jate On Wed, Mar 3, 2021 at 8:41 AM Jose Quaresma wrote: > Hi Jate, > > Is that behavior that you explain that I am trying to said. > > Jate

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-03-03 Thread Jose Quaresma
Hi Jate, Is that behavior that you explain that I am trying to said. Jate Sujjavanich escreveu no dia quarta, 24/02/2021 à(s) 17:19: > I tested removing the cross-compile detection patch and removing libcap > from PACKAGECONFIG. The build does find setcap on the build machine. > >

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-24 Thread Jate Sujjavanich
I tested removing the cross-compile detection patch and removing libcap from PACKAGECONFIG. The build does find setcap on the build machine. log.do_configure: CONFIGURATION Capatiblity (with libcap): false ... Program /usr/sbin/setcap found: YES (/usr/sbin/setcap) However, meson did pass

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-22 Thread Richard Purdie
On Mon, 2021-02-22 at 17:39 +, Jose Quaresma wrote: > Hi, > > Jate Sujjavanich escreveu no dia segunda, 22/02/2021 à(s) > 15:58: > > If libcap is disabled in PACKAGECONFIG, then arguments two and three mean  > > find_program find could setcap on the build machine. This would mean it is > >

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-22 Thread Jose Quaresma
Hi, Jate Sujjavanich escreveu no dia segunda, 22/02/2021 à(s) 15:58: > If libcap is disabled in PACKAGECONFIG, then arguments two and three mean > find_program find could setcap on the build machine. This would mean it is > not strictly determined by the recipe and it's determined by the >

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-22 Thread Jate Sujjavanich
If libcap is disabled in PACKAGECONFIG, then arguments two and three mean find_program find could setcap on the build machine. This would mean it is not strictly determined by the recipe and it's determined by the configuration of the build machine instead. find_program('setcap',

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-22 Thread Richard Purdie
On Mon, 2021-02-22 at 10:37 -0500, Jate Sujjavanich wrote: > I have submitted to the upstream which I believe is the github > iputils/iputils project. > > My previous thread had the wrong mailing list address, so I am replying to > this question here: > > Thinking further, how about changing

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-22 Thread Jate Sujjavanich
I have submitted to the upstream which I believe is the github iputils/iputils project. My previous thread had the wrong mailing list address, so I am replying to this question here: >Thinking further, how about changing the PACKAGECONFIG to: > >PACKAGECONFIG[libcap] = "-DUSE_CAP=true,

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-20 Thread Jose Quaresma
Hi Jate, IMHO as I mention on the last version of this patch the file 0001-Limit-setcap-search-to-PATH-for-cross-builds.patch is not needed to make the iputils deterministic, the PACKAGECONFIG[libcap] changes on this [Patch 2/2] will do it. On [Patch 1/2] the option -DNO_SETCAP_OR_SUID=true has

Re: [OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-19 Thread Richard Purdie
On Fri, 2021-02-19 at 17:53 +, Jate Sujjavanich wrote: > Limit setcap search to PATH for cross builds preventing host > contamination. Add DEPENDS for libcap-native to supply this for > PACKAGECONFIG libcap. > > The previous setting of NO_SETCAP_OR_SUID broke setuid or setcap of > /bin/ping

[OE-core] [PATCH v3 2/2] iputils: Fix setcap/setuid of executables

2021-02-19 Thread Jate Sujjavanich
Limit setcap search to PATH for cross builds preventing host contamination. Add DEPENDS for libcap-native to supply this for PACKAGECONFIG libcap. The previous setting of NO_SETCAP_OR_SUID broke setuid or setcap of /bin/ping and other executables. Signed-off-by: Jate Sujjavanich ---