Re: [OE-core] [poky] Commit and Patch message guidelines - fifth draft

2011-05-15 Thread Leon Woestenberg
Hello Mark, On Thu, May 12, 2011 at 9:57 PM, Mark Hatle mark.ha...@windriver.com wrote: ... Let the code tell the story of the mechanics of the change (as much as possible), and let your comment tell the other details -- i.e. what the problem was, how it manifested itself (symptoms), and if

Re: [OE-core] [poky] Commit and Patch message guidelines - fifth draft

2011-05-12 Thread Darren Hart
Hi Mark, Thanks for writing this up. I think this is on the right track. A few comments inline... As a side note, I'm currently working with various people on improving our review/pull process which dovetails with this a bit, but probably doesn't need to be explicitly called out here. On

Re: [OE-core] [poky] Commit and Patch message guidelines - fifth draft

2011-05-12 Thread Mark Hatle
On 5/12/11 4:00 PM, Darren Hart wrote: Hi Mark, Thanks for writing this up. I think this is on the right track. A few comments inline... As a side note, I'm currently working with various people on improving our review/pull process which dovetails with this a bit, but probably doesn't

Re: [OE-core] [poky] Commit and Patch message guidelines - fifth draft

2011-05-12 Thread Darren Hart
One more thing. There is a great deal of cross-posting to the various lists. We should discourage this. At least mentioning somewhere in here that patches should be sent to the appropriate list with maintainers and involved developers on CC and not cross posted would be a help. -- Darren On

Re: [OE-core] [poky] Commit and Patch message guidelines - fifth draft

2011-05-12 Thread William Mills
On 05/12/2011 05:11 PM, Darren Hart wrote: One more thing. There is a great deal of cross-posting to the various lists. We should discourage this. At least mentioning somewhere in here that patches should be sent to the appropriate list with maintainers and involved developers on CC and not

Re: [OE-core] [poky] Commit and Patch message guidelines - fifth draft

2011-05-12 Thread Darren Hart
On 05/12/2011 03:05 PM, William Mills wrote: On 05/12/2011 05:11 PM, Darren Hart wrote: One more thing. There is a great deal of cross-posting to the various lists. We should discourage this. At least mentioning somewhere in here that patches should be sent to the appropriate list with

Re: [OE-core] [poky] Commit and Patch message guidelines - fifth draft

2011-05-12 Thread William Mills
On 05/12/2011 07:49 PM, Darren Hart wrote: There is: http://www.yoctoproject.org/community/mailing-lists Which needs to be updated to better reflect the oe-core aspect I think. This might be at least one source of the cross posting as people are not sure poky vs oe-core. It seems to me

Re: [OE-core] [poky] Commit and Patch message guidelines - fifth draft

2011-05-12 Thread Darren Hart
On 05/12/2011 07:03 PM, William Mills wrote: On 05/12/2011 07:49 PM, Darren Hart wrote: There is: http://www.yoctoproject.org/community/mailing-lists Which needs to be updated to better reflect the oe-core aspect I think. This might be at least one source of the cross posting as people