Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Khem Raj
On Wed, May 5, 2021 at 3:21 PM Alexander Kanavin wrote: > On Thu, 6 May 2021 at 00:02, Khem Raj wrote: > >> >> order is, look for ncursesw first so this sed operation removes ncursesw >> from search paths. >> and this commits mentions this change was intentional >> >>

Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Alexander Kanavin
On Thu, 6 May 2021 at 00:02, Khem Raj wrote: > > order is, look for ncursesw first so this sed operation removes ncursesw > from search paths. > and this commits mentions this change was intentional > > https://git.openembedded.org/openembedded-core/commit/?id=188862de64b > > so why should it be

Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Khem Raj
On Wed, May 5, 2021 at 2:54 PM Alexander Kanavin wrote: > On Wed, 5 May 2021 at 23:26, Khem Raj wrote: > >> I went through the history and some of these changes were added by >> you, so I hope you know why they were needed > > > None of them are needed to build the new version and therefore

Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Alexander Kanavin
On Wed, 5 May 2021 at 23:26, Khem Raj wrote: > I went through the history and some of these changes were added by > you, so I hope you know why they were needed None of them are needed to build the new version and therefore none should be kept. Sorry, but I do have a strong view on this: the

Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Khem Raj
On Wed, May 5, 2021 at 12:49 PM Alexander Kanavin wrote: > > On Wed, 5 May 2021 at 21:43, Khem Raj wrote: >> >> > Sorry, no. If I do not understand what it does, the version update is >> > incompatible with it, >> > and there is no trouble detected by the AB from dropping it, then it has >> > to

Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Alexander Kanavin
On Wed, 5 May 2021 at 21:43, Khem Raj wrote: > > Sorry, no. If I do not understand what it does, the version update is > > incompatible with it, > > and there is no trouble detected by the AB from dropping it, then it has > > to go. > > OK thats fair, no one knows everything so drop this patch

Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Khem Raj
On 5/5/21 11:52 AM, Alexander Kanavin wrote: On Wed, 5 May 2021 at 20:13, Khem Raj > wrote: On Wed, May 5, 2021 at 8:20 AM Alexander Kanavin mailto:alex.kana...@gmail.com>> wrote: > > Drop awful ncurses hack; please make a proper patch with a

Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Alexander Kanavin
On Wed, 5 May 2021 at 20:13, Khem Raj wrote: > On Wed, May 5, 2021 at 8:20 AM Alexander Kanavin > wrote: > > > > Drop awful ncurses hack; please make a proper patch with a configure > > option and PACKAGECONFIG. > > > > Lets not delete this unless its causing trouble as it will break > existing

Re: [OE-core] [PATCH 23/61] powertop: update 2.13 -> 2.14

2021-05-05 Thread Khem Raj
On Wed, May 5, 2021 at 8:20 AM Alexander Kanavin wrote: > > Drop awful ncurses hack; please make a proper patch with a configure > option and PACKAGECONFIG. > Lets not delete this unless its causing trouble as it will break existing functionality that users might be depending upon. if there is