[OE-core] [PATCH 1/2] ifupdown: correct the repository location

2018-05-03 Thread Alexander Kanavin
The old repo is gone. Signed-off-by: Alexander Kanavin --- meta/recipes-core/ifupdown/ifupdown_0.8.16.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-core/ifupdown/ifupdown_0.8.16.bb

[OE-core] [PATCH 2/2] babeltrace: switch over to git

2018-05-03 Thread Alexander Kanavin
Tarball directory is gone. Signed-off-by: Alexander Kanavin --- meta/recipes-kernel/lttng/babeltrace_1.5.5.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/recipes-kernel/lttng/babeltrace_1.5.5.bb

[OE-core] ✗ patchtest: failure for "ifupdown: correct the reposito..." and 1 more

2018-05-03 Thread Patchwork
== Series Details == Series: "ifupdown: correct the reposito..." and 1 more Revision: 1 URL : https://patchwork.openembedded.org/series/11970/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been

[OE-core] [PATCH] gtk-doc: 1.27 -> 1.28

2018-05-03 Thread Hong Liu
Upgrade gtk-doc from 1.27 to 1.28. Signed-off-by: Hong Liu --- meta/recipes-gnome/gtk-doc/{gtk-doc_1.27.bb => gtk-doc_1.28.bb} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename meta/recipes-gnome/gtk-doc/{gtk-doc_1.27.bb => gtk-doc_1.28.bb} (93%) diff

[OE-core] [PATCH] wayland:1.14.0->1.15.0

2018-05-03 Thread Hong Liu
Upgrade wayland from 1.14.0 to 1.15.0. Signed-off-by: Hong Liu --- .../recipes-graphics/wayland/{wayland_1.14.0.bb => wayland_1.15.0.bb} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename meta/recipes-graphics/wayland/{wayland_1.14.0.bb =>

[OE-core] [PATCH] cups:2.2.6->2.2.7

2018-05-03 Thread Hong Liu
Upgrade cups 2.2.6 to 2.2.7 Signed-off-by: Hong Liu --- meta/recipes-extended/cups/cups_2.2.6.bb | 6 -- meta/recipes-extended/cups/cups_2.2.7.bb | 6 ++ 2 files changed, 6 insertions(+), 6 deletions(-) delete mode 100644

[OE-core] [PATCH] xcb-proto:1.12->1.13

2018-05-03 Thread Hong Liu
1.Upgrade xcb-proto 1.12 to 1.13 2.Delete 0001-Make-whitespace-use-consistent.patch,0002-print-is-a-function-and-needs-parentheses.patch ,since it is integrated upstream. Signed-off-by: Hong Liu --- .../xorg-proto/{xcb-proto_1.12.bb => xcb-proto_1.13.bb}

Re: [OE-core] 2.6 planning proposals and meeting

2018-05-03 Thread Peter Kjellerstedt
From: openembedded-core-boun...@lists.openembedded.org [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of Scott Rifenbark Sent: den 1 maj 2018 16:56 To: Richard Purdie Cc: openembedded-core

[OE-core] ✗ patchtest: failure for wayland:1.14.0->1.15.0 (rev4)

2018-05-03 Thread Patchwork
== Series Details == Series: wayland:1.14.0->1.15.0 (rev4) Revision: 4 URL : https://patchwork.openembedded.org/series/11971/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the

[OE-core] [PATCH 02/12] gst-plugins-base: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
* For changes, please see: https://gstreamer.freedesktop.org/releases/1.14/ * OpenGL integration library has moved to -plugins-base, add PACKAGECONFIG. * Remove one patch as that has been fixed in a different way upstream. * Merge inc/bb and refresh patches to get rid of fuzz warnings. * Remove

[OE-core] [PATCH 04/12] gst-plugins-bad: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
* For changes, please see: https://gstreamer.freedesktop.org/releases/1.14/ * gst-gl has moved to -good and direct dependencies aren't required. * Remove vulkan patches that have been upstreamed. * Remove obsolete PACKAGECONFIGs. Signed-off-by: Anuj Mittal ---

[OE-core] [PATCH 08/12] gst-validate: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
* For changes, please see: https://gstreamer.freedesktop.org/releases/1.14/. * Patch Makefile to fix compilation errors. Signed-off-by: Anuj Mittal --- ...x-template-paths-when-buildir-is-differen.patch | 41 ++ ...t-validate_1.12.4.bb =>

[OE-core] [PATCH 07/12] gstreamer-vaapi: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
For changes, please see gstreamer-vaapi specific section at: https://gstreamer.freedesktop.org/releases/1.14/ Signed-off-by: Anuj Mittal --- meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.12.4.bb | 5 - .../{gstreamer1.0-vaapi.inc =>

[OE-core] [PATCH 09/12] gst-omx: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
For changes, please see: https://cgit.freedesktop.org/gstreamer/gst-omx/tree/ChangeLog Merge inc/bb since we only have one version now. Signed-off-by: Anuj Mittal --- meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.12.4.bb | 11 ---

[OE-core] [PATCH 06/12] gst-rtsp-server: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
* For changes, please see: https://gstreamer.freedesktop.org/releases/1.14/ * Merge inc/bb since there's only one version now. Signed-off-by: Anuj Mittal --- .../gstreamer/gstreamer1.0-rtsp-server_1.12.4.bb | 6 -- ...amer1.0-rtsp-server.inc =>

[OE-core] [PATCH 01/12] gstreamer1.0: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
* For changes, please see: https://gstreamer.freedesktop.org/releases/1.14/ * Merge inc and bb file since we only have one version now. Signed-off-by: Anuj Mittal --- meta/recipes-multimedia/gstreamer/gstreamer1.0_1.12.4.bb | 14 --

[OE-core] [PATCH 05/12] gst-plugins-ugly: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
* For changes, please see: https://gstreamer.freedesktop.org/releases/1.14/ * Remove PACKAGECONFIG for lame, mpg123 since those have moved to -good. * Merge inc/bb since there's only one version now. Signed-off-by: Anuj Mittal ---

[OE-core] [PATCH 03/12] gst-plugins-good: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
* For changes, please see: https://gstreamer.freedesktop.org/releases/1.14/ * With the expiration of mp3 patents [1], mp3 decoders and encoders have been moved to -plugins-good from -plugins-ugly (also see the release notes). * Move bz2 and zlib to PACKAGECONFIG. * gtk+ plugin has moved to -good

Re: [OE-core] [PATCH] matchbox-session-sato: Make the battery applet depend on machine features

2018-05-03 Thread Eran Matityahu
Hi. This is a duplicate of the original patch 142525 that I've submitted on July 30, 2017, only it has tabs replaced with spaces so it doesn't apply. The original patch applies cleanly. Please use it instead this one. Regards, Eran On Wed, May 2, 2018 at 8:33 PM, Jaewon Lee

[OE-core] [PATCH 11/12] gstreamer-libav: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
Drop one patch as the change is now present upstream. For changes, please see: https://gstreamer.freedesktop.org/releases/1.14/ Signed-off-by: Anuj Mittal --- .../0001-fix-host-contamination.patch | 36 ++

[OE-core] [PATCH 12/12] gst-plugins-good: enable mpg123 and lame

2018-05-03 Thread Anuj Mittal
Since the last remaining mp3 patents have expired [1] and corresponding commercial flags from recipes for these removed, enable these to be built by default. [1] https://www.iis.fraunhofer.de/en/ff/amm/prod/audiocodec/audiocodecs/mp3.html Signed-off-by: Anuj Mittal ---

[OE-core] [PATCH 10/12] gst-python: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Anuj Mittal
For changes, please see: https://cgit.freedesktop.org/gstreamer/gst-python/tree/ChangeLog Also merge inc/bb since we have only one version now. Signed-off-by: Anuj Mittal --- meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.12.4.bb| 7 ---

[OE-core] [PATCH 0/1] testsdk.bbclass: set PREMIRRORS for kernel to speed up test

2018-05-03 Thread Chen Qi
The following changes since commit b6bc5b2840246ac0f0e5d8cebcdffc1a0ca2518f: bitbake: toaster: add 'Sumo' to release selection (2018-04-26 11:43:26 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib ChenQi/testsdkext-speed

[OE-core] [PATCH 1/1] testsdk.bbclass: set PREMIRRORS for kernel to speed up test

2018-05-03 Thread Chen Qi
Currently if we do a testsdkext task for the image, it would take very long time to finish. The time is mostly spent fetching kernel source via network. We have done some configuration in auto.conf, trying to make use of own-mirrors.bbclass to avoid fetching kernel via network. However, the

[OE-core] [PATCH] flex: update to 2.6.4.

2018-05-03 Thread Hong Liu
From: Lei Maohui * Deleted 3 patches because these patches have been fixed in new version. * Added "--disable-bootstrap" to avoid the build error of stage1flex on host. stage1flex-misc.o: In function `allocate_array': misc.c:(.text+0x38f): undefined reference to

[OE-core] [PATCH] btrfs-tools: Update to 4.16

2018-05-03 Thread Hong Liu
From: Lei Maohui * 0001-Fix-build-with-musl-missing-header-include-for-dev_t.patch was deleted because it has been fixed in upstream. Signed-off-by: Lei Maohui Signed-off-by: Hong Liu ---

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Lukasz Majewski
Hi Marek, Stefano, > On 05/03/2018 06:50 PM, Stefano Babic wrote: > > On 03/05/2018 18:36, Marek Vasut wrote: > >> On 05/03/2018 06:28 PM, Stefano Babic wrote: > >>> On 27/04/2018 17:07, Marek Vasut wrote: > On 04/27/2018 04:51 PM, Lukasz Majewski wrote: > > This commit provides

[OE-core] [PATCH] core-image-*-initramfs: drop export of IMAGE_BASENAME

2018-05-03 Thread liu . ming50
From: Ming Liu I can not see there is any need for exporting them, simply drop the latency code. Signed-off-by: Ming Liu --- meta/recipes-core/images/core-image-minimal-initramfs.bb| 2 --

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Lukasz Majewski
On Thu, 3 May 2018 18:24:32 +0200 Stefano Babic wrote: > Hi Lukasz, > > On 27/04/2018 16:51, Lukasz Majewski wrote: > > This commit provides the ability to generate u-boot environment(s) > > as images, which afterwards can be used to produce image (with wic) > > for flashing

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Marek Vasut
On 05/03/2018 08:15 PM, Lukasz Majewski wrote: > Hi Marek, Stefano, > >> On 05/03/2018 06:50 PM, Stefano Babic wrote: >>> On 03/05/2018 18:36, Marek Vasut wrote: On 05/03/2018 06:28 PM, Stefano Babic wrote: > On 27/04/2018 17:07, Marek Vasut wrote: >> On 04/27/2018 04:51 PM,

Re: [OE-core] [PATCH 1/1] testsdk.bbclass: set PREMIRRORS for kernel to speed up test

2018-05-03 Thread Burton, Ross
On 3 May 2018 at 09:52, Chen Qi wrote: > +f.write('PREMIRRORS_prepend = " git://git.yoctoproject.org/.* > git://%s/git2/git.yoctoproject.org.BASENAME;protocal=file \\n "\n' % > test_data.get('DL_DIR')) > protocal? We could turn on BB_GENERATE_SOURCE_MIRRORS

Re: [OE-core] 2.6 planning proposals and meeting

2018-05-03 Thread Scott Rifenbark
Hi Peter, Thanks for the patch. I have applied it to the 2.5 version of the Yocto Project Reference Manual (see https://yoctoproject.org/docs/2.5/ref-manual/ref-manual.html#var-BUILDHISTORY_FEATURES). You can also see

[OE-core] [PATCH V3 01/28] libssp-nonshared: Add recipe

2018-05-03 Thread Khem Raj
libssp-nonshared is a minimal gcc runtime piece which is needed on non-glibc systems which do implement libssp APIs in libc Use PIE flags to compile libssp_nonshared.a so it works with security flags on as well Signed-off-by: Khem Raj --- Changes since v1: - Compile as PIC

[OE-core] [PATCH] recipes-support/ptest-runner: Upgrade to v2.2

2018-05-03 Thread Aníbal Limón
The new version contains an option to exclude certain tests to run, example: $ ptest-runner -e "perl" Signed-off-by: Aníbal Limón --- .../ptest-runner/{ptest-runner_2.1.1.bb => ptest-runner_2.2.bb} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Stefano Babic
Hi Marek, On 03/05/2018 18:59, Marek Vasut wrote: > On 05/03/2018 06:50 PM, Stefano Babic wrote: >> On 03/05/2018 18:36, Marek Vasut wrote: >>> On 05/03/2018 06:28 PM, Stefano Babic wrote: On 27/04/2018 17:07, Marek Vasut wrote: > On 04/27/2018 04:51 PM, Lukasz Majewski wrote: >>

[OE-core] (no subject)

2018-05-03 Thread taborskikrzysztof
Wysłano z telefonu Samsung-- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Stefano Babic
Hi Lukasz, On 27/04/2018 16:51, Lukasz Majewski wrote: > This commit provides the ability to generate u-boot environment(s) as > images, which afterwards can be used to produce image (with wic) for > flashing (eMMC or SPI-NOR). > > This change removes the need to run "env default" during

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Marek Vasut
On 05/03/2018 06:28 PM, Stefano Babic wrote: > On 27/04/2018 17:07, Marek Vasut wrote: >> On 04/27/2018 04:51 PM, Lukasz Majewski wrote: >>> This commit provides the ability to generate u-boot environment(s) as >>> images, which afterwards can be used to produce image (with wic) for >>> flashing

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Stefano Babic
On 03/05/2018 18:36, Marek Vasut wrote: > On 05/03/2018 06:28 PM, Stefano Babic wrote: >> On 27/04/2018 17:07, Marek Vasut wrote: >>> On 04/27/2018 04:51 PM, Lukasz Majewski wrote: This commit provides the ability to generate u-boot environment(s) as images, which afterwards can be used

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Stefano Babic
On 27/04/2018 17:07, Marek Vasut wrote: > On 04/27/2018 04:51 PM, Lukasz Majewski wrote: >> This commit provides the ability to generate u-boot environment(s) as >> images, which afterwards can be used to produce image (with wic) for >> flashing (eMMC or SPI-NOR). >> >> This change removes the

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Marek Vasut
On 05/03/2018 06:50 PM, Stefano Babic wrote: > On 03/05/2018 18:36, Marek Vasut wrote: >> On 05/03/2018 06:28 PM, Stefano Babic wrote: >>> On 27/04/2018 17:07, Marek Vasut wrote: On 04/27/2018 04:51 PM, Lukasz Majewski wrote: > This commit provides the ability to generate u-boot

Re: [OE-core] [PATCH 01/12] gstreamer1.0: upgrade 1.12.4 -> 1.14.0

2018-05-03 Thread Khem Raj
On Thu, May 3, 2018 at 1:18 AM Anuj Mittal wrote: > * For changes, please see: > https://gstreamer.freedesktop.org/releases/1.14/ > * Merge inc and bb file since we only have one version now. Threre is meta gstreamer can you check if this is not going to affect that

Re: [OE-core] [PATCH] u-boot: Add {gen|deploy}_default_envs tasks to generate environment images

2018-05-03 Thread Marek Vasut
On 05/03/2018 10:58 PM, Stefano Babic wrote: > Hi Marek, > > On 03/05/2018 18:59, Marek Vasut wrote: >> On 05/03/2018 06:50 PM, Stefano Babic wrote: >>> On 03/05/2018 18:36, Marek Vasut wrote: On 05/03/2018 06:28 PM, Stefano Babic wrote: > On 27/04/2018 17:07, Marek Vasut wrote: >>

Re: [OE-core] [pyro][PATCH] package.bbclass: Add '-b' option to file call in isELF

2018-05-03 Thread Andre McCurdy
On Mon, Apr 16, 2018 at 12:32 PM, Mark Hatle wrote: > The isELF function works by running: > >result = file >if 'ELF' in result > > By default 'file' will prepend the result with the path name of the file > that is being checked. This usually works fine, such

Re: [OE-core] python recipes with extensions fail to find/link with proper libraries

2018-05-03 Thread Alejandro Enedino Hernandez Samaniego
Hello Francesco, It would be helpful if you could provide more information about this, e.g. access to your layer or your recipes, to make sure they are actually being built correctly, also I would start by manually linking it against the built library to see if the error is just not having

Re: [OE-core] [poky] [PATCH v2] u-boot: enable dhcp for MPC8315 board

2018-05-03 Thread Trevor Woerner
On Wed, Jun 7, 2017 at 8:43 PM, Tom Rini wrote: > On Wed, Jun 07, 2017 at 01:32:28PM +0100, Richard Purdie wrote: > > On Wed, 2017-06-07 at 15:28 +0300, Ed Bartosh wrote: > > > Getting ip address from DHCP server is much more convenient > > > than setting static ip. It allows

Re: [OE-core] [poky] [PATCH v2] u-boot: enable dhcp for MPC8315 board

2018-05-03 Thread Tom Rini
On Thu, May 03, 2018 at 10:01:54PM -0400, Trevor Woerner wrote: > On Wed, Jun 7, 2017 at 8:43 PM, Tom Rini wrote: > > > On Wed, Jun 07, 2017 at 01:32:28PM +0100, Richard Purdie wrote: > > > On Wed, 2017-06-07 at 15:28 +0300, Ed Bartosh wrote: > > > > Getting ip address from

[OE-core] [PATCH] u-boot: remove upstreamed patch

2018-05-03 Thread Trevor Woerner
Signed-off-by: Trevor Woerner --- .../files/MPC8315ERDB-enable-DHCP.patch | 19 --- .../u-boot/u-boot-common_2018.01.inc | 4 +--- 2 files changed, 1 insertion(+), 22 deletions(-) delete mode 100644

[OE-core] [PATCH V2 0/1] testsdk.bbclass: set PREMIRRORS for kernel to speed up test

2018-05-03 Thread Chen Qi
Changes in V2: * Remove the 'protocol=file'. The following changes since commit b6bc5b2840246ac0f0e5d8cebcdffc1a0ca2518f: bitbake: toaster: add 'Sumo' to release selection (2018-04-26 11:43:26 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib

Re: [OE-core] [PATCH 1/1] testsdk.bbclass: set PREMIRRORS for kernel to speed up test

2018-05-03 Thread ChenQi
On 05/03/2018 10:38 PM, Burton, Ross wrote: On 3 May 2018 at 09:52, Chen Qi > wrote: + f.write('PREMIRRORS_prepend = " git://git.yoctoproject.org/.*

[OE-core] [PATCH V2 1/1] testsdk.bbclass: set PREMIRRORS for kernel to speed up test

2018-05-03 Thread Chen Qi
Currently if we do a testsdkext task for the image, it would take very long time to finish. The time is mostly spent fetching kernel source via network. We have done some configuration in auto.conf, trying to make use of own-mirrors.bbclass to avoid fetching kernel via network. However, the

[OE-core] [PATCH] mesa: Define PYTHON2

2018-05-03 Thread Khem Raj
Ensure that python2 is not assumed to be python which can point to python3 in some cases, when building gallium-llvm there are scripts which are requiring python2 and wont work with python3 Signed-off-by: Khem Raj --- meta/recipes-graphics/mesa/mesa.inc | 1 + 1 file

Re: [OE-core] [PATCH] mesa: Define PYTHON2

2018-05-03 Thread Burton, Ross
Do you know what scripts those are? It would be good to get them to have a python2 hashbang upstream, I've a sideline in quietly migrating upstreams to python3 so this is an important first step. Ross On 3 May 2018 at 11:03, Khem Raj wrote: > Ensure that python2 is not

Re: [OE-core] [PATCH 2/3] e2fsprogs: Complement update-alternatives scope

2018-05-03 Thread Burton, Ross
Breaks packaging: packages/corei7-64-poky-linux/e2fsprogs/e2fsprogs-mke2fs: FILELIST: removed "/sbin/mkfs.ext2 /sbin/mke2fs", added "/sbin/mkfs.ext2.e2fsprogs" packages/corei7-64-poky-linux/e2fsprogs/e2fsprogs-tune2fs: FILELIST: removed "/sbin/tune2fs"

Re: [OE-core] 2.6 planning proposals and meeting

2018-05-03 Thread Scott Rifenbark
Peter, Sorry I missed this. My fault for not monitoring that mail list close enough. I will take a look at this and get back to you. Regarding special processes for getting doc changes done. Any form of contact with me "should" work. What you did should have been caught. An email directly

[OE-core] ✗ patchtest: failure for flex: update to 2.6.4.

2018-05-03 Thread Patchwork
== Series Details == Series: flex: update to 2.6.4. Revision: 1 URL : https://patchwork.openembedded.org/series/11974/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the

Re: [OE-core] [PATCH] btrfs-tools: Update to 4.16

2018-05-03 Thread Alexander Kanavin
On 05/03/2018 12:09 PM, Hong Liu wrote: -DEPENDS = "util-linux attr e2fsprogs lzo acl" +DEPENDS = "util-linux attr e2fsprogs lzo acl python3" +EXTRA_OECONF = "--disable-zstd --disable-python" +INSANE_SKIP_${PN} = "ldflags" You need to explain all of these changes in the commit message.

Re: [OE-core] [PATCH] flex: update to 2.6.4.

2018-05-03 Thread Burton, Ross
By passing --disable-bootstrap for the native build you're assuming that the host has flex. If we could assume that we wouldn't be building a flex-native. Also I submitted this upgrade a few months ago but flex was aborting in the selftest, which is why it wasn't integrated. I'll integrate it