[OE-core] [PATCH V2] archiver: Configurable tarball compression

2021-09-20 Thread Ian Ray
In order to be more efficient, we use xz as compression method
to create GPL sources archives.

Signed-off-by: Fabien Lahoudere 
[V1 was https://patchwork.openembedded.org/patch/155985/]
[Rebased]
Signed-off-by: Ian Ray 
---
 meta/classes/archiver.bbclass | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
index dd31dc0..411d459 100644
--- a/meta/classes/archiver.bbclass
+++ b/meta/classes/archiver.bbclass
@@ -51,6 +51,7 @@ ARCHIVER_MODE[diff-exclude] ?= ".pc autom4te.cache patches"
 ARCHIVER_MODE[dumpdata] ?= "0"
 ARCHIVER_MODE[recipe] ?= "0"
 ARCHIVER_MODE[mirror] ?= "split"
+ARCHIVER_MODE[compression] ?= "gz"
 
 DEPLOY_DIR_SRC ?= "${DEPLOY_DIR}/sources"
 ARCHIVER_TOPDIR ?= "${WORKDIR}/archiver-sources"
@@ -409,15 +410,16 @@ def create_tarball(d, srcdir, suffix, ar_outdir):
 # that we archive the actual directory and not just the link.
 srcdir = os.path.realpath(srcdir)
 
+compression_method = d.getVarFlag('ARCHIVER_MODE', 'compression')
 bb.utils.mkdirhier(ar_outdir)
 if suffix:
-filename = '%s-%s.tar.gz' % (d.getVar('PF'), suffix)
+filename = '%s-%s.tar.%s' % (d.getVar('PF'), suffix, 
compression_method)
 else:
-filename = '%s.tar.gz' % d.getVar('PF')
+filename = '%s.tar.%s' % (d.getVar('PF'), compression_method)
 tarname = os.path.join(ar_outdir, filename)
 
 bb.note('Creating %s' % tarname)
-tar = tarfile.open(tarname, 'w:gz')
+tar = tarfile.open(tarname, 'w:%s' % compression_method)
 tar.add(srcdir, arcname=os.path.basename(srcdir), 
filter=exclude_useless_paths)
 tar.close()
 
-- 
2.10.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156201): 
https://lists.openembedded.org/g/openembedded-core/message/156201
Mute This Topic: https://lists.openembedded.org/mt/85760412/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 14/14] layer.conf: Extend recipes not to install without explict dependencies

2021-09-20 Thread Khem Raj
On Mon, Sep 20, 2021 at 6:34 AM Joshua Watt  wrote:
>
>
> On 9/20/21 7:48 AM, Richard Purdie wrote:
>
> On Mon, 2021-09-20 at 13:46 +0100, Richard Purdie via lists.openembedded.org
> wrote:
>
> There are several dependencies which recipes have which are not needed
> at runtime, only at build time. Extend the list of these from bison to
> include quilt, patch, meson, autoconf, automake and ninja which should
> reduce the amount of data being included in native sysroots.
>
> This speeds up and reduces the sstate needed for image builds for example.
>
> If this change breaks recipes, it probably means they're missing an explicit
> DEPENDS on something in this list which is a bug in the recipe.
>
> Signed-off-by: Richard Purdie 
> ---
>  meta/conf/layer.conf | 12 +++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
> index 307ad7e2237..b3cc8a249e9 100644
> --- a/meta/conf/layer.conf
> +++ b/meta/conf/layer.conf
> @@ -48,6 +48,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \
>  "
>
>  SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
> +  *->patch-native \
>*->quilt-native \
>*->subversion-native \
>*->git-native \
> @@ -90,7 +91,16 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
>  # (e.g. X -> Y -> binutils-cross -> bison-native) no longer meet the
>  # dependency incidentally. This improves determinism and avoids build
>  # failures when people switch to external toolchains.
> -SSTATE_EXCLUDEDEPS_SYSROOT += ".*->bison-native"
> +SSTATE_EXCLUDEDEPS_SYSROOT += "\
> +.*->autoconf-native \
> +.*->automake-native \
> +.*->bison-native \
> +.*->meson-native \
> +.*->ninja-native \
> +.*->patch-native \
> +.*->pkgconfig-native \
> +.*->quilt-native \
> +"
>
> I've marked this one as an RFC since it caused a fair bit of pain even in OE-
> core due to recipes having pkgconfig class inherits missing.
>
> We do really want to do this and correctly mark up the recipe dependencies, 
> the
> question is whether it is too late for 3.4 or not. We could go for a smaller
> list for now too but I wanted to hear opinions.
>
>
> It looks like a great change! I'd say it's too late for 3.4 and we should do 
> it for 3.5 instead.
>

right see the failed recipes which would need fixing
https://errors.yoctoproject.org/Errors/Build/130779/

> Cheers,
>
> Richard
>
>
>
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156200): 
https://lists.openembedded.org/g/openembedded-core/message/156200
Mute This Topic: https://lists.openembedded.org/mt/85739636/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] Yocto Project Newcomer & Unassigned Bugs - Help Needed

2021-09-20 Thread Stephen Jolley
All,

 

The triage team is starting to try and collect up and classify bugs which a
newcomer to the project would be able to work on in a way which means people
can find them. They're being listed on the triage page under the appropriate
heading:

https://wiki.yoctoproject.org/wiki/Bug_Triage#Newcomer_Bugs  Also please
review:
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded and
how to create a bugzilla account at:

https://bugzilla.yoctoproject.org/createaccount.cgi

The idea is these bugs should be straight forward for a person to help work
on who doesn't have deep experience with the project.  If anyone can help,
please take ownership of the bug and send patches!  If anyone needs
help/advice there are people on irc who can likely do so, or some of the
more experienced contributors will likely be happy to help too.

 

Also, the triage team meets weekly and does its best to handle the bugs
reported into the Bugzilla. The number of people attending that meeting has
fallen, as have the number of people available to help fix bugs. One of the
things we hear users report is they don't know how to help. We (the triage
team) are therefore going to start reporting out the currently 389
unassigned or newcomer bugs.

 

We're hoping people may be able to spare some time now and again to help out
with these.  Bugs are split into two types, "true bugs" where things don't
work as they should and "enhancements" which are features we'd want to add
to the system.  There are also roughly four different "priority" classes
right now, "3.4", "3.5, "3.99" and "Future", the more pressing/urgent issues
being in "3.4" and then "3.5".

 

Please review this link and if a bug is something you would be able to help
with either take ownership of the bug, or send me (sjolley.yp...@gmail.com
 ) an e-mail with the bug number you would
like and I will assign it to you (please make sure you have a Bugzilla
account).  The list is at:
https://wiki.yoctoproject.org/wiki/Bug_Triage_Archive#Unassigned_or_Newcomer
_Bugs

 

Thanks,

 

Stephen K. Jolley

Yocto Project Program Manager

*Cell:(208) 244-4460

* Email:  sjolley.yp...@gmail.com
 

 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156199): 
https://lists.openembedded.org/g/openembedded-core/message/156199
Mute This Topic: https://lists.openembedded.org/mt/85753402/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] pybootchart: Avoid divide by zero

2021-09-20 Thread Richard Purdie
Avoid a rare divide by zero error if there isn't data point spread.

[YOCTO #14547]

Signed-off-by: Richard Purdie 
---
 scripts/pybootchartgui/pybootchartgui/draw.py | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/pybootchartgui/pybootchartgui/draw.py 
b/scripts/pybootchartgui/pybootchartgui/draw.py
index 29eb7505bc2..6bac8015584 100644
--- a/scripts/pybootchartgui/pybootchartgui/draw.py
+++ b/scripts/pybootchartgui/pybootchartgui/draw.py
@@ -267,7 +267,10 @@ def draw_chart(ctx, color, fill, chart_bounds, data, 
proc_tree, data_range):
 # avoid divide by zero
 if max_y == 0:
 max_y = 1.0
-xscale = float (chart_bounds[2]) / (max_x - x_shift)
+if (max_x - x_shift):
+xscale = float (chart_bounds[2]) / (max_x - x_shift)
+else:
+xscale = float (chart_bounds[2]) 
 # If data_range is given, scale the chart so that the value range in
 # data_range matches the chart bounds exactly.
 # Otherwise, scale so that the actual data matches the chart bounds.
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156198): 
https://lists.openembedded.org/g/openembedded-core/message/156198
Mute This Topic: https://lists.openembedded.org/mt/85751789/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 11/14] populate_sdk_base/images: Drop use of 'meta' class and hence do_build dependencies

2021-09-20 Thread Richard Purdie
On Mon, 2021-09-20 at 09:32 -0700, Khem Raj wrote:
> 
> On 9/20/21 5:51 AM, Richard Purdie wrote:
> > On Mon, 2021-09-20 at 13:46 +0100, Richard Purdie via lists.openembedded.org
> > wrote:
> > > The 'meta' is old and not very useful. It empties PACKAGES and creates
> > > recursive do_build dependencies.
> > > 
> > > We shouldn't need such recursive build dependencies any more so simplify 
> > > the code.
> > > 
> > > This does cause behaviour changes as some dependencies are no longer 
> > > built.
> > > It did show up issues with qemu-helper-native handling for example but 
> > > those
> > > issues look like real races and the underlying dependency chains were not 
> > > correct.
> > > 
> > > Signed-off-by: Richard Purdie 
> > > ---
> > >   meta/classes/populate_sdk_base.bbclass | 4 +++-
> > >   1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/classes/populate_sdk_base.bbclass 
> > > b/meta/classes/populate_sdk_base.bbclass
> > > index ccfe2232895..49e166e697d 100644
> > > --- a/meta/classes/populate_sdk_base.bbclass
> > > +++ b/meta/classes/populate_sdk_base.bbclass
> > > @@ -1,4 +1,6 @@
> > > -inherit meta image-postinst-intercepts image-artifact-names
> > > +PACKAGES = ""
> > > +
> > > +inherit image-postinst-intercepts image-artifact-names
> > >   
> > >   # Wildcards specifying complementary packages to install for every 
> > > package that has been explicitly
> > >   # installed into the rootfs
> > 
> > This change is probably high impact in that it changes behaviour the most 
> > of any
> > of the changes. It does make image builds use a lot less sstate and in 
> > theory,
> > if there are issues with failures from this, there are probably existing 
> > races.
> > 
> > It does also have CI impact as it changes the things which are built as not 
> > all
> > build tasks now run. Open to opinions on whether we should do this now or 
> > not.
> > 
>
> I definitely like this change and want it in upcoming LTS in 2022, not 
> comfortable with rushing it into this release. It will cause fair bit of 
> work for rest of layers in ecosystem.

The question is whether this is a real world issue for anyone with CI out there.
I've been looking at the YP autobuilder and I'm not sure it is. Yes, it does
change things but not really in a way I'm too worried about.

There is some breakage in this series but it is mainly from the layer.conf
change.

So the question is whether anyone does see real issues in their CI from this?

There is an easy change if it does cause an issue which I've now documented in
the commit log as I replied to Joshua.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156197): 
https://lists.openembedded.org/g/openembedded-core/message/156197
Mute This Topic: https://lists.openembedded.org/mt/85739675/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] documentation: update sources mirror URL

2021-09-20 Thread Jon Mason
The URL for the sources mirror no longer works.  Update to the new
location.

Signed-off-by: Jon Mason 
---
 .../bitbake-user-manual-ref-variables.rst |  8 
 documentation/ref-manual/faq.rst  | 15 ---
 documentation/ref-manual/variables.rst|  8 
 3 files changed, 16 insertions(+), 15 deletions(-)

diff --git 
a/bitbake/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst 
b/bitbake/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst
index 8862e16b83cb..11f8fdcde003 100644
--- a/bitbake/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst
+++ b/bitbake/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst
@@ -1123,10 +1123,10 @@ overview of their function and contents.
   your configuration::
 
  PREMIRRORS:prepend = "\
- git://.*/.* http://www.yoctoproject.org/sources/ \n \
- ftp://.*/.* http://www.yoctoproject.org/sources/ \n \
- http://.*/.* http://www.yoctoproject.org/sources/ \n \
- https://.*/.* http://www.yoctoproject.org/sources/ \n"
+ git://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+ ftp://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+ http://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+ https://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n"
 
   These changes cause the build system to intercept Git, FTP, HTTP, and
   HTTPS requests and direct them to the ``http://`` sources mirror. You can
diff --git a/documentation/ref-manual/faq.rst b/documentation/ref-manual/faq.rst
index d3a603d4a438..f06abc84ee6f 100644
--- a/documentation/ref-manual/faq.rst
+++ b/documentation/ref-manual/faq.rst
@@ -302,10 +302,10 @@ attempt before any others by adding something like the 
following to the
 ``local.conf`` configuration file::
 
PREMIRRORS:prepend = "\
-   git://.*/.* http://www.yoctoproject.org/sources/ \n \
-   ftp://.*/.* http://www.yoctoproject.org/sources/ \n \
-   http://.*/.* http://www.yoctoproject.org/sources/ \n \
-   https://.*/.* http://www.yoctoproject.org/sources/ \n"
+   git://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+   ftp://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+   http://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+   https://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n"
 
 These changes cause the build system to intercept Git, FTP, HTTP, and
 HTTPS requests and direct them to the ``http://`` sources mirror. You
@@ -342,9 +342,10 @@ You could make the following changes to the ``local.conf`` 
configuration
 file as long as the :term:`PREMIRRORS` server is current::
 
PREMIRRORS:prepend = "\
-   ftp://.*/.* http://www.yoctoproject.org/sources/ \n \
-   http://.*/.* http://www.yoctoproject.org/sources/ \n \
-   https://.*/.* http://www.yoctoproject.org/sources/ \n"
+   git://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+   ftp://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+   http://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+   https://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n"
BB_FETCH_PREMIRRORONLY = "1"
 
 These changes would cause the build system to successfully fetch source
diff --git a/documentation/ref-manual/variables.rst 
b/documentation/ref-manual/variables.rst
index dbe02ab27a08..57bf90e5172b 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -5821,10 +5821,10 @@ system and gives an overview of their function and 
contents.
   :term:`Build Directory`::
 
  PREMIRRORS:prepend = "\
- git://.*/.* http://www.yoctoproject.org/sources/ \n \
- ftp://.*/.* http://www.yoctoproject.org/sources/ \n \
- http://.*/.* http://www.yoctoproject.org/sources/ \n \
- https://.*/.* http://www.yoctoproject.org/sources/ \n"
+ git://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+ ftp://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n \
+ http://.*/.* http://downloads.yoctoproject.org/mirror/sources/ \n 
\
+ https://.*/.* http://downloads.yoctoproject.org/mirror/sources/ 
\n"
 
   These changes cause the
   build system to intercept Git, FTP, HTTP, and HTTPS requests and
-- 
2.20.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156196): 
https://lists.openembedded.org/g/openembedded-core/message/156196
Mute This Topic: https://lists.openembedded.org/mt/85750642/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] avahi: remove obsolete intltool-native dependency

2021-09-20 Thread Ross Burton
intltool was replaced with gettext in the 0.8 release.

Signed-off-by: Ross Burton 
---
 meta/recipes-connectivity/avahi/avahi_0.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-connectivity/avahi/avahi_0.8.bb 
b/meta/recipes-connectivity/avahi/avahi_0.8.bb
index cd0489e846..4b15d11b61 100644
--- a/meta/recipes-connectivity/avahi/avahi_0.8.bb
+++ b/meta/recipes-connectivity/avahi/avahi_0.8.bb
@@ -35,7 +35,7 @@ SRC_URI[sha256sum] = 
"060309d7a333d38d951bc27598c677af1796934dbd98e1024e7ad8de79
 # Issue only affects Debian/SUSE, not us
 CVE_CHECK_WHITELIST += "CVE-2021-26720"
 
-DEPENDS = "expat libcap libdaemon glib-2.0 intltool-native"
+DEPENDS = "expat libcap libdaemon glib-2.0"
 
 # For gtk related PACKAGECONFIGs: gtk, gtk3
 AVAHI_GTK ?= ""
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156195): 
https://lists.openembedded.org/g/openembedded-core/message/156195
Mute This Topic: https://lists.openembedded.org/mt/85746053/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 11/14] populate_sdk_base/images: Drop use of 'meta' class and hence do_build dependencies

2021-09-20 Thread Khem Raj



On 9/20/21 5:51 AM, Richard Purdie wrote:

On Mon, 2021-09-20 at 13:46 +0100, Richard Purdie via lists.openembedded.org
wrote:

The 'meta' is old and not very useful. It empties PACKAGES and creates
recursive do_build dependencies.

We shouldn't need such recursive build dependencies any more so simplify the 
code.

This does cause behaviour changes as some dependencies are no longer built.
It did show up issues with qemu-helper-native handling for example but those
issues look like real races and the underlying dependency chains were not 
correct.

Signed-off-by: Richard Purdie 
---
  meta/classes/populate_sdk_base.bbclass | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/classes/populate_sdk_base.bbclass 
b/meta/classes/populate_sdk_base.bbclass
index ccfe2232895..49e166e697d 100644
--- a/meta/classes/populate_sdk_base.bbclass
+++ b/meta/classes/populate_sdk_base.bbclass
@@ -1,4 +1,6 @@
-inherit meta image-postinst-intercepts image-artifact-names
+PACKAGES = ""
+
+inherit image-postinst-intercepts image-artifact-names
  
  # Wildcards specifying complementary packages to install for every package that has been explicitly

  # installed into the rootfs


This change is probably high impact in that it changes behaviour the most of any
of the changes. It does make image builds use a lot less sstate and in theory,
if there are issues with failures from this, there are probably existing races.

It does also have CI impact as it changes the things which are built as not all
build tasks now run. Open to opinions on whether we should do this now or not.




I definitely like this change and want it in upcoming LTS in 2022, not 
comfortable with rushing it into this release. It will cause fair bit of 
work for rest of layers in ecosystem.




The meta class is pretty useless and should be removed regardless.



yes


Cheers,

Richard






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156194): 
https://lists.openembedded.org/g/openembedded-core/message/156194
Mute This Topic: https://lists.openembedded.org/mt/85739675/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] machine/qemuarm*: use virtio graphics

2021-09-20 Thread Jon Mason
On Fri, Sep 17, 2021 at 9:54 AM Alexander Kanavin
 wrote:
>
> Have you investigated (optionally) enabling virgl as well on ARM hosts? On 
> x86, currently -vga virtio is used
> and will be switched to -device virtio-vga-gl with qemu 6.1, according to
> https://www.kraxel.org/blog/2021/05/virtio-gpu-qemu-graphics-update/

My local Arm system does not have a graphics adapter in it.

Let me know when you make the change and I'll get my setup working and
see if it can't be enabled.

Thanks,
Jon

>
> On ARM... I don't know, as I do not have an ARM host with a GPU.
>
> Alex
>
> On Fri, 17 Sept 2021 at 00:20, Jon Mason  wrote:
>>
>> Switch to using virtio graphics for the Arm QEMU machines.  You will
>> noticed the difference in the dmesg by seeing:
>> [2.693337] [drm] pci: virtio-gpu-pci detected at :00:10.0
>>
>> Signed-off-by: Jon Mason 
>> ---
>>  meta/conf/machine/qemuarm.conf   | 2 +-
>>  meta/conf/machine/qemuarm64.conf | 2 +-
>>  meta/conf/machine/qemuarmv5.conf | 3 ++-
>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/conf/machine/qemuarm.conf b/meta/conf/machine/qemuarm.conf
>> index 93d855b6e1e2..d71a793edf05 100644
>> --- a/meta/conf/machine/qemuarm.conf
>> +++ b/meta/conf/machine/qemuarm.conf
>> @@ -20,7 +20,7 @@ QB_SMP = "-smp 4"
>>  # Standard Serial console
>>  QB_KERNEL_CMDLINE_APPEND = "vmalloc=256"
>>  # For graphics to work we need to define the VGA device as well as the 
>> necessary USB devices
>> -QB_GRAPHICS = "-device VGA,edid=on"
>> +QB_GRAPHICS = "-device virtio-gpu-pci"
>>  QB_OPT_APPEND = "-device qemu-xhci -device usb-tablet -device usb-kbd"
>>  # Virtio Networking support
>>  QB_TAP_OPT = "-netdev tap,id=net0,ifname=@TAP@,script=no,downscript=no"
>> diff --git a/meta/conf/machine/qemuarm64.conf 
>> b/meta/conf/machine/qemuarm64.conf
>> index ea7fae2722a0..3b08dedddc86 100644
>> --- a/meta/conf/machine/qemuarm64.conf
>> +++ b/meta/conf/machine/qemuarm64.conf
>> @@ -19,7 +19,7 @@ QB_CPU = "-cpu cortex-a57"
>>  QB_SMP = "-smp 4"
>>  QB_CPU_KVM = "-cpu host -machine gic-version=3"
>>  # For graphics to work we need to define the VGA device as well as the 
>> necessary USB devices
>> -QB_GRAPHICS = "-device VGA,edid=on"
>> +QB_GRAPHICS = "-device virtio-gpu-pci"
>>  QB_OPT_APPEND = "-device qemu-xhci -device usb-tablet -device usb-kbd"
>>  # Virtio Networking support
>>  QB_TAP_OPT = "-netdev tap,id=net0,ifname=@TAP@,script=no,downscript=no"
>> diff --git a/meta/conf/machine/qemuarmv5.conf 
>> b/meta/conf/machine/qemuarmv5.conf
>> index 6c99a5296589..252d6286d8ec 100644
>> --- a/meta/conf/machine/qemuarmv5.conf
>> +++ b/meta/conf/machine/qemuarmv5.conf
>> @@ -13,7 +13,8 @@ SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;ttyAMA1"
>>  QB_SYSTEM_NAME = "qemu-system-arm"
>>  QB_MACHINE = "-machine versatilepb"
>>  QB_KERNEL_CMDLINE_APPEND = "vmalloc=256"
>> -QB_OPT_APPEND = "-usb -device usb-tablet"
>> +QB_GRAPHICS = "-device virtio-gpu-pci"
>> +QB_OPT_APPEND = "-device qemu-xhci -device usb-tablet -device usb-kbd"
>>  PREFERRED_VERSION_linux-yocto ??= "5.13%"
>>  QB_DTB = 
>> "${@oe.utils.version_less_or_equal('PREFERRED_VERSION_linux-yocto', '4.7', 
>> '', 'zImage-versatile-pb.dtb', d)}"
>>
>> --
>> 2.20.1
>>
>>
>> 
>>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156193): 
https://lists.openembedded.org/g/openembedded-core/message/156193
Mute This Topic: https://lists.openembedded.org/mt/85663566/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [dunfell][PATCH] poky: fixes backwards compatible for the SDKPATHINSTALL

2021-09-20 Thread Jose Quaresma
Richard Purdie  escreveu no dia
segunda, 20/09/2021 à(s) 11:57:
>
> On Mon, 2021-09-20 at 11:07 +0100, Jose Quaresma wrote:
> > Previously the SDKPATH can be used to custumize the path
> > of the SDK installation. Drop the SDKPATH and use SDKPATHINSTALL
> > without that brokes backwards compatible for any distro with
> > SDKPATH customized.
> >
> > Signed-off-by: Jose Quaresma 
> > ---
> >  meta-poky/conf/distro/poky.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-poky/conf/distro/poky.conf 
> > b/meta-poky/conf/distro/poky.conf
> > index 5b54df874e..7dad7012ba 100644
> > --- a/meta-poky/conf/distro/poky.conf
> > +++ b/meta-poky/conf/distro/poky.conf
> > @@ -24,7 +24,7 @@ DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT} 
> > ${POKY_DEFAULT_DISTRO_FEATURES}"
> >  PREFERRED_VERSION_linux-yocto ?= "5.4%"
> >
> >  SDK_NAME = 
> > "${DISTRO}-${TCLIBC}-${SDKMACHINE}-${IMAGE_BASENAME}-${TUNE_PKGARCH}-${MACHINE}"
> > -SDKPATHINSTALL = "/opt/${DISTRO}/${SDK_VERSION}"
> > +SDKPATHINSTALL = "${SDKPATH}"
> >
> >  DISTRO_EXTRA_RDEPENDS += " ${POKY_DEFAULT_EXTRA_RDEPENDS}"
> >  DISTRO_EXTRA_RRECOMMENDS += " ${POKY_DEFAULT_EXTRA_RRECOMMENDS}"
>
> Distros need to switch to use SDKPATHINSTALL.
>
> This change breaks the poky default value instead of any distro that has
> customised and disables the SDK hard coded path fix which was the original 
> point
> of the change.
>
> Cheers,
>
> Richard
>
>
>
>

I understand that fixing this on a customized distro is easy and we
only need to overwrite SDKPATHINSTALL if needed.

So,  to take advantage of the:
 sdk: Decouple default install path from built in path
 
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=dunfell&id=6fef2a1c2ca8a4450c8a4b49e6eb5e01f80ef97b

The dunfell users need to avoid the usage versions strings in SDKPATH
because they change over time and
customize the SDKPATHINSTALL as well, having version strings in the
last is not a problem.

All distros need to do what poky distro does at:
 poky: Use SDKPATHINSTALL instead of SDKPATH
 
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=dunfell&id=67dbe8a1c2b485d0cec174d28107b0ac8ea77d5f

You can drop this patch.

-- 
Best regards,

José Quaresma

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156192): 
https://lists.openembedded.org/g/openembedded-core/message/156192
Mute This Topic: https://lists.openembedded.org/mt/85736853/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] testimage: remove aarch64 xorg exclusion

2021-09-20 Thread Jon Mason
aarch64/qemuarm64 has had graphics support for some time.  Remove this
exclusion and allow graphics tests to be against qemuarm64.

Signed-off-by: Jon Mason 
---
 meta/classes/testimage.bbclass | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
index 3c689aec9139..82dceedf067f 100644
--- a/meta/classes/testimage.bbclass
+++ b/meta/classes/testimage.bbclass
@@ -64,8 +64,6 @@ BASICTESTSUITE = "\
 
 DEFAULT_TEST_SUITES = "${BASICTESTSUITE}"
 
-# aarch64 has no graphics
-DEFAULT_TEST_SUITES:remove:aarch64 = "xorg"
 # musl doesn't support systemtap
 DEFAULT_TEST_SUITES:remove:libc-musl = "stap"
 
-- 
2.20.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156191): 
https://lists.openembedded.org/g/openembedded-core/message/156191
Mute This Topic: https://lists.openembedded.org/mt/85742376/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

2021-09-20 Thread Richard Purdie
On Mon, 2021-09-20 at 08:27 -0500, Joshua Watt wrote:
> On Sun, Sep 19, 2021 at 5:57 AM Richard Purdie
>  wrote:
> > 
> > This is a controversial change which removes the recursive dependencies
> > from the do_build target of packaging tasks of recipes.
> > 
> > Currently this means when you "bitbake " or "bitbake ",
> > the packaging tasks run for all packaging backends enabled for all recipes
> > in the dependency chain. The same therefore then applies to images.
> > 
> > We don't actually need that, it is a convinience thing. Removing it
> > massively simplifies the task graph and causes much fewer tasks to execute
> > in many common scenarios. It also means less sstate is fetched for
> > example when building an image.
> 
> Faster builds in the common cases seems like a great idea!
> 
> If someone really needs the old behavior, is there a mechanism to do
> the equivalent to what it was doing?

In this context, "bitbake XXX --runall build" would be equivalent to the current
"bitbake XXX".

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156190): 
https://lists.openembedded.org/g/openembedded-core/message/156190
Mute This Topic: https://lists.openembedded.org/mt/85715723/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 14/14] layer.conf: Extend recipes not to install without explict dependencies

2021-09-20 Thread Joshua Watt


On 9/20/21 7:48 AM, Richard Purdie wrote:

On Mon, 2021-09-20 at 13:46 +0100, Richard Purdie via lists.openembedded.org
wrote:

There are several dependencies which recipes have which are not needed
at runtime, only at build time. Extend the list of these from bison to
include quilt, patch, meson, autoconf, automake and ninja which should
reduce the amount of data being included in native sysroots.

This speeds up and reduces the sstate needed for image builds for example.

If this change breaks recipes, it probably means they're missing an explicit
DEPENDS on something in this list which is a bug in the recipe.

Signed-off-by: Richard Purdie 
---
  meta/conf/layer.conf | 12 +++-
  1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
index 307ad7e2237..b3cc8a249e9 100644
--- a/meta/conf/layer.conf
+++ b/meta/conf/layer.conf
@@ -48,6 +48,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \
  "
  
  SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \

+  *->patch-native \
*->quilt-native \
*->subversion-native \
*->git-native \
@@ -90,7 +91,16 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
  # (e.g. X -> Y -> binutils-cross -> bison-native) no longer meet the
  # dependency incidentally. This improves determinism and avoids build
  # failures when people switch to external toolchains.
-SSTATE_EXCLUDEDEPS_SYSROOT += ".*->bison-native"
+SSTATE_EXCLUDEDEPS_SYSROOT += "\
+.*->autoconf-native \
+.*->automake-native \
+.*->bison-native \
+.*->meson-native \
+.*->ninja-native \
+.*->patch-native \
+.*->pkgconfig-native \
+.*->quilt-native \
+"

I've marked this one as an RFC since it caused a fair bit of pain even in OE-
core due to recipes having pkgconfig class inherits missing.

We do really want to do this and correctly mark up the recipe dependencies, the
question is whether it is too late for 3.4 or not. We could go for a smaller
list for now too but I wanted to hear opinions.



It looks like a great change! I'd say it's too late for 3.4 and we 
should do it for 3.5 instead.




Cheers,

Richard





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156189): 
https://lists.openembedded.org/g/openembedded-core/message/156189
Mute This Topic: https://lists.openembedded.org/mt/85739636/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

2021-09-20 Thread Joshua Watt
On Sun, Sep 19, 2021 at 5:57 AM Richard Purdie
 wrote:
>
> This is a controversial change which removes the recursive dependencies
> from the do_build target of packaging tasks of recipes.
>
> Currently this means when you "bitbake " or "bitbake ",
> the packaging tasks run for all packaging backends enabled for all recipes
> in the dependency chain. The same therefore then applies to images.
>
> We don't actually need that, it is a convinience thing. Removing it
> massively simplifies the task graph and causes much fewer tasks to execute
> in many common scenarios. It also means less sstate is fetched for
> example when building an image.

Faster builds in the common cases seems like a great idea!

If someone really needs the old behavior, is there a mechanism to do
the equivalent to what it was doing?

>
> Signed-off-by: Richard Purdie 
> ---
>  meta/classes/package_deb.bbclass | 2 --
>  meta/classes/package_ipk.bbclass | 2 --
>  meta/classes/package_rpm.bbclass | 2 --
>  3 files changed, 6 deletions(-)
>
> diff --git a/meta/classes/package_deb.bbclass 
> b/meta/classes/package_deb.bbclass
> index eca43e17876..8f0eadbcd2e 100644
> --- a/meta/classes/package_deb.bbclass
> +++ b/meta/classes/package_deb.bbclass
> @@ -320,5 +320,3 @@ addtask package_write_deb after do_packagedata do_package
>
>  PACKAGEINDEXDEPS += "dpkg-native:do_populate_sysroot"
>  PACKAGEINDEXDEPS += "apt-native:do_populate_sysroot"
> -
> -do_build[recrdeptask] += "do_package_write_deb"
> diff --git a/meta/classes/package_ipk.bbclass 
> b/meta/classes/package_ipk.bbclass
> index c3b53854e8b..756744279e1 100644
> --- a/meta/classes/package_ipk.bbclass
> +++ b/meta/classes/package_ipk.bbclass
> @@ -278,5 +278,3 @@ addtask package_write_ipk after do_packagedata do_package
>
>  PACKAGEINDEXDEPS += "opkg-utils-native:do_populate_sysroot"
>  PACKAGEINDEXDEPS += "opkg-native:do_populate_sysroot"
> -
> -do_build[recrdeptask] += "do_package_write_ipk"
> diff --git a/meta/classes/package_rpm.bbclass 
> b/meta/classes/package_rpm.bbclass
> index 88d861c0e75..9f415b234de 100644
> --- a/meta/classes/package_rpm.bbclass
> +++ b/meta/classes/package_rpm.bbclass
> @@ -752,5 +752,3 @@ addtask package_write_rpm after do_packagedata do_package
>
>  PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
>  PACKAGEINDEXDEPS += "createrepo-c-native:do_populate_sysroot"
> -
> -do_build[recrdeptask] += "do_package_write_rpm"
> --
> 2.32.0
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156188): 
https://lists.openembedded.org/g/openembedded-core/message/156188
Mute This Topic: https://lists.openembedded.org/mt/85715723/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 11/14] populate_sdk_base/images: Drop use of 'meta' class and hence do_build dependencies

2021-09-20 Thread Richard Purdie
On Mon, 2021-09-20 at 13:46 +0100, Richard Purdie via lists.openembedded.org
wrote:
> The 'meta' is old and not very useful. It empties PACKAGES and creates
> recursive do_build dependencies.
> 
> We shouldn't need such recursive build dependencies any more so simplify the 
> code.
> 
> This does cause behaviour changes as some dependencies are no longer built.
> It did show up issues with qemu-helper-native handling for example but those
> issues look like real races and the underlying dependency chains were not 
> correct.
> 
> Signed-off-by: Richard Purdie 
> ---
>  meta/classes/populate_sdk_base.bbclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/populate_sdk_base.bbclass 
> b/meta/classes/populate_sdk_base.bbclass
> index ccfe2232895..49e166e697d 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -1,4 +1,6 @@
> -inherit meta image-postinst-intercepts image-artifact-names
> +PACKAGES = ""
> +
> +inherit image-postinst-intercepts image-artifact-names
>  
>  # Wildcards specifying complementary packages to install for every package 
> that has been explicitly
>  # installed into the rootfs

This change is probably high impact in that it changes behaviour the most of any
of the changes. It does make image builds use a lot less sstate and in theory,
if there are issues with failures from this, there are probably existing races.

It does also have CI impact as it changes the things which are built as not all
build tasks now run. Open to opinions on whether we should do this now or not.

The meta class is pretty useless and should be removed regardless.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156187): 
https://lists.openembedded.org/g/openembedded-core/message/156187
Mute This Topic: https://lists.openembedded.org/mt/85739675/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 14/14] layer.conf: Extend recipes not to install without explict dependencies

2021-09-20 Thread Richard Purdie
On Mon, 2021-09-20 at 13:46 +0100, Richard Purdie via lists.openembedded.org
wrote:
> There are several dependencies which recipes have which are not needed
> at runtime, only at build time. Extend the list of these from bison to
> include quilt, patch, meson, autoconf, automake and ninja which should
> reduce the amount of data being included in native sysroots.
> 
> This speeds up and reduces the sstate needed for image builds for example.
> 
> If this change breaks recipes, it probably means they're missing an explicit
> DEPENDS on something in this list which is a bug in the recipe.
> 
> Signed-off-by: Richard Purdie 
> ---
>  meta/conf/layer.conf | 12 +++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
> index 307ad7e2237..b3cc8a249e9 100644
> --- a/meta/conf/layer.conf
> +++ b/meta/conf/layer.conf
> @@ -48,6 +48,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \
>  "
>  
>  SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
> +  *->patch-native \
>*->quilt-native \
>*->subversion-native \
>*->git-native \
> @@ -90,7 +91,16 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
>  # (e.g. X -> Y -> binutils-cross -> bison-native) no longer meet the
>  # dependency incidentally. This improves determinism and avoids build
>  # failures when people switch to external toolchains.
> -SSTATE_EXCLUDEDEPS_SYSROOT += ".*->bison-native"
> +SSTATE_EXCLUDEDEPS_SYSROOT += "\
> +.*->autoconf-native \
> +.*->automake-native \
> +.*->bison-native \
> +.*->meson-native \
> +.*->ninja-native \
> +.*->patch-native \
> +.*->pkgconfig-native \
> +.*->quilt-native \
> +"

I've marked this one as an RFC since it caused a fair bit of pain even in OE-
core due to recipes having pkgconfig class inherits missing.

We do really want to do this and correctly mark up the recipe dependencies, the
question is whether it is too late for 3.4 or not. We could go for a smaller
list for now too but I wanted to hear opinions.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156186): 
https://lists.openembedded.org/g/openembedded-core/message/156186
Mute This Topic: https://lists.openembedded.org/mt/85739636/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC PATCH 14/14] layer.conf: Extend recipes not to install without explict dependencies

2021-09-20 Thread Richard Purdie
There are several dependencies which recipes have which are not needed
at runtime, only at build time. Extend the list of these from bison to
include quilt, patch, meson, autoconf, automake and ninja which should
reduce the amount of data being included in native sysroots.

This speeds up and reduces the sstate needed for image builds for example.

If this change breaks recipes, it probably means they're missing an explicit
DEPENDS on something in this list which is a bug in the recipe.

Signed-off-by: Richard Purdie 
---
 meta/conf/layer.conf | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
index 307ad7e2237..b3cc8a249e9 100644
--- a/meta/conf/layer.conf
+++ b/meta/conf/layer.conf
@@ -48,6 +48,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \
 "
 
 SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
+  *->patch-native \
   *->quilt-native \
   *->subversion-native \
   *->git-native \
@@ -90,7 +91,16 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
 # (e.g. X -> Y -> binutils-cross -> bison-native) no longer meet the
 # dependency incidentally. This improves determinism and avoids build
 # failures when people switch to external toolchains.
-SSTATE_EXCLUDEDEPS_SYSROOT += ".*->bison-native"
+SSTATE_EXCLUDEDEPS_SYSROOT += "\
+.*->autoconf-native \
+.*->automake-native \
+.*->bison-native \
+.*->meson-native \
+.*->ninja-native \
+.*->patch-native \
+.*->pkgconfig-native \
+.*->quilt-native \
+"
 # Nothing needs to depend on libc-initial
 # base-passwd/shadow-sysroot don't need their dependencies
 SSTATE_EXCLUDEDEPS_SYSROOT += "\
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156185): 
https://lists.openembedded.org/g/openembedded-core/message/156185
Mute This Topic: https://lists.openembedded.org/mt/85739585/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 13/14] meta: Drop useless class

2021-09-20 Thread Richard Purdie
This class was added by me back in 2007 and has changed one for a whitespace 
issue
since. It only has two lines and neither are particularly useful, one was 
replaced
by the nopackages class, the other adding recursive dependencies also is now
mainly problematic adding tons of unneeded dependencies. The name is hard to
understand and the class doesn't have a clear purpose. Drop it.

Remove the references in devtool (which may be the one reason to keep it around
but in my view still not worth it).

Signed-off-by: Richard Purdie 
---
 meta/classes/meta.bbclass   | 4 
 meta/lib/oeqa/selftest/cases/devtool.py | 2 +-
 scripts/lib/devtool/standard.py | 4 
 3 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 meta/classes/meta.bbclass

diff --git a/meta/classes/meta.bbclass b/meta/classes/meta.bbclass
deleted file mode 100644
index 5e6890238b1..000
--- a/meta/classes/meta.bbclass
+++ /dev/null
@@ -1,4 +0,0 @@
-
-PACKAGES = ""
-
-do_build[recrdeptask] = "do_build"
diff --git a/meta/lib/oeqa/selftest/cases/devtool.py 
b/meta/lib/oeqa/selftest/cases/devtool.py
index 6d9cd46bf30..f495e84c79b 100644
--- a/meta/lib/oeqa/selftest/cases/devtool.py
+++ b/meta/lib/oeqa/selftest/cases/devtool.py
@@ -649,7 +649,7 @@ class DevtoolModifyTests(DevtoolBase):
 self.track_for_cleanup(self.workspacedir)
 self.add_command_to_tearDown('bitbake-layers remove-layer */workspace')
 
-testrecipes = 'perf kernel-devsrc package-index core-image-minimal 
meta-toolchain packagegroup-core-sdk meta-ide-support'.split()
+testrecipes = 'perf kernel-devsrc package-index core-image-minimal 
meta-toolchain packagegroup-core-sdk'.split()
 # Find actual name of gcc-source since it now includes the version - 
crude, but good enough for this purpose
 result = runCmd('bitbake-layers show-recipes gcc-source*')
 for line in result.output.splitlines():
diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index b74a60d0011..01fb5ad96ff 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -318,10 +318,6 @@ def _check_compatible_recipe(pn, d):
 raise DevtoolError("The %s recipe is a packagegroup, and therefore is "
"not supported by this tool" % pn, 4)
 
-if bb.data.inherits_class('meta', d):
-raise DevtoolError("The %s recipe is a meta-recipe, and therefore is "
-   "not supported by this tool" % pn, 4)
-
 if bb.data.inherits_class('externalsrc', d) and d.getVar('EXTERNALSRC'):
 # Not an incompatibility error per se, so we don't pass the error code
 raise DevtoolError("externalsrc is currently enabled for the %s "
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156184): 
https://lists.openembedded.org/g/openembedded-core/message/156184
Mute This Topic: https://lists.openembedded.org/mt/85739584/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 12/14] buildtools-tarball/uninative-tarball/meta-ide-support: Drop useless meta class

2021-09-20 Thread Richard Purdie
The class adds an emtpy PACKAGES setting but most code now uses the
nopackages class which is much clearer. It also adds recursive do_build
dependencies which don't really serve any useful purpose any more.

Simplify the code and drop the class use.

Signed-off-by: Richard Purdie 
---
 meta/recipes-core/meta/buildtools-tarball.bb | 1 -
 meta/recipes-core/meta/meta-ide-support.bb   | 2 +-
 meta/recipes-core/meta/testexport-tarball.bb | 1 -
 meta/recipes-core/meta/uninative-tarball.bb  | 1 -
 4 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/meta/recipes-core/meta/buildtools-tarball.bb 
b/meta/recipes-core/meta/buildtools-tarball.bb
index 6e96cf6c326..fb28930656b 100644
--- a/meta/recipes-core/meta/buildtools-tarball.bb
+++ b/meta/recipes-core/meta/buildtools-tarball.bb
@@ -49,7 +49,6 @@ RDEPENDS = "${TOOLCHAIN_HOST_TASK}"
 
 EXCLUDE_FROM_WORLD = "1"
 
-inherit meta
 inherit populate_sdk
 inherit toolchain-scripts-base
 inherit nopackages
diff --git a/meta/recipes-core/meta/meta-ide-support.bb 
b/meta/recipes-core/meta/meta-ide-support.bb
index 768f6f4bb67..37e65a49cac 100644
--- a/meta/recipes-core/meta/meta-ide-support.bb
+++ b/meta/recipes-core/meta/meta-ide-support.bb
@@ -6,7 +6,7 @@ DEPENDS = "virtual/libc gdb-cross-${TARGET_ARCH} qemu-native 
qemu-helper-native
 PR = "r3"
 RM_WORK_EXCLUDE += "${PN}"
 
-inherit meta toolchain-scripts nopackages
+inherit toolchain-scripts nopackages
 
 do_populate_ide_support () {
   toolchain_create_tree_env_script
diff --git a/meta/recipes-core/meta/testexport-tarball.bb 
b/meta/recipes-core/meta/testexport-tarball.bb
index de7663b38c0..7cb84a01049 100644
--- a/meta/recipes-core/meta/testexport-tarball.bb
+++ b/meta/recipes-core/meta/testexport-tarball.bb
@@ -26,7 +26,6 @@ RDEPENDS = "${TOOLCHAIN_HOST_TASK}"
 
 EXCLUDE_FROM_WORLD = "1"
 
-inherit meta
 inherit populate_sdk
 inherit toolchain-scripts-base
 inherit nopackages
diff --git a/meta/recipes-core/meta/uninative-tarball.bb 
b/meta/recipes-core/meta/uninative-tarball.bb
index bbdaebad947..a21d08b591c 100644
--- a/meta/recipes-core/meta/uninative-tarball.bb
+++ b/meta/recipes-core/meta/uninative-tarball.bb
@@ -36,7 +36,6 @@ RDEPENDS = "${TOOLCHAIN_HOST_TASK}"
 
 EXCLUDE_FROM_WORLD = "1"
 
-inherit meta
 inherit populate_sdk
 inherit nopackages
 
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156183): 
https://lists.openembedded.org/g/openembedded-core/message/156183
Mute This Topic: https://lists.openembedded.org/mt/85739583/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC PATCH 11/14] populate_sdk_base/images: Drop use of 'meta' class and hence do_build dependencies

2021-09-20 Thread Richard Purdie
The 'meta' is old and not very useful. It empties PACKAGES and creates
recursive do_build dependencies.

We shouldn't need such recursive build dependencies any more so simplify the 
code.

This does cause behaviour changes as some dependencies are no longer built.
It did show up issues with qemu-helper-native handling for example but those
issues look like real races and the underlying dependency chains were not 
correct.

Signed-off-by: Richard Purdie 
---
 meta/classes/populate_sdk_base.bbclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/classes/populate_sdk_base.bbclass 
b/meta/classes/populate_sdk_base.bbclass
index ccfe2232895..49e166e697d 100644
--- a/meta/classes/populate_sdk_base.bbclass
+++ b/meta/classes/populate_sdk_base.bbclass
@@ -1,4 +1,6 @@
-inherit meta image-postinst-intercepts image-artifact-names
+PACKAGES = ""
+
+inherit image-postinst-intercepts image-artifact-names
 
 # Wildcards specifying complementary packages to install for every package 
that has been explicitly
 # installed into the rootfs
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156182): 
https://lists.openembedded.org/g/openembedded-core/message/156182
Mute This Topic: https://lists.openembedded.org/mt/85739582/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC PATCH 10/14] package_ipk/deb/rpm: Drop recursive do_build task dependencies

2021-09-20 Thread Richard Purdie
This is a controversial change which removes the recursive dependencies
from the do_build target of packaging tasks of recipes.

Currently this means when you "bitbake " or "bitbake ",
the packaging tasks run for all packaging backends enabled for all recipes
in the dependency chain. The same therefore then applies to images.

We don't actually need that, it is a convinience thing. Removing it
massively simplifies the task graph and causes much fewer tasks to execute
in many common scenarios. It also means less sstate is fetched for
example when building an image.

This means when building a recipe all package formats would be built
but when building an image, only the format used by the image would be
generated. This should be an improvement in most cases but some CI systems
may need to be explict about what they're building.

Signed-off-by: Richard Purdie 
---
 meta/classes/package_deb.bbclass | 5 +
 meta/classes/package_ipk.bbclass | 4 +---
 meta/classes/package_rpm.bbclass | 4 +---
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/meta/classes/package_deb.bbclass b/meta/classes/package_deb.bbclass
index eca43e17876..77caaa55c8f 100644
--- a/meta/classes/package_deb.bbclass
+++ b/meta/classes/package_deb.bbclass
@@ -315,10 +315,7 @@ python do_package_write_deb () {
 do_package_write_deb[dirs] = "${PKGWRITEDIRDEB}"
 do_package_write_deb[cleandirs] = "${PKGWRITEDIRDEB}"
 do_package_write_deb[depends] += 
"${@oe.utils.build_depends_string(d.getVar('PACKAGE_WRITE_DEPS'), 
'do_populate_sysroot')}"
-addtask package_write_deb after do_packagedata do_package
-
+addtask package_write_deb after do_packagedata do_package before do_build
 
 PACKAGEINDEXDEPS += "dpkg-native:do_populate_sysroot"
 PACKAGEINDEXDEPS += "apt-native:do_populate_sysroot"
-
-do_build[recrdeptask] += "do_package_write_deb"
diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass
index c3b53854e8b..998e18ba6c1 100644
--- a/meta/classes/package_ipk.bbclass
+++ b/meta/classes/package_ipk.bbclass
@@ -274,9 +274,7 @@ python do_package_write_ipk () {
 do_package_write_ipk[dirs] = "${PKGWRITEDIRIPK}"
 do_package_write_ipk[cleandirs] = "${PKGWRITEDIRIPK}"
 do_package_write_ipk[depends] += 
"${@oe.utils.build_depends_string(d.getVar('PACKAGE_WRITE_DEPS'), 
'do_populate_sysroot')}"
-addtask package_write_ipk after do_packagedata do_package
+addtask package_write_ipk after do_packagedata do_package before do_build
 
 PACKAGEINDEXDEPS += "opkg-utils-native:do_populate_sysroot"
 PACKAGEINDEXDEPS += "opkg-native:do_populate_sysroot"
-
-do_build[recrdeptask] += "do_package_write_ipk"
diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
index 88d861c0e75..60f8299d965 100644
--- a/meta/classes/package_rpm.bbclass
+++ b/meta/classes/package_rpm.bbclass
@@ -748,9 +748,7 @@ python do_package_write_rpm () {
 do_package_write_rpm[dirs] = "${PKGWRITEDIRRPM}"
 do_package_write_rpm[cleandirs] = "${PKGWRITEDIRRPM}"
 do_package_write_rpm[depends] += 
"${@oe.utils.build_depends_string(d.getVar('PACKAGE_WRITE_DEPS'), 
'do_populate_sysroot')}"
-addtask package_write_rpm after do_packagedata do_package
+addtask package_write_rpm after do_packagedata do_package before do_build
 
 PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
 PACKAGEINDEXDEPS += "createrepo-c-native:do_populate_sysroot"
-
-do_build[recrdeptask] += "do_package_write_rpm"
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156181): 
https://lists.openembedded.org/g/openembedded-core/message/156181
Mute This Topic: https://lists.openembedded.org/mt/85739581/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 09/14] sstate: Avoid deploy_source_date_epoch sstate when unneeded

2021-09-20 Thread Richard Purdie
This sstate task is only needed when depended upon, it can be skipped
if there are no tasks running that directly depend upon it.

This reduced the number of sstate tasks in something like an image
build.

Signed-off-by: Richard Purdie 
---
 meta/classes/sstate.bbclass | 4 
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index 498dfc681cf..5accc13a89b 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -1066,6 +1066,10 @@ def setscene_depvalid(task, taskdependees, notneeded, d, 
log=None):
 if taskdependees[task][1] == "do_populate_lic":
 return True
 
+# We only need to trigger deploy_source_date_epoch through direct 
dependencies
+if taskdependees[task][1] == "do_deploy_source_date_epoch":
+return True
+
 # stash_locale and gcc_stash_builddir are never needed as a dependency for 
built objects
 if taskdependees[task][1] == "do_stash_locale" or taskdependees[task][1] 
== "do_gcc_stash_builddir":
 return True
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156180): 
https://lists.openembedded.org/g/openembedded-core/message/156180
Mute This Topic: https://lists.openembedded.org/mt/85739580/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 08/14] sstate: Ensure deploy tasks don't pull in toolchains

2021-09-20 Thread Richard Purdie
If an image is built from sstate, the cross toolchain was being pulled in.
This was due to the sstate dependencies for deploy tasks not being considered
in the "depvalid" logic.

do_deploy tasks do not need their populate_sysroot dependencies when installed
from sstate so skip these. This reduces the sstate pulled in by an image
build from sstate significantly.

Signed-off-by: Richard Purdie 
---
 meta/classes/sstate.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index 29679e6a5ee..498dfc681cf 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -1090,8 +1090,8 @@ def setscene_depvalid(task, taskdependees, notneeded, d, 
log=None):
 # do_package_write_* need do_populate_sysroot as they're mainly 
postinstall dependencies
 if taskdependees[task][1] == "do_populate_sysroot" and 
taskdependees[dep][1] in ['do_package_write_deb', 'do_package_write_ipk', 
'do_package_write_rpm']:
 return False
-# do_package/packagedata/package_qa don't need do_populate_sysroot
-if taskdependees[task][1] == "do_populate_sysroot" and 
taskdependees[dep][1] in ['do_package', 'do_packagedata', 'do_package_qa']:
+# do_package/packagedata/package_qa/deploy don't need 
do_populate_sysroot
+if taskdependees[task][1] == "do_populate_sysroot" and 
taskdependees[dep][1] in ['do_package', 'do_packagedata', 'do_package_qa', 
'do_deploy']:
 continue
 # Native/Cross packages don't exist and are noexec anyway
 if isNativeCross(taskdependees[dep][0]) and taskdependees[dep][1] in 
['do_package_write_deb', 'do_package_write_ipk', 'do_package_write_rpm', 
'do_packagedata', 'do_package', 'do_package_qa']:
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156179): 
https://lists.openembedded.org/g/openembedded-core/message/156179
Mute This Topic: https://lists.openembedded.org/mt/85739579/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 01/14] vim: Backport fix for CVE-2021-3770

2021-09-20 Thread Richard Purdie
Signed-off-by: Richard Purdie 
---
 ...1e135a16091c93f6f5f7525a5c58fb7ca9f9.patch | 207 ++
 meta/recipes-support/vim/vim.inc  |   2 +
 2 files changed, 209 insertions(+)
 create mode 100644 
meta/recipes-support/vim/files/b7081e135a16091c93f6f5f7525a5c58fb7ca9f9.patch

diff --git 
a/meta/recipes-support/vim/files/b7081e135a16091c93f6f5f7525a5c58fb7ca9f9.patch 
b/meta/recipes-support/vim/files/b7081e135a16091c93f6f5f7525a5c58fb7ca9f9.patch
new file mode 100644
index 000..1cee7595021
--- /dev/null
+++ 
b/meta/recipes-support/vim/files/b7081e135a16091c93f6f5f7525a5c58fb7ca9f9.patch
@@ -0,0 +1,207 @@
+From b7081e135a16091c93f6f5f7525a5c58fb7ca9f9 Mon Sep 17 00:00:00 2001
+From: Bram Moolenaar 
+Date: Sat, 4 Sep 2021 18:47:28 +0200
+Subject: [PATCH] patch 8.2.3402: invalid memory access when using :retab with
+ large value
+
+Problem:Invalid memory access when using :retab with large value.
+Solution:   Check the number is positive.
+
+CVE: CVE-2021-3770
+Signed-off-by: Richard Purdie 
+Upstream-Status: Backport 
[https://github.com/vim/vim/commit/b7081e135a16091c93f6f5f7525a5c58fb7ca9f9]
+---
+ src/indent.c   | 34 +-
+ src/option.c   | 12 ++--
+ src/optionstr.c|  4 ++--
+ src/testdir/test_retab.vim |  3 +++
+ src/version.c  |  2 ++
+ 5 files changed, 34 insertions(+), 21 deletions(-)
+
+Index: git/src/indent.c
+===
+--- git.orig/src/indent.c
 git/src/indent.c
+@@ -18,18 +18,19 @@
+ /*
+  * Set the integer values corresponding to the string setting of 'vartabstop'.
+  * "array" will be set, caller must free it if needed.
++ * Return FAIL for an error.
+  */
+ int
+ tabstop_set(char_u *var, int **array)
+ {
+-int valcount = 1;
+-int t;
+-char_u *cp;
++int   valcount = 1;
++int   t;
++char_u  *cp;
+ 
+ if (var[0] == NUL || (var[0] == '0' && var[1] == NUL))
+ {
+   *array = NULL;
+-  return TRUE;
++  return OK;
+ }
+ 
+ for (cp = var; *cp != NUL; ++cp)
+@@ -43,8 +44,8 @@ tabstop_set(char_u *var, int **array)
+   if (cp != end)
+   emsg(_(e_positive));
+   else
+-  emsg(_(e_invarg));
+-  return FALSE;
++  semsg(_(e_invarg2), cp);
++  return FAIL;
+   }
+   }
+ 
+@@ -55,26 +56,33 @@ tabstop_set(char_u *var, int **array)
+   ++valcount;
+   continue;
+   }
+-  emsg(_(e_invarg));
+-  return FALSE;
++  semsg(_(e_invarg2), var);
++  return FAIL;
+ }
+ 
+ *array = ALLOC_MULT(int, valcount + 1);
+ if (*array == NULL)
+-  return FALSE;
++  return FAIL;
+ (*array)[0] = valcount;
+ 
+ t = 1;
+ for (cp = var; *cp != NUL;)
+ {
+-  (*array)[t++] = atoi((char *)cp);
+-  while (*cp  != NUL && *cp != ',')
++  int n = atoi((char *)cp);
++
++  if (n < 0 || n > )
++  {
++  semsg(_(e_invarg2), cp);
++  return FAIL;
++  }
++  (*array)[t++] = n;
++  while (*cp != NUL && *cp != ',')
+   ++cp;
+   if (*cp != NUL)
+   ++cp;
+ }
+ 
+-return TRUE;
++return OK;
+ }
+ 
+ /*
+@@ -1556,7 +1564,7 @@ ex_retab(exarg_T *eap)
+ 
+ #ifdef FEAT_VARTABS
+ new_ts_str = eap->arg;
+-if (!tabstop_set(eap->arg, &new_vts_array))
++if (tabstop_set(eap->arg, &new_vts_array) == FAIL)
+   return;
+ while (vim_isdigit(*(eap->arg)) || *(eap->arg) == ',')
+   ++(eap->arg);
+Index: git/src/option.c
+===
+--- git.orig/src/option.c
 git/src/option.c
+@@ -2292,9 +2292,9 @@ didset_options2(void)
+ #endif
+ #ifdef FEAT_VARTABS
+ vim_free(curbuf->b_p_vsts_array);
+-tabstop_set(curbuf->b_p_vsts, &curbuf->b_p_vsts_array);
++(void)tabstop_set(curbuf->b_p_vsts, &curbuf->b_p_vsts_array);
+ vim_free(curbuf->b_p_vts_array);
+-tabstop_set(curbuf->b_p_vts,  &curbuf->b_p_vts_array);
++(void)tabstop_set(curbuf->b_p_vts,  &curbuf->b_p_vts_array);
+ #endif
+ }
+ 
+@@ -5756,7 +5756,7 @@ buf_copy_options(buf_T *buf, int flags)
+   buf->b_p_vsts = vim_strsave(p_vsts);
+   COPY_OPT_SCTX(buf, BV_VSTS);
+   if (p_vsts && p_vsts != empty_option)
+-  tabstop_set(p_vsts, &buf->b_p_vsts_array);
++  (void)tabstop_set(p_vsts, &buf->b_p_vsts_array);
+   else
+   buf->b_p_vsts_array = 0;
+   buf->b_p_vsts_nopaste = p_vsts_nopaste
+@@ -5914,7 +5914,7 @@ buf_copy_options(buf_T *buf, int flags)
+   buf->b_p_isk = save_p_isk;
+ #ifdef FEAT_VARTABS
+   if (p_vts && p_vts != empty_option && !buf->b_p_vts_array)
+-  tabstop_set(p_vts, &buf->b_p_vts_array);
++  (void)tabstop_set(p_vts, &buf->b_p_vts_array);
+   else
+ 

[OE-core] [PATCH 07/14] staging: Mark deploy an sstate task

2021-09-20 Thread Richard Purdie
Deploy is a tricky task as it isn't in SSTATETASKS as it isn't always
present. We do need to ensure dependency chains around do_deploy tasks
are correctly handled as sstate tasks though. For now add to the list of
sstate tasks manually (like the other locale task reference).

Without this, missing manifest files could be reported now that do_deploy
tasks no longer have their dependencies added by the depvalid function.

Signed-off-by: Richard Purdie 
---
 meta/classes/staging.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass
index af3397bab6f..65a6cd5120b 100644
--- a/meta/classes/staging.bbclass
+++ b/meta/classes/staging.bbclass
@@ -306,6 +306,7 @@ python extend_recipe_sysroot() {
 sstatetasks = d.getVar("SSTATETASKS").split()
 # Add recipe specific tasks referenced by setscene_depvalid()
 sstatetasks.append("do_stash_locale")
+sstatetasks.append("do_deploy")
 
 def print_dep_tree(deptree):
 data = ""
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156178): 
https://lists.openembedded.org/g/openembedded-core/message/156178
Mute This Topic: https://lists.openembedded.org/mt/85739578/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 06/14] image/qemu: Add explict depends for qemu-helper addto_recipe_sysroot task

2021-09-20 Thread Richard Purdie
The populate_sysroot task isn't enough for qemu-helper-native, we need
it's addto_recipe_sysroot task. This corrects what amounts to bad
dependency information to be explicit.

Signed-off-by: Richard Purdie 
---
 meta/classes/image.bbclass | 5 -
 meta/conf/machine/include/qemu.inc | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index d76895178fb..1d88ccd8192 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -138,7 +138,10 @@ python () {
 def extraimage_getdepends(task):
 deps = ""
 for dep in (d.getVar('EXTRA_IMAGEDEPENDS') or "").split():
-deps += " %s:%s" % (dep, task)
+if ":" in dep:
+deps += " %s " % (dep)
+else:
+deps += " %s:%s" % (dep, task)
 return deps
 
 d.appendVarFlag('do_image_complete', 'depends', 
extraimage_getdepends('do_populate_sysroot'))
diff --git a/meta/conf/machine/include/qemu.inc 
b/meta/conf/machine/include/qemu.inc
index c7136da7116..642c322abcb 100644
--- a/meta/conf/machine/include/qemu.inc
+++ b/meta/conf/machine/include/qemu.inc
@@ -21,7 +21,7 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base = ""
 # Use a common kernel recipe for all QEMU machines
 PREFERRED_PROVIDER_virtual/kernel ??= "linux-yocto"
 
-EXTRA_IMAGEDEPENDS += "qemu-system-native qemu-helper-native"
+EXTRA_IMAGEDEPENDS += "qemu-system-native 
qemu-helper-native:do_addto_recipe_sysroot"
 
 # Provide the nfs server kernel module for all qemu images
 KERNEL_FEATURES:append:pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156177): 
https://lists.openembedded.org/g/openembedded-core/message/156177
Mute This Topic: https://lists.openembedded.org/mt/85739577/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 05/14] lttng-tools: Add missing DEPENDS on bison-native

2021-09-20 Thread Richard Purdie
This was being provided by other pieces of the dependency chain but is
specifically required by configure and could fail if those pieces come
from sstate. Fix such builds by adding the missing dependency.

Signed-off-by: Richard Purdie 
---
 meta/recipes-kernel/lttng/lttng-tools_2.13.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.13.0.bb 
b/meta/recipes-kernel/lttng/lttng-tools_2.13.0.bb
index 95bb2519d7d..47cab42fcf5 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_2.13.0.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_2.13.0.bb
@@ -12,7 +12,7 @@ LIC_FILES_CHKSUM = 
"file://LICENSE;md5=40ef17463fbd6f377db3c47b1cbaded8 \
 
 include lttng-platforms.inc
 
-DEPENDS = "liburcu popt libxml2 util-linux"
+DEPENDS = "liburcu popt libxml2 util-linux bison-native"
 RDEPENDS:${PN} = "libgcc"
 RRECOMMENDS:${PN} += "${LTTNGMODULES}"
 RDEPENDS:${PN}-ptest += "make perl bash gawk babeltrace procps 
perl-module-overloading coreutils util-linux kmod ${LTTNGMODULES} sed 
python3-core grep"
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156176): 
https://lists.openembedded.org/g/openembedded-core/message/156176
Mute This Topic: https://lists.openembedded.org/mt/85739576/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 04/14] recipes: Add missing pkgconfig inherit

2021-09-20 Thread Richard Purdie
Various recipes were missing a pkgconfig inherit or pkgconfig-native
dependency despite using pkgconfig.

Add the inherit to igt-gpu-tools/gdb/libmodulemd/libwpe/xwayland/waffle
shaderc/iputils/wpebackend-fdo/lttng-ust.

Signed-off-by: Richard Purdie 
---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 1 +
 meta/recipes-devtools/gdb/gdb.inc| 2 +-
 meta/recipes-devtools/libmodulemd/libmodulemd_git.bb | 2 +-
 meta/recipes-extended/iputils/iputils_20210722.bb| 2 +-
 meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 2 +-
 meta/recipes-graphics/shaderc/shaderc_2021.1.bb  | 2 +-
 meta/recipes-graphics/waffle/waffle_1.6.1.bb | 2 +-
 meta/recipes-graphics/xwayland/xwayland_21.1.2.bb| 2 +-
 meta/recipes-kernel/lttng/lttng-ust_2.13.0.bb| 2 +-
 meta/recipes-sato/webkit/libwpe_1.10.1.bb| 2 +-
 meta/recipes-sato/webkit/wpebackend-fdo_1.10.0.bb| 2 +-
 11 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc 
b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
index 670534fb5f0..dfacba29a01 100644
--- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
@@ -1,5 +1,6 @@
 inherit cross-canadian
 inherit python3-dir
+inherit pkgconfig
 
 SUMMARY = "GNU debugger (cross-canadian gdb for ${TARGET_ARCH} target)"
 PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
diff --git a/meta/recipes-devtools/gdb/gdb.inc 
b/meta/recipes-devtools/gdb/gdb.inc
index 2b0ae1655f6..2c95ed3ca0f 100644
--- a/meta/recipes-devtools/gdb/gdb.inc
+++ b/meta/recipes-devtools/gdb/gdb.inc
@@ -1,6 +1,6 @@
 require gdb-common.inc
 
-inherit gettext
+inherit gettext pkgconfig
 
 #LDFLAGS:append = " -s"
 #export CFLAGS:append=" -L${STAGING_LIBDIR}"
diff --git a/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb 
b/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb
index 963e881d6c1..ee8ce4d6a67 100644
--- a/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb
+++ b/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb
@@ -11,7 +11,7 @@ SRCREV = "1a032da198333ee77bdbe4be65e60eb4115ea73f"
 
 S = "${WORKDIR}/git"
 
-inherit meson gobject-introspection
+inherit meson gobject-introspection pkgconfig
 
 EXTRA_OEMESON = "-Dwith_py3=false -Dwith_docs=false -Drpmio=disabled 
-Dlibmagic=disabled -Dwith_manpages=disabled 
-Dgobject_overrides_dir_py3=${PYTHON_SITEPACKAGES_DIR}/gi/overrides"
 
diff --git a/meta/recipes-extended/iputils/iputils_20210722.bb 
b/meta/recipes-extended/iputils/iputils_20210722.bb
index a9821e556f0..e1940b77b5a 100644
--- a/meta/recipes-extended/iputils/iputils_20210722.bb
+++ b/meta/recipes-extended/iputils/iputils_20210722.bb
@@ -37,7 +37,7 @@ PACKAGECONFIG[tftpd] = "-DBUILD_TFTPD=true, 
-DBUILD_TFTPD=false,"
 PACKAGECONFIG[traceroute6] = 
"-DBUILD_TRACEROUTE6=true,-DBUILD_TRACEROUTE6=false,"
 PACKAGECONFIG[docs] = "-DBUILD_HTML_MANS=true 
-DBUILD_MANS=true,-DBUILD_HTML_MANS=false -DBUILD_MANS=false, libxslt"
 
-inherit meson systemd update-alternatives
+inherit meson systemd update-alternatives pkgconfig
 
 EXTRA_OEMESON += "--prefix=${root_prefix}/ -DSKIP_TESTS=true"
 
diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb 
b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
index 79fab7a28a5..1a00eca7d3a 100644
--- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
+++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=67bfee4df38fa6ecbe3a675c552d4c08"
 
 LICENSE = "MIT"
 
-inherit meson
+inherit meson pkgconfig
 
 SRCREV = "203def046b466fb2da67f9f15552d84e1c0b41f2"
 PV = "1.26"
diff --git a/meta/recipes-graphics/shaderc/shaderc_2021.1.bb 
b/meta/recipes-graphics/shaderc/shaderc_2021.1.bb
index e15b5794ee7..ad3f62ce17d 100644
--- a/meta/recipes-graphics/shaderc/shaderc_2021.1.bb
+++ b/meta/recipes-graphics/shaderc/shaderc_2021.1.bb
@@ -14,7 +14,7 @@ SRC_URI = 
"git://github.com/google/shaderc.git;protocol=https;branch=main \
 UPSTREAM_CHECK_GITTAGREGEX = "^v(?P\d+(\.\d+)+)$"
 S = "${WORKDIR}/git"
 
-inherit cmake python3native
+inherit cmake python3native pkgconfig
 
 DEPENDS = "spirv-headers spirv-tools glslang"
 
diff --git a/meta/recipes-graphics/waffle/waffle_1.6.1.bb 
b/meta/recipes-graphics/waffle/waffle_1.6.1.bb
index fa5efc12c45..395494018a5 100644
--- a/meta/recipes-graphics/waffle/waffle_1.6.1.bb
+++ b/meta/recipes-graphics/waffle/waffle_1.6.1.bb
@@ -15,7 +15,7 @@ SRC_URI[sha256sum] = 
"31565649ff0e2d8dff1b8f7f2264ab7a78452063c7e04adfc4ce03e64b
 
 UPSTREAM_CHECK_URI = "http://www.waffle-gl.org/releases.html";
 
-inherit meson features_check lib_package bash-completion
+inherit meson features_check lib_package bash-completion pkgconfig
 
 DEPENDS:append = " python3"
 
diff --git a/meta/recipes-graphics/xwayland/xwayland_21.1.2.bb 
b/meta/recipes-graphics/xwayland/xwayland_21.1.2.bb
index 3df6fd1ff90..6aba6593

[OE-core] [PATCH 03/14] sqlite3: Exclude CVE-2021-36690 from cve checks

2021-09-20 Thread Richard Purdie
Issue is in an experimental extension we don't have/use. Could also
be windows only.

Signed-off-by: Richard Purdie 
---
 meta/recipes-support/sqlite/sqlite3_3.36.0.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-support/sqlite/sqlite3_3.36.0.bb 
b/meta/recipes-support/sqlite/sqlite3_3.36.0.bb
index f5d75e8e4c2..30c9445be1a 100644
--- a/meta/recipes-support/sqlite/sqlite3_3.36.0.bb
+++ b/meta/recipes-support/sqlite/sqlite3_3.36.0.bb
@@ -10,3 +10,5 @@ SRC_URI[sha256sum] = 
"bd90c3eb96bee996206b83be7065c9ce19aef38c3f4fb53073ada0d0b6
 CVE_CHECK_WHITELIST += "CVE-2019-19242"
 # This is believed to be iOS specific 
(https://groups.google.com/g/sqlite-dev/c/U7OjAbZO6LA)
 CVE_CHECK_WHITELIST += "CVE-2015-3717"
+# Issue in an experimental extension we don't have/use. Fixed by 
https://sqlite.org/src/info/b1e0c22ec981cf5f
+CVE_CHECK_WHITELIST += "CVE-2021-36690"
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156174): 
https://lists.openembedded.org/g/openembedded-core/message/156174
Mute This Topic: https://lists.openembedded.org/mt/85739573/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 02/14] libgcrypt: Upgrade 1.9.3 -> 1.9.4

2021-09-20 Thread Richard Purdie
Includes a fix for CVE-2021-40528.

Signed-off-by: Richard Purdie 
---
 .../libgcrypt/{libgcrypt_1.9.3.bb => libgcrypt_1.9.4.bb}| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/libgcrypt/{libgcrypt_1.9.3.bb => 
libgcrypt_1.9.4.bb} (96%)

diff --git a/meta/recipes-support/libgcrypt/libgcrypt_1.9.3.bb 
b/meta/recipes-support/libgcrypt/libgcrypt_1.9.4.bb
similarity index 96%
rename from meta/recipes-support/libgcrypt/libgcrypt_1.9.3.bb
rename to meta/recipes-support/libgcrypt/libgcrypt_1.9.4.bb
index dee936dbc4c..4bc1dd85126 100644
--- a/meta/recipes-support/libgcrypt/libgcrypt_1.9.3.bb
+++ b/meta/recipes-support/libgcrypt/libgcrypt_1.9.4.bb
@@ -27,7 +27,7 @@ SRC_URI = "${GNUPG_MIRROR}/libgcrypt/libgcrypt-${PV}.tar.bz2 \

file://0004-tests-Makefile.am-fix-undefined-reference-to-pthread.patch \
file://0001-Makefile.am-add-a-missing-space.patch \
"
-SRC_URI[sha256sum] = 
"97ebe4f94e2f7e35b752194ce15a0f3c66324e0ff6af26659bbfb5ff2ec328fd"
+SRC_URI[sha256sum] = 
"ea849c83a72454e3ed4267697e8ca03390aee972ab421e7df69dfe42b65caaf7"
 
 # Below whitelisted CVEs are disputed and not affecting crypto libraries for 
any distro.
 CVE_CHECK_WHITELIST += "CVE-2018-12433 CVE-2018-12438"
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156173): 
https://lists.openembedded.org/g/openembedded-core/message/156173
Mute This Topic: https://lists.openembedded.org/mt/85739572/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [dunfell][PATCH] poky: fixes backwards compatible for the SDKPATHINSTALL

2021-09-20 Thread Richard Purdie
On Mon, 2021-09-20 at 11:07 +0100, Jose Quaresma wrote:
> Previously the SDKPATH can be used to custumize the path
> of the SDK installation. Drop the SDKPATH and use SDKPATHINSTALL
> without that brokes backwards compatible for any distro with
> SDKPATH customized.
> 
> Signed-off-by: Jose Quaresma 
> ---
>  meta-poky/conf/distro/poky.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-poky/conf/distro/poky.conf b/meta-poky/conf/distro/poky.conf
> index 5b54df874e..7dad7012ba 100644
> --- a/meta-poky/conf/distro/poky.conf
> +++ b/meta-poky/conf/distro/poky.conf
> @@ -24,7 +24,7 @@ DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT} 
> ${POKY_DEFAULT_DISTRO_FEATURES}"
>  PREFERRED_VERSION_linux-yocto ?= "5.4%"
>  
>  SDK_NAME = 
> "${DISTRO}-${TCLIBC}-${SDKMACHINE}-${IMAGE_BASENAME}-${TUNE_PKGARCH}-${MACHINE}"
> -SDKPATHINSTALL = "/opt/${DISTRO}/${SDK_VERSION}"
> +SDKPATHINSTALL = "${SDKPATH}"
>  
>  DISTRO_EXTRA_RDEPENDS += " ${POKY_DEFAULT_EXTRA_RDEPENDS}"
>  DISTRO_EXTRA_RRECOMMENDS += " ${POKY_DEFAULT_EXTRA_RRECOMMENDS}"

Distros need to switch to use SDKPATHINSTALL. 

This change breaks the poky default value instead of any distro that has
customised and disables the SDK hard coded path fix which was the original point
of the change.

Cheers,

Richard





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156171): 
https://lists.openembedded.org/g/openembedded-core/message/156171
Mute This Topic: https://lists.openembedded.org/mt/85736853/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [[meta-webserver]] netdata: Fixed the recipe.

2021-09-20 Thread Peter Kjellerstedt
> -Original Message-
> From: openembedded-core@lists.openembedded.org  c...@lists.openembedded.org> On Behalf Of jan
> Sent: den 20 september 2021 11:56
> To: openembedded-core@lists.openembedded.org
> Cc: Jan Vermaete 
> Subject: [OE-core] [[meta-webserver]] netdata: Fixed the recipe.
> 
> The netdata website was not accessable due to some (changed) permissions.
> The systemd service file will start netdata deamon with the netdata user.
> The netdata group as existing, but the netdata user was missing.
> 
> I moved some directory creations from systemd to the bitbake recipe.
> 
> The project website address changed too.
> 
> Tested with meta-raspberrypi on rpi4-32.
> 
> Signed-off-by: Jan Vermaete 
> ---
>  .../netdata/netdata/netdata.service   | 13 +++-
>  .../recipes-webadmin/netdata/netdata_git.bb   | 21 +--
>  2 files changed, 23 insertions(+), 11 deletions(-)
> 
> diff --git a/meta-webserver/recipes-
> webadmin/netdata/netdata/netdata.service b/meta-webserver/recipes-
> webadmin/netdata/netdata/netdata.service
> index b244d1866..7d50a7fdd 100644
> --- a/meta-webserver/recipes-webadmin/netdata/netdata/netdata.service
> +++ b/meta-webserver/recipes-webadmin/netdata/netdata/netdata.service
> @@ -1,13 +1,16 @@
> +# SPDX-License-Identifier: GPL-3.0-or-later
>  [Unit]
> -Description=Netdata, Real-time performance monitoring
> +Description=Real time performance monitoring
>  RequiresMountsFor=/var
> +After=network.target
> 
>  [Service]
> -User=root
> +Type=simple
> +PIDFile=/var/run/netdata/netdata.pid

Doesn't systemd prefer the pid files in /run rather than /var/run nowadays?

>  ExecStartPre=/bin/mkdir -p /var/log/netdata
> -ExecStartPre=/bin/chown -R nobody.netdata @@datadir/netdata/web
> -ExecStartPre=/bin/chown -R nobody.netdata /var/cache/netdata
> -ExecStart=/usr/sbin/netdata -nd
> +ExecStartPre=/bin/chown -R netdata.netdata /var/log/netdata
> +ExecStart=/usr/sbin/netdata -D -u netdata
> +
> 
>  [Install]
>  WantedBy=multi-user.target
> diff --git a/meta-webserver/recipes-webadmin/netdata/netdata_git.bb
> b/meta-webserver/recipes-webadmin/netdata/netdata_git.bb
> index 7c48b8a37..9a2467202 100644
> --- a/meta-webserver/recipes-webadmin/netdata/netdata_git.bb
> +++ b/meta-webserver/recipes-webadmin/netdata/netdata_git.bb
> @@ -1,17 +1,19 @@
> -HOMEPAGE = "https://github.com/firehol/netdata/";
> +HOMEPAGE = "https://github.com/netdata/netdata/";
>  SUMMARY = "Real-time performance monitoring"
> +DESCRIPTION = "Netdata is high-fidelity infrastructure monitoring and
> troubleshooting. \
> +   Open-source, free, preconfigured, opinionated, and always
> real-time."
>  LICENSE = "GPLv3"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=fc9b848046ef54b5eaee6071947abd24"
> 
> -SRC_URI = "git://github.com/firehol/netdata.git;protocol=https"
> +SRC_URI:append = " git://github.com/firehol/netdata.git;protocol=https"
>  SRCREV = "1be9200ba8e11dc81a2101d85a2725137d43f766"
>  PV = "1.22.1"
> 
>  # default netdata.conf for netdata configuration
> -SRC_URI += "file://netdata.conf"
> +SRC_URI:append = " file://netdata.conf"
> 
>  # file for providing systemd service support
> -SRC_URI += "file://netdata.service"
> +SRC_URI:append = " file://netdata.service"

There is no need to use SRC_URI:append for any of the files above. 
The original version of the recipe used the preferred format.

>  S = "${WORKDIR}/git"
> 
> @@ -31,7 +33,7 @@ SYSTEMD_AUTO_ENABLE:${PN} = "enable"
> 
>  #User specific
>  USERADD_PACKAGES = "${PN}"
> -GROUPADD_PARAM:${PN} = "--system netdata"
> +USERADD_PARAM:${PN} = "--system --no-create-home --home-dir 
> ${localstatedir}/run/netdata --user-group netdata"
> 
>  do_install:append() {
>  #set S UID for plugins
> @@ -50,6 +52,13 @@ do_install:append() {
>  sed -i -e 's,@@sysconfdir,${sysconfdir},g' 
> ${D}${sysconfdir}/netdata/netdata.conf
>  sed -i -e 's,@@libdir,${libexecdir},g' 
> ${D}${sysconfdir}/netdata/netdata.conf
>  sed -i -e 's,@@datadir,${datadir},g' 
> ${D}${sysconfdir}/netdata/netdata.conf
> +
> +install --group netdata --owner netdata --directory 
> ${D}${localstatedir}/cache/netdata
> +install --group netdata --owner netdata --directory 
> ${D}${localstatedir}/lib/netdata
> +
> +chown -R netdata:netdata ${D}${datadir}/netdata/web
>  }
> 
> -RDEPENDS:${PN} = "bash zlib"
> +FILES_${PN} += "${localstatedir}/cache/netdata/ 
> ${localstatedir}/lib/netdata/"
> +
> +RDEPENDS_${PN} = "bash zlib"

That should remain as RDEPENDS:${PN}.

//Peter

> --
> 2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156170): 
https://lists.openembedded.org/g/openembedded-core/message/156170
Mute This Topic: https://lists.openembedded.org/mt/85736748/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] poky: fixes backwards compatible for the SDKPATHINSTALL

2021-09-20 Thread Jose Quaresma
Previously the SDKPATH can be used to custumize the path
of the SDK installation. Drop the SDKPATH and use SDKPATHINSTALL
without that brokes backwards compatible for any distro with
SDKPATH customized.

Signed-off-by: Jose Quaresma 
---
 meta-poky/conf/distro/poky.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-poky/conf/distro/poky.conf b/meta-poky/conf/distro/poky.conf
index 5b54df874e..7dad7012ba 100644
--- a/meta-poky/conf/distro/poky.conf
+++ b/meta-poky/conf/distro/poky.conf
@@ -24,7 +24,7 @@ DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT} 
${POKY_DEFAULT_DISTRO_FEATURES}"
 PREFERRED_VERSION_linux-yocto ?= "5.4%"
 
 SDK_NAME = 
"${DISTRO}-${TCLIBC}-${SDKMACHINE}-${IMAGE_BASENAME}-${TUNE_PKGARCH}-${MACHINE}"
-SDKPATHINSTALL = "/opt/${DISTRO}/${SDK_VERSION}"
+SDKPATHINSTALL = "${SDKPATH}"
 
 DISTRO_EXTRA_RDEPENDS += " ${POKY_DEFAULT_EXTRA_RDEPENDS}"
 DISTRO_EXTRA_RRECOMMENDS += " ${POKY_DEFAULT_EXTRA_RRECOMMENDS}"
-- 
2.33.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156169): 
https://lists.openembedded.org/g/openembedded-core/message/156169
Mute This Topic: https://lists.openembedded.org/mt/85736853/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [[meta-webserver]] netdata: Fixed the recipe.

2021-09-20 Thread jan
The netdata website was not accessable due to some (changed) permissions.
The systemd service file will start netdata deamon with the netdata user.
The netdata group as existing, but the netdata user was missing.

I moved some directory creations from systemd to the bitbake recipe.

The project website address changed too.

Tested with meta-raspberrypi on rpi4-32.

Signed-off-by: Jan Vermaete 
---
 .../netdata/netdata/netdata.service   | 13 +++-
 .../recipes-webadmin/netdata/netdata_git.bb   | 21 +--
 2 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/meta-webserver/recipes-webadmin/netdata/netdata/netdata.service 
b/meta-webserver/recipes-webadmin/netdata/netdata/netdata.service
index b244d1866..7d50a7fdd 100644
--- a/meta-webserver/recipes-webadmin/netdata/netdata/netdata.service
+++ b/meta-webserver/recipes-webadmin/netdata/netdata/netdata.service
@@ -1,13 +1,16 @@
+# SPDX-License-Identifier: GPL-3.0-or-later
 [Unit]
-Description=Netdata, Real-time performance monitoring
+Description=Real time performance monitoring
 RequiresMountsFor=/var
+After=network.target
 
 [Service]
-User=root
+Type=simple
+PIDFile=/var/run/netdata/netdata.pid
 ExecStartPre=/bin/mkdir -p /var/log/netdata
-ExecStartPre=/bin/chown -R nobody.netdata @@datadir/netdata/web
-ExecStartPre=/bin/chown -R nobody.netdata /var/cache/netdata
-ExecStart=/usr/sbin/netdata -nd
+ExecStartPre=/bin/chown -R netdata.netdata /var/log/netdata
+ExecStart=/usr/sbin/netdata -D -u netdata
+
 
 [Install]
 WantedBy=multi-user.target
diff --git a/meta-webserver/recipes-webadmin/netdata/netdata_git.bb 
b/meta-webserver/recipes-webadmin/netdata/netdata_git.bb
index 7c48b8a37..9a2467202 100644
--- a/meta-webserver/recipes-webadmin/netdata/netdata_git.bb
+++ b/meta-webserver/recipes-webadmin/netdata/netdata_git.bb
@@ -1,17 +1,19 @@
-HOMEPAGE = "https://github.com/firehol/netdata/";
+HOMEPAGE = "https://github.com/netdata/netdata/";
 SUMMARY = "Real-time performance monitoring"
+DESCRIPTION = "Netdata is high-fidelity infrastructure monitoring and 
troubleshooting. \
+   Open-source, free, preconfigured, opinionated, and always 
real-time."
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=fc9b848046ef54b5eaee6071947abd24"
 
-SRC_URI = "git://github.com/firehol/netdata.git;protocol=https"
+SRC_URI:append = " git://github.com/firehol/netdata.git;protocol=https"
 SRCREV = "1be9200ba8e11dc81a2101d85a2725137d43f766"
 PV = "1.22.1"
 
 # default netdata.conf for netdata configuration
-SRC_URI += "file://netdata.conf"
+SRC_URI:append = " file://netdata.conf"
 
 # file for providing systemd service support
-SRC_URI += "file://netdata.service"
+SRC_URI:append = " file://netdata.service"
 
 S = "${WORKDIR}/git"
 
@@ -31,7 +33,7 @@ SYSTEMD_AUTO_ENABLE:${PN} = "enable"
 
 #User specific
 USERADD_PACKAGES = "${PN}"
-GROUPADD_PARAM:${PN} = "--system netdata"
+USERADD_PARAM:${PN} = "--system --no-create-home --home-dir 
${localstatedir}/run/netdata --user-group netdata"
 
 do_install:append() {
 #set S UID for plugins
@@ -50,6 +52,13 @@ do_install:append() {
 sed -i -e 's,@@sysconfdir,${sysconfdir},g' 
${D}${sysconfdir}/netdata/netdata.conf
 sed -i -e 's,@@libdir,${libexecdir},g' 
${D}${sysconfdir}/netdata/netdata.conf
 sed -i -e 's,@@datadir,${datadir},g' ${D}${sysconfdir}/netdata/netdata.conf
+
+install --group netdata --owner netdata --directory 
${D}${localstatedir}/cache/netdata
+install --group netdata --owner netdata --directory 
${D}${localstatedir}/lib/netdata
+
+chown -R netdata:netdata ${D}${datadir}/netdata/web
 }
 
-RDEPENDS:${PN} = "bash zlib"
+FILES_${PN} += "${localstatedir}/cache/netdata/ ${localstatedir}/lib/netdata/"
+
+RDEPENDS_${PN} = "bash zlib"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156168): 
https://lists.openembedded.org/g/openembedded-core/message/156168
Mute This Topic: https://lists.openembedded.org/mt/85736748/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

2021-09-20 Thread Richard Purdie
On Mon, 2021-09-20 at 09:45 +0200, Quentin Schulz wrote:
> Hi Richard,
> 
> On Sun, Sep 19, 2021 at 07:36:56PM +0100, Richard Purdie wrote:
> > On Sun, 2021-09-19 at 18:06 +, Peter Kjellerstedt wrote:
> > > > -Original Message-
> > > > From: openembedded-core@lists.openembedded.org  > > > c...@lists.openembedded.org> On Behalf Of Richard Purdie
> > > > Sent: den 19 september 2021 13:03
> > > > To: openembedded-core@lists.openembedded.org
> > > > Subject: Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive
> > > > do_build task dependencies
> > > > 
> > > > On Sun, 2021-09-19 at 11:57 +0100, Richard Purdie via 
> > > > lists.openembedded.org
> > > > wrote:
> > > > > This is a controversial change which removes the recursive 
> > > > > dependencies
> > > > > from the do_build target of packaging tasks of recipes.
> > > > > 
> > > > > Currently this means when you "bitbake " or "bitbake ",
> > > > > the packaging tasks run for all packaging backends enabled for all 
> > > > > recipes
> > > > > in the dependency chain. The same therefore then applies to images.
> > > > > 
> > > > > We don't actually need that, it is a convinience thing. Removing it
> > > > > massively simplifies the task graph and causes much fewer tasks to 
> > > > > execute
> > > > > in many common scenarios. It also means less sstate is fetched for
> > > > > example when building an image.
> > > > > 
> > > > > Signed-off-by: Richard Purdie 
> > > > > ---
> > > > >  meta/classes/package_deb.bbclass | 2 --
> > > > >  meta/classes/package_ipk.bbclass | 2 --
> > > > >  meta/classes/package_rpm.bbclass | 2 --
> > > > >  3 files changed, 6 deletions(-)
> > > > > 
> > > > > diff --git a/meta/classes/package_deb.bbclass
> > > > > b/meta/classes/package_deb.bbclass
> > > > > index eca43e17876..8f0eadbcd2e 100644
> > > > > --- a/meta/classes/package_deb.bbclass
> > > > > +++ b/meta/classes/package_deb.bbclass
> > > > > @@ -320,5 +320,3 @@ addtask package_write_deb after do_packagedata
> > > > > do_package
> > > > > 
> > > > >  PACKAGEINDEXDEPS += "dpkg-native:do_populate_sysroot"
> > > > >  PACKAGEINDEXDEPS += "apt-native:do_populate_sysroot"
> > > > > -
> > > > > -do_build[recrdeptask] += "do_package_write_deb"
> > > > > diff --git a/meta/classes/package_ipk.bbclass
> > > > > b/meta/classes/package_ipk.bbclass
> > > > > index c3b53854e8b..756744279e1 100644
> > > > > --- a/meta/classes/package_ipk.bbclass
> > > > > +++ b/meta/classes/package_ipk.bbclass
> > > > > @@ -278,5 +278,3 @@ addtask package_write_ipk after do_packagedata
> > > > > do_package
> > > > > 
> > > > >  PACKAGEINDEXDEPS += "opkg-utils-native:do_populate_sysroot"
> > > > >  PACKAGEINDEXDEPS += "opkg-native:do_populate_sysroot"
> > > > > -
> > > > > -do_build[recrdeptask] += "do_package_write_ipk"
> > > > > diff --git a/meta/classes/package_rpm.bbclass
> > > > > b/meta/classes/package_rpm.bbclass
> > > > > index 88d861c0e75..9f415b234de 100644
> > > > > --- a/meta/classes/package_rpm.bbclass
> > > > > +++ b/meta/classes/package_rpm.bbclass
> > > > > @@ -752,5 +752,3 @@ addtask package_write_rpm after do_packagedata
> > > > > do_package
> > > > > 
> > > > >  PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
> > > > >  PACKAGEINDEXDEPS += "createrepo-c-native:do_populate_sysroot"
> > > > > -
> > > > > -do_build[recrdeptask] += "do_package_write_rpm"
> > > > 
> > > > Just to add a bit more context to this, the bigger impact will be on CI
> > > > setups
> > > > including our autobuilder since "bitbake XXX" will no longer do quite 
> > > > what
> > > > it
> > > > did before. I'm starting to think we should move to the new behaviour 
> > > > and
> > > > apapt
> > > > the CI targets as/where needed.
> > > > 
> > > > I have a build running on the autobuilder to see what impact this has 
> > > > on the
> > > > automated tests. I'd welcome other people's thoughts on this.
> > > > 
> > > > FWIW we have removed a lot of these recursive dependencies, this one is 
> > > > one
> > > > of
> > > > the few left on do_build but it has been left as it has the biggest user
> > > > visible
> > > > impact.
> > > > 
> > > > Cheers,
> > > > 
> > > > Richard
> > > 
> > > You write that this is a controversial change with big user visible 
> > > impact.
> > > At the same time you write that we do not need the removed dependencies.
> > > What I don't see in your commit message, nor in the follow up mail, is 
> > > _what_ 
> > > the impact actually is. What will I no longer get when I run `bitbake
> > > `?
> > 
> > For this change, "bitbake " will no longer generate packages you're 
> > not
> > using. So for example if ipk is you main format but you've enabled deb and 
> > rpm
> > as well, only the ipk will be generated after this whilst before, the others
> > would too. That may be a big deal for some CI systems, hopefully less so in 
> > real
> > world use.
> > 
> 
> Does this mean that technically PACKAGE_CLASSES will basically only ever
> make Bitbake use the first one in the list an

Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive do_build task dependencies

2021-09-20 Thread Quentin Schulz
Hi Richard,

On Sun, Sep 19, 2021 at 07:36:56PM +0100, Richard Purdie wrote:
> On Sun, 2021-09-19 at 18:06 +, Peter Kjellerstedt wrote:
> > > -Original Message-
> > > From: openembedded-core@lists.openembedded.org  > > c...@lists.openembedded.org> On Behalf Of Richard Purdie
> > > Sent: den 19 september 2021 13:03
> > > To: openembedded-core@lists.openembedded.org
> > > Subject: Re: [OE-core] [RFC PATCH] package_ipk/deb/rpm: Drop recursive
> > > do_build task dependencies
> > > 
> > > On Sun, 2021-09-19 at 11:57 +0100, Richard Purdie via 
> > > lists.openembedded.org
> > > wrote:
> > > > This is a controversial change which removes the recursive dependencies
> > > > from the do_build target of packaging tasks of recipes.
> > > > 
> > > > Currently this means when you "bitbake " or "bitbake ",
> > > > the packaging tasks run for all packaging backends enabled for all 
> > > > recipes
> > > > in the dependency chain. The same therefore then applies to images.
> > > > 
> > > > We don't actually need that, it is a convinience thing. Removing it
> > > > massively simplifies the task graph and causes much fewer tasks to 
> > > > execute
> > > > in many common scenarios. It also means less sstate is fetched for
> > > > example when building an image.
> > > > 
> > > > Signed-off-by: Richard Purdie 
> > > > ---
> > > >  meta/classes/package_deb.bbclass | 2 --
> > > >  meta/classes/package_ipk.bbclass | 2 --
> > > >  meta/classes/package_rpm.bbclass | 2 --
> > > >  3 files changed, 6 deletions(-)
> > > > 
> > > > diff --git a/meta/classes/package_deb.bbclass
> > > > b/meta/classes/package_deb.bbclass
> > > > index eca43e17876..8f0eadbcd2e 100644
> > > > --- a/meta/classes/package_deb.bbclass
> > > > +++ b/meta/classes/package_deb.bbclass
> > > > @@ -320,5 +320,3 @@ addtask package_write_deb after do_packagedata
> > > > do_package
> > > > 
> > > >  PACKAGEINDEXDEPS += "dpkg-native:do_populate_sysroot"
> > > >  PACKAGEINDEXDEPS += "apt-native:do_populate_sysroot"
> > > > -
> > > > -do_build[recrdeptask] += "do_package_write_deb"
> > > > diff --git a/meta/classes/package_ipk.bbclass
> > > > b/meta/classes/package_ipk.bbclass
> > > > index c3b53854e8b..756744279e1 100644
> > > > --- a/meta/classes/package_ipk.bbclass
> > > > +++ b/meta/classes/package_ipk.bbclass
> > > > @@ -278,5 +278,3 @@ addtask package_write_ipk after do_packagedata
> > > > do_package
> > > > 
> > > >  PACKAGEINDEXDEPS += "opkg-utils-native:do_populate_sysroot"
> > > >  PACKAGEINDEXDEPS += "opkg-native:do_populate_sysroot"
> > > > -
> > > > -do_build[recrdeptask] += "do_package_write_ipk"
> > > > diff --git a/meta/classes/package_rpm.bbclass
> > > > b/meta/classes/package_rpm.bbclass
> > > > index 88d861c0e75..9f415b234de 100644
> > > > --- a/meta/classes/package_rpm.bbclass
> > > > +++ b/meta/classes/package_rpm.bbclass
> > > > @@ -752,5 +752,3 @@ addtask package_write_rpm after do_packagedata
> > > > do_package
> > > > 
> > > >  PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
> > > >  PACKAGEINDEXDEPS += "createrepo-c-native:do_populate_sysroot"
> > > > -
> > > > -do_build[recrdeptask] += "do_package_write_rpm"
> > > 
> > > Just to add a bit more context to this, the bigger impact will be on CI
> > > setups
> > > including our autobuilder since "bitbake XXX" will no longer do quite what
> > > it
> > > did before. I'm starting to think we should move to the new behaviour and
> > > apapt
> > > the CI targets as/where needed.
> > > 
> > > I have a build running on the autobuilder to see what impact this has on 
> > > the
> > > automated tests. I'd welcome other people's thoughts on this.
> > > 
> > > FWIW we have removed a lot of these recursive dependencies, this one is 
> > > one
> > > of
> > > the few left on do_build but it has been left as it has the biggest user
> > > visible
> > > impact.
> > > 
> > > Cheers,
> > > 
> > > Richard
> > 
> > You write that this is a controversial change with big user visible impact.
> > At the same time you write that we do not need the removed dependencies.
> > What I don't see in your commit message, nor in the follow up mail, is 
> > _what_ 
> > the impact actually is. What will I no longer get when I run `bitbake
> > `?
> 
> For this change, "bitbake " will no longer generate packages you're not
> using. So for example if ipk is you main format but you've enabled deb and rpm
> as well, only the ipk will be generated after this whilst before, the others
> would too. That may be a big deal for some CI systems, hopefully less so in 
> real
> world use.
> 

Does this mean that technically PACKAGE_CLASSES will basically only ever
make Bitbake use the first one in the list and do nothing with the
others?

Cheers,
Quentin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156166): 
https://lists.openembedded.org/g/openembedded-core/message/156166
Mute This Topic: https://lists.openembedded.org/mt/85715723/21656
Group Owner: openembedded-core+ow...@lists.