Hi Paul,
Thank you for review!
My answers are below.
On Thu, Aug 27, 2015 at 03:07:37PM +0100, Paul Eggleton wrote:
> Hi Ed,
>
> On Monday 24 August 2015 10:33:31 Ed Bartosh wrote:
> > Implemented new plugin to build image from workspace packages.
> >
> > Plugin c
Used logger variable name instead of LOG as it is used in the rest
of devtool code.
Although Pylint complains about 'logger' being invalid constant name,
but it's better to be consistent in naming than make Pylint happy.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/bui
Moved standard.py:_parse_recipe -> __init__.py:parse_recipe and
standard.py:_get_recipe_file -> __init__.py:get_recipe_file
to be able to call them from other modules.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/__init__.py | 27 +++
scripts/lib/d
Added couple of hopefully useful comments to the code.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/lib/devtool/build-image.py
b/scripts/lib/devtool/build-image.py
index 5bc8213..817703a 100644
--- a/scripts/lib
It doesn't make sense to use it as image recipe is not
in workspace. It means that we can't do 'devtool reset'
for the recipe, which is a main point of using add_md5.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 4 +---
1 file changed, 1 insertion(+),
Added logger calls to show if image is modified by the
plugin or not.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/lib/devtool/build-image.py
b/scripts/lib/devtool/build-image.py
index d246fad..563563b 100644
This reverts commit 69c63728dae38d5b1cc9874268f235a07e04d3db.
Moved add_md5 back to standard.py as it's not used in
any plugin anymore.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/__init__.py | 7 ---
scripts/lib/devtool/standard.py | 15 +++
2 files change
Removed .bbappend before generating it again as
it may cause tinfoil to fail due to its wrong content.
It's safe to do as .bbappend is regenerated anyway.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/script
Added test case to test functionaly of build-image plugin:
Add two packages to workspace and run 'devtool build-image
core-image-minimal'.
Checked if command is successful.
Checked if expected package is added to generated
core-image-minimal.bbappend file.
Signed-off-by: Ed Bartosh
Filtered out non-target recipes and recipes with
recipe name != package name in build-image plugin.
Isolated all logic of getting recipes in _get_recipes
function.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 25 +
1 file changed, 21 insertions
Made parser help message and description more clear in
build-image plugin.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/scripts/lib/devtool/build-image.py
b/scripts/lib/devtool/build-image.py
Added notification callback to .bbapend to notify
user that image is modified by build-image plugin.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 9 +
1 file changed, 9 insertions(+)
diff --git a/scripts/lib/devtool/build-image.py
b/scripts/lib/devtool/build
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib ed/devtool/8135
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/devtool/8135
Ed Bartosh (11):
devtool: make 2 functions public
devtool: build-image: stop using add_md5
Revert "devtool: make
So far all devtool and recipetool plugins were expected
to have plugin_init function. This function is empty in
most of plugins as they don't require initialisation.
Making plugin_init optional would allow not having empty
plugin_init in every plugin.
Signed-off-by: Ed Bartosh
---
script
Write set of bitbake variables used by wic into
build/tmp/sysroots//imagedata/.env
List of variables is defined in WICVARS variable in
meta/classes/image_types.bbclass.
This is needed for wic to be able to get bitbake variables without
running 'bitbake -e'.
Signed-off-by: Ed Bartosh
Moved code of getting bitbake variables into separate class.
Created singleton object of this class in the module namespace.
Preserved existing API get_bitbake_var.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/oe/misc.py | 91 +++-
1 file changed, 53
e
runs wic to produce wic images. In this case wic can't run bitbake
again as it's locked, so it will get variables from .env files.
Signed-off-by: Ed Bartosh
---
scripts/wic | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/wic b/scripts/wic
index 5818e2d..25b0d67 1007
Added test case to check if .env file is generated
and contains bitbake variables used in wic code.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 20
1 file changed, 20 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py
, IMAGE_ROOTFS_ALIGNMENT, IMAGE_OVERHEAD_FACTOR
and IMAGE_ROOTFS_EXTRA_SPACE.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/imager/direct.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/scripts/lib/wic/imager/direct.py b/scripts/lib/wic/imager/direct.py
index 57b1335..d68fd2a 100644
--- a
Added test case to verify building of wic-image-minimal recipe
and produced artifacts: manifest and bzipped partitioned image.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib
Moved code that parses one line of 'bitbake -e' output
to separate method _parse_line.
This method will be also used later to parse lines of .env files.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/oe/misc.py | 27 +--
1 file changed, 17 inserti
inimal/1.0-r0/rootfs
BOOTIMG_DIR: tmp/sysroots/qemux86-64/usr/share
KERNEL_DIR: tmp/deploy/images/qemux86-64
NATIVE_SYSROOT: tmp/sysroots/x86_64-linux
Signed-off-by: Ed Bartosh
---
meta/recipes-extended/images/wic-image-minimal.bb | 14 ++
meta/recipes-extended/images/wic-image-minimal.wk
New attribute is used when bitbake variable is requested without
specifying image name. The attribute should be set from outside,
for example when wic is called with '-e ' option.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/oe/misc.py | 6 ++
1 file changed, 6 insertion
the git repository at:
git://git.yoctoproject.org/poky-contrib ed/wic/wic-image-type
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wic-image-type
Ed Bartosh (12):
image.py: write bitbake variables to .env file
oe-selftest: test generation of .env
wic: add BitbakeVars
Set BitbakeVars.default_image when wic is called with -e option.
This makes get_bitbake_var API to use provided image as a default
source of variables.
Signed-off-by: Ed Bartosh
---
scripts/wic | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/wic b/scripts/wic
Added functionality of getting variables from .env files to
BitbakeVars class. env files will be parsed if the directory with
env files is known, i.e. when vars_dir attribute is set.
Otherwise 'bitbake -e' output will be parsed.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/
wic image type is used to produce partitioned images.
Image configuration should be stored in either ..wks
or .wks file.
.wks file should be put to the same location as image recipe
and have the same name.
[YOCTO #7672]
Signed-off-by: Ed Bartosh
---
meta/classes/image_types.bbclass | 12
Write set of bitbake variables used by wic into
build/tmp/sysroots//imagedata/.env
List of variables is defined in WICVARS variable in
meta/classes/image_types.bbclass.
This is needed for wic to be able to get bitbake variables without
running 'bitbake -e'.
Signed-off-by: Ed Bartosh
inimal/1.0-r0/rootfs
BOOTIMG_DIR: tmp/sysroots/qemux86-64/usr/share
KERNEL_DIR: tmp/deploy/images/qemux86-64
NATIVE_SYSROOT: tmp/sysroots/x86_64-linux
Signed-off-by: Ed Bartosh
---
meta-selftest/recipes-test/images/wic-image-minimal.bb | 14 ++
meta-selftest/recipes-test/images/wic-im
Added test case to verify building of wic-image-minimal recipe
and produced artifacts: manifest and bzipped partitioned image.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib
e git repository at:
git://git.yoctoproject.org/poky-contrib ed/wic/wic-image-type
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wic-image-type
Ed Bartosh (5):
image.py: write bitbake variables to .env file
oe-selftest: test generation of .env
wic-image-minimal: add wic
Added test case to check if .env file is generated
and contains bitbake variables used in wic code.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 20
1 file changed, 20 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py
, IMAGE_ROOTFS_ALIGNMENT, IMAGE_OVERHEAD_FACTOR
and IMAGE_ROOTFS_EXTRA_SPACE.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/imager/direct.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/scripts/lib/wic/imager/direct.py b/scripts/lib/wic/imager/direct.py
index 57b1335..d68fd2a 100644
--- a
This test case fails on qemu machines as not all expected bitbake
variables are present in .env file.
Fixed by filtering out optional variables.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/lib/oeqa
On Sun, Aug 30, 2015 at 09:22:50PM -0700, Christopher Larson wrote:
> On Sun, Aug 30, 2015 at 2:14 PM, Ed Bartosh
> wrote:
>
> > Write set of bitbake variables used by wic into
> > build/tmp/sysroots//imagedata/.env
> >
> > List of variables is defined in WIC
/cgit.cgi/poky-contrib/log/?h=ed/wic/misc
Ed Bartosh (17):
wic: use ext4 in canned .wks files
wic: get rid of scripts/lib/image
oe-selftest: wic: configure a build
wic: add test cases for 3 images
wic: fix typo
wic: remove micpartition.py
wic: remove micboot.py
wic: fix errors in
Moved content of scripts/lib/image/ to scripts/lib/wic as
one directory with the same name as a tool is self-explanatory
and less confusing than two.
Signed-off-by: Ed Bartosh
---
scripts/lib/image/__init__.py | 22 --
.../{image => wic}/canned-
Latest kernel doesn't have ext3 compiled in. Wic images produced
from canned .wks can't boot because of that. Switching to ext4
fixes this issue.
Signed-off-by: Ed Bartosh
---
scripts/lib/image/canned-wks/directdisk-gpt.wks | 4 ++--
scripts/lib/image/canned-wks/direct
better to build image in setUpClass, which
is called only once, but add_config method can't be called in class method,
so we have to use this trick with class variable in setUp method.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 13 +++--
1 file changed, 11 insertions(
Fixed typo in tool name: mkswqp -> mkswap.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/oe/misc.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/lib/wic/utils/oe/misc.py b/scripts/lib/wic/utils/oe/misc.py
index 0a8f3f1..7370d93 100644
--- a/scripts/lib/
unction-redefined)
E:488,22: Undefined variable 'OptionValueError' (undefined-variable)
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/kickstart/custom_commands/partition.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/lib/wic/kickstart/custom_commands/p
Used explicit imports in partitions.py and wicboot.py
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/kickstart/custom_commands/partition.py | 3 ++-
scripts/lib/wic/kickstart/custom_commands/wicboot.py | 4
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/scripts/lib/wic
Moved functionality of Mic_Partition and Mic_PartData classes
from micpartition.py to Wic_Partition and Wic_PartData classes
of partition.py module.
Reduced level of inheritance.
Removed confusing mic legacy names.
Signed-off-by: Ed Bartosh
---
.../lib/wic/kickstart/custom_commands/__init__.py
Renamed variables named as Python builtin functions.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/engine.py| 18 +-
scripts/lib/wic/imager/baseimager.py | 4 ++--
scripts/lib/wic/imager/direct.py | 6 +++---
scripts/lib/wic
Made short variable names longer and more readable.
Fixed pylint warnings "Invalid variable name" and
"Invalid argument name".
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/conf.py| 4 +-
scripts/lib/wic/engine.py | 6
Removed or reworked code with unused variables.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/engine.py | 4 +---
scripts/lib/wic/imager/baseimager.py | 4 ++--
scripts/lib/wic/imager/direct.py | 2 +-
scripts/lib/wic/plugin.py | 7
Fixed pylint warning:
Instance of 'ConfigMgr' has no 'create' member (no-member)
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/conf.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/lib/wic/conf.py b/scripts/lib/wic/conf.py
index 402ed62..942c0c1 100644
-
.
Removed cmdln.py from the wic codebase.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/creator.py | 115 +-
scripts/lib/wic/plugins/imager/direct_plugin.py |2 +-
scripts/lib/wic/utils/cmdln.py | 1604 ---
3 files changed, 27
Fixed pylint warning:
More than one statement on a single line (multiple-statements)
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/plugin.py | 3 ++-
scripts/lib/wic/utils/cmdln.py | 57 +++--
scripts/lib/wic/utils/runner.py | 3 ++-
3 files changed
Moved functionaly of micboot.py Mic_Bootloader class to
Wic_Bootloader class of wicboot.py module.
Signed-off-by: Ed Bartosh
---
.../lib/wic/kickstart/custom_commands/micboot.py | 50 --
.../lib/wic/kickstart/custom_commands/wicboot.py | 23 ++
2 files changed
Added test cases to build qemux86_directdisk, mkgummidisk and
mkefdisk images.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 21 +
1 file changed, 21 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py
index 817a820
Functionality of listing and using properties of wic images
does not exist in the wic code. However, there are plenty of
help and usage content about it, which is very confusing.
Removed everything regarding image properties from wic codebase.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic
Renamed this function as it's too generic name for it.
It writes variables, which are used by wic to .env file,
so _write_wic_env is better name for it.
Thanks Christopher Larson for poining out to this.
Signed-off-by: Ed Bartosh
---
meta/lib/oe/image.py | 4 ++--
1 file changed, 2 inser
On Wed, Sep 02, 2015 at 02:16:58PM +0300, Jussi Kukkonen wrote:
> On 30 August 2015 at 19:08, Ed Bartosh wrote:
> >
> > Moved standard.py:_parse_recipe -> __init__.py:parse_recipe and
> > standard.py:_get_recipe_file -> __init__.py:get_recipe_file
> > t
ing result.
This should work for int and float literals.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/imager/direct.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/lib/wic/imager/direct.py b/scripts/lib/wic/imager/direct.py
index 31c0edc..146a0d1 100644
--- a/scrip
://git.yoctoproject.org/poky-contrib ed/wic/misc
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/misc
Ed Bartosh (3):
wic: add dependencies to wic-image-minimal recipe
wic: use ext4 in wic-image-minimal.wks
wic: fix partition size calculation
meta-selftest/recipes-test/images/wic-image
ext4 is used in canned wks files, so let's use it here too
for the sake of consistency.
Signed-off-by: Ed Bartosh
---
meta-selftest/recipes-test/images/wic-image-minimal.wks | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta-selftest/recipes-test/images/wic-
It was wrongly assumed that part.size is meagured in Mb. In fact it's
in Kb, so there is no need to convert bitbake variable ROOTFS_SIZE as
it's also in Kb.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/imager/direct.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
di
Added "DEPENDS =" line to the recipe to ensure that all tools required
for image creation are built.
Signed-off-by: Ed Bartosh
---
meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta-selftest/recipes-test/images/wic-image-
Hi George,
Thank you for the fix!
Acked-by: Ed Bartosh
On Thu, Sep 10, 2015 at 12:30:52PM -0500, George McCollister wrote:
> If the path contains 'scripts' more than once the first occurrence will be
> incorrectly used. Use rfind instead of find to find the last occurrence.
&g
Added "DEPENDS =" line to the recipe to ensure that all tools required
for image creation are built.
Signed-off-by: Ed Bartosh
---
meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta-selftest/recipes-test/images/wic-image-
git repository at:
git://git.yoctoproject.org/poky-contrib ed/wic/misc
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/misc
Ed Bartosh (4):
wic: add dependencies to wic-image-minimal recipe
wic: use ext4 in wic-image-minimal.wks
wic: fix partition size calculation
wic
Added dependency to wic-image-minimal.wks to the recipe. This makes
bitbake to rebuild the image if .wks file changes.
Signed-off-by: Ed Bartosh
---
meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta-selftest/recipes-test/images/wic
ext4 is used in canned wks files, so let's use it here too
for the sake of consistency.
Signed-off-by: Ed Bartosh
---
meta-selftest/recipes-test/images/wic-image-minimal.wks | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta-selftest/recipes-test/images/wic-
It was wrongly assumed that part.size is meagured in Mb. In fact it's
in Kb, so there is no need to convert bitbake variable ROOTFS_SIZE as
it's also in Kb.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/imager/direct.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
di
Removed wic-image-minimal.bb and wic-image-minimal.wks as they're
also present in meta-selftest/recipes-test/images/
Signed-off-by: Ed Bartosh
---
meta/recipes-extended/images/wic-image-minimal.bb | 14 --
meta/recipes-extended/images/wic-image-minimal.wks | 10 --
2
Appended required features to build config every time
LocalSetup is run to ensure that core-image-minimal is not
rebuilt due to configuration changes.
This should fix test22_mkgummidisk and test23_mkefidisk testcases as
they depend on specific features set in LocalSetup.
Signed-off-by: Ed
/core-image-minimal/...
returned '1' instead of 0
Made exec_native_cmd aware of pseudo and properly report
errors when command is not found.
[YOCTO #6204]
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/kickstart/custom_commands/partition.py | 6 +++---
scripts/lib/wic/u
Since the log_check_regex can potentially be false positive it
makes sense to print the whole line where error is found.
This way user will be able to see the error and understand
if it's valid or not.
[YOCTO: #7789]
Signed-off-by: Ed Bartosh
---
meta/lib/oe/rootfs.py | 1 +
1 file chang
Hi Noor,
Sorry for delay. I missed your e-mail somehow.
Can you please show your recipe, wks file and the details of your build
configuration(MACHINE, bblayers, etc) ?
---
Regards,
Ed
--
___
Openembedded-core mailing list
Openembedded-core@lists.opene
sight from me. I need more detailed review of it.
Can you point me out where the renaming you've mentioned is happening?
Anyway it would be good if I could reproduce the issue to better
understand it. Can you provide more details about your configuration?
Regards,
Ed
>
> Noor
>
'start'] + part['size'] - 1, part['size']))
>
> os.rename(source, image_file + '.p%d' % part['num'])
>
Thank you for the info! I'll try to reproduce the issue.
Wild guess: would copying a file instead of renaming it s
>
I'm ok with the patch then if you update it according to Leonardo's
suggestion.
> Noor
>
> -Original Message-
> From: Ed Bartosh [mailto:ed.bart...@linux.intel.com]
> Sent: Tuesday, October 27, 2015 10:42 PM
> To: Ahsan, Noor
> Cc: openembedded-
'
[YOCTO #8553]
Signed-off-by: Ed Bartosh
---
.../{dbus-test_1.8.20.bb => dbus-test_1.10.2.bb}| 4 ++--
meta/recipes-core/dbus/dbus.inc | 6 --
meta/recipes-core/dbus/dbus/python-config.patch | 21 ++---
meta/recipes-core/dbus/dbus_1
On Sat, Oct 31, 2015 at 04:45:16PM -0700, Khem Raj wrote:
> On Oct 31, 2015 3:15 PM, "Ed Bartosh" wrote:
> >
> > This upgrade should fix qemu build failure on Ubuntu 1.5.10
>
> Typo
Thanks. I'll fix it in v2.
>
> > caused by system pulseaudio requi
reference to
dbus_watch_get_enabled@LIBDBUS_1_3
Fixed by building qemu-native with the system dbus on Ubuntu 15.10
Note: This is a workaround. It must be removed when oe dbus is upgraded
to the version >= system dbus version (1.10.0 at the moment).
[YOCTO #8553]
Signed-off-by: Ed Bart
onnection. Some tests can be run using
serial console.
Added new parameter 'get_ip' to QemuRunner.start to make it possible
to skip getting pair of ip addresses from kernel command line. This
should allow oe-selftest to test images without modifying kernel
command line.
[YOCTO #8498]
ernel path.
Signed-off-by: Ed Bartosh
---
scripts/runqemu | 2 +-
scripts/runqemu-internal | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 4bb3bb6..0830901 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -454,7 +454,7
qemu hands with 'waiting for root device' message during the
boot of wic images if '-drive if=virtio' option is used.
Removed if=virtio from qemu command line for wic images. This
should fix above mentioned boot issue.
Signed-off-by: Ed Bartosh
---
scripts/runqemu-inte
-core/qemuRunner-wic-8498
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/oe-core/qemuRunner-wic-8498
Ed Bartosh (15):
runqemu: add support for wic images
runqemu: don't use virtio for wic images
runqemu: don't set KERNEL for wic images
runqemu: support path/to/-.wi
Added new parameter 'ssh' to targetcontrol 'start' method
to be able to test images without running ssh server.
[YOCTO #8498]
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/targetcontrol.py | 18 ++
meta/lib/oeqa/utils/commands.py | 4 ++--
2 files changed,
From: Ed Bartosh
Removed unused parameter 'test' from runqemu function.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/devtool.py | 2 +-
meta/lib/oeqa/selftest/imagefeatures.py | 6 +++---
meta/lib/oeqa/utils/commands.py | 2 +-
3 files changed, 5 insert
Added 'wic' to the list image types supported by targetcontrol.
This is a preparation for booting and testing wic images
with oe-selftest.
[YOCTO #8498]
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/targetcontrol.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Supported providing wic image path to runqemu:
runquemu path/to/-.wic
[YOCTO #8691]
Signed-off-by: Ed Bartosh
---
scripts/runqemu | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 0830901..48b7551 100755
--- a/scripts
Quemu should be able to run wic images this way:
runqemu wic
Tested with 'runqemu qemux86-64 wic-image-minimal wic'
Signed-off-by: Ed Bartosh
---
scripts/runqemu | 3 ++-
scripts/runqemu-internal | 16
2 files changed, 10 insertions(+), 9 deletion
Added test_qemu testcase to boot wic-image-minimal and test
that 2 partitions mentioned in .wks are mounted.
[YOCTO #8499]
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/meta/lib/oeqa/selftest/wic.py
Image should be build usual way, i.e. using bitbake .
Specifying do_mage_complete and do_rootfs_wicenv tasks should not
be needed anymore as those tasks should be run by bitbake for
every image.
Removed specifying do_mage_complete and do_rootfs_wicenv tasks
from bitbake calls.
Signed-off-by: Ed
Used --uuid option to generate PARTUUID for root partion and
gpt partition type. As this image is used in runtime testing
under qemu it makes sense to ensure that this way of specifying
root partition works.
Signed-off-by: Ed Bartosh
---
meta-selftest/recipes-test/images/wic-image-minimal.wks
With below list of changes wic-image-minimal can be boot by qemu:
- Changed device name sda -> hda.
- Added root=/dev/hda2 to the kernel command line.
- Changed mount point for core partition to /mnt to have it
mounted on boot time.
Signed-off-by: Ed Bartosh
---
meta-selft
Processing of this option was lost during recent change of
wks parsting. It was discovered during the work on booting
wic images under qemu. Now, when -use-uuid is fixed it's
possible to specify root partition by partition uuid.
This will be done in the following commit.
Signed-off-by: Ed Ba
(redefined-builtin)
W:175, 8: Redefining built-in 'vars' (redefined-builtin)
W: 27, 0: Unused import sys (unused-import)
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/meta/lib/oeqa/selfte
Replaced wic.bz2 -> wic in IMAGE_FSTYPES.
wic-image-minimal is going to be booted in qemu and tested.
As runqemu doesn't support compressed images this recipe needs
to produce raw wic image.
Signed-off-by: Ed Bartosh
---
meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 +-
On Tue, Feb 02, 2016 at 02:50:19PM +, Richard Purdie wrote:
> On Tue, 2016-02-02 at 09:27 +0200, Ed Bartosh wrote:
> > qemu hands with 'waiting for root device' message during the
> > boot of wic images if '-drive if=virtio' option is used.
> >
> &g
On Tue, Feb 02, 2016 at 03:57:08PM +, Richard Purdie wrote:
> On Tue, 2016-02-02 at 14:55 +0200, Ed Bartosh wrote:
> > On Tue, Feb 02, 2016 at 02:50:19PM +, Richard Purdie wrote:
> > > On Tue, 2016-02-02 at 09:27 +0200, Ed Bartosh wrote:
> > > > qemu hands
(2016-02-01 17:16:05 +)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib ed/oe-core/qemuRunner-wic-8498
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/oe-core/qemuRunner-wic-8498
Ed Bartosh (14):
runqemu: add support for wic images
runqe
Quemu should be able to run wic images this way:
runqemu wic
Tested with 'runqemu qemux86-64 wic-image-minimal wic'
Signed-off-by: Ed Bartosh
---
scripts/runqemu | 3 ++-
scripts/runqemu-internal | 16
2 files changed, 10 insertions(+), 9 deletion
Supported providing wic image path to runqemu:
runquemu path/to/-.wic
[YOCTO #8691]
Signed-off-by: Ed Bartosh
---
scripts/runqemu | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 0830901..48b7551 100755
--- a/scripts
Added new parameter 'ssh' to targetcontrol 'start' method
to be able to test images without running ssh server.
[YOCTO #8498]
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/targetcontrol.py | 18 ++
meta/lib/oeqa/utils/commands.py | 4 ++--
2 files changed,
onnection. Some tests can be run using
serial console.
Added new parameter 'get_ip' to QemuRunner.start to make it possible
to skip getting pair of ip addresses from kernel command line. This
should allow oe-selftest to test images without modifying kernel
command line.
[YOCTO #8498]
Image should be build usual way, i.e. using bitbake .
Specifying do_mage_complete and do_rootfs_wicenv tasks should not
be needed anymore as those tasks should be run by bitbake for
every image.
Removed specifying do_mage_complete and do_rootfs_wicenv tasks
from bitbake calls.
Signed-off-by: Ed
701 - 800 of 1334 matches
Mail list logo
