Also, signed off by Paul Eggleton: paul.eggle...@microsoft.com
________________________________
From: maanyagoe...@linux.microsoft.com <maanyagoe...@linux.microsoft.com>
Sent: Tuesday, January 17, 2023 10:01 AM
To: openembedded-core@lists.openembedded.org
<openembedded-core@lists.openembedded.org>
Cc: Maanya Goenka <maanyagoe...@linux.microsoft.com>; Maanya Goenka
<maanyagoe...@microsoft.com>
Subject: [PATCH] create-spdx: fix config build by adding dependency to enable
reruns
From: Maanya Goenka <maanyagoe...@linux.microsoft.com>
The issue encountered is about local stos builds failing (when these builds are
preceded by a local SoC OS or MOS build). Essentially, the failure is seen when
building two different configs with shared state, one where gcc-cross-<arch>
has a dependency
and one where it doesn't (specifically, one where the abicheck class in
meta-binaryaudit
is inherited and one where it isn't). Hence, the task signatures change but a
rerun of those said tasks
does not occur. The result is that when the config with the dependency is built
and then the one without
is built, due to incorrect dependencies, the SPDX manifest creation stage
errors out.
create-spdx relies on BB_TASKDEPDATA to get dependencies and then adds that
variable to
vardepsexclude. A change in dependencies therefore, does not result in a
re-execution of the tasks. This commit adds an explicit dependency on DEPENDS
which influences
BB_TASKDEPDATA and triggers reruns for new config builds having different
dependencies.
Signed-off-by: Maanya Goenka <maanyagoe...@microsoft.com>
---
meta/classes/create-spdx-2.2.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/create-spdx-2.2.bbclass
b/meta/classes/create-spdx-2.2.bbclass
index f0513af..e2553b4 100644
--- a/meta/classes/create-spdx-2.2.bbclass
+++ b/meta/classes/create-spdx-2.2.bbclass
@@ -377,7 +377,7 @@ def collect_dep_recipes(d, doc, spdx_recipe):
return dep_recipes
collect_dep_recipes[vardepsexclude] += "BB_TASKDEPDATA"
-
+collect_dep_recipes[vardeps] += "DEPENDS"
def collect_dep_sources(d, dep_recipes):
import oe.sbom
--
1.8.3.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176060):
https://lists.openembedded.org/g/openembedded-core/message/176060
Mute This Topic: https://lists.openembedded.org/mt/96336314/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
