Re: [OE-core] [PATCH] perl: fix startperl configuration option for perl-native
Hi Peter,
The motivation for the patch is just using a correct value for "startperl"
configuration when build perl-native.
Without the patch, this configuration option is set to a non existent path.
When I fixed "startperl", tools like "pod2man" stopped working as the
"do_install_append_class-native()" function expected the non existent path
on the shebang string (#! ...).
So I also had to change the "do_install_append_class()".
If you look at function "cpan_do_install()" in meta/classes/cpan.bbclass,
you see that both functions now use same pattern for shebang string
substitution.
I can't understand why the pod2man in your build is still using the non
existent path on the shebang string.
Would you mind to execute the following steps and send me the results? That
may help me understand a bit better.
bitbake perl-native -c compile -f
head -1 $(find */work/*/perl-native/ -name pod2man)
grep "startperl=" */work/*/perl-native/*/perl*/lib/Config_heavy.pl
*/work/*/perl-native/*/perl*/config.log
You may partially replace the complete path by some "..." as you did before.
I hope we can find a solution to replace the patch with another one that
fixes the "startperl" configuration without breaking your build.
Regards,
Paulo
On Fri, Apr 30, 2021 at 5:42 PM Peter Kjellerstedt <
peter.kjellerst...@axis.com> wrote:
> Well, it did break our builds. I now get the following error when building
> a native recipe that inherits perlnative and tries to run pod2man:
>
>
>
> | /bin/sh: /home/pkj/…/recipe-sysroot-native/usr/bin/pod2man:
> /home/pkj/…/recipe-sysroot-native/usr/bin/per: bad interpreter: No such
> file or directory
>
>
>
> This is because the first two lines of the pod2man script now looks like
>
>
>
> #!/home/pkj/…/recipe-sysroot-native/usr/bin/perl
>
> eval 'exec /home/pkj/…/recipe-sysroot-native/usr/bin/perl -S $0
> ${1+"$@"}'
>
>
>
> instead of the previous:
>
>
>
> #!/usr/bin/env nativeperl
>
> eval 'exec /usr/bin/env nativeperl -S $0 ${1+"$@"}'
>
>
>
> I.e., the sed command in perl’s do_install_append_class-native() does not
> seem to have done anything, which is because there is no
> “perl-native.*/perl" in the path to match (as can be seen above), it is
> just “perl”, which is what the old code was looking for.
>
>
>
> [ In the above examples, I have replaced a longish part of the path with …
> to protect the innocent. ]
>
>
>
> //Peter
>
>
>
> *From:* openembedded-core@lists.openembedded.org <
> openembedded-core@lists.openembedded.org> *On Behalf Of *Paulo Cesar
> Zaneti
> *Sent:* den 19 april 2021 16:13
> *To:* openembedded-core@lists.openembedded.org
> *Subject:* Re: [OE-core] [PATCH] perl: fix startperl configuration option
> for perl-native
>
>
>
> I just re-send the patch with additional fix for the build failure.
>
> I think the basic problem was an inconsistency in the way perl recipe and
> cpan.bbclass convert the absolute perl path to env path.
> Version 2 of the patch tries to use same cpan.bbclass approach on the perl
> recipe.
>
> Before submitting I just ran "bitbake -k world". I hope it doesn't break
> the build again.
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151224):
https://lists.openembedded.org/g/openembedded-core/message/151224
Mute This Topic: https://lists.openembedded.org/mt/82154526/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] perl: fix startperl configuration option for perl-native
Yes, I agree to revert until we find out a solution for everyone needs.
Should I send a patch reverting it ?
On Mon, May 3, 2021 at 4:56 PM Otavio Salvador <
otavio.salva...@ossystems.com.br> wrote:
> Hello,
>
> Couldn't the OE-Core:f2d1523b19cb066a4a06609f036822fe4a8b43f0 to be
> reverted in meanwhile?
>
> Em sex., 30 de abr. de 2021 às 17:42, Peter Kjellerstedt <
> peter.kjellerst...@axis.com> escreveu:
>
>> Well, it did break our builds. I now get the following error when
>> building a native recipe that inherits perlnative and tries to run pod2man:
>>
>>
>>
>> | /bin/sh: /home/pkj/…/recipe-sysroot-native/usr/bin/pod2man:
>> /home/pkj/…/recipe-sysroot-native/usr/bin/per: bad interpreter: No such
>> file or directory
>>
>>
>>
>> This is because the first two lines of the pod2man script now looks like
>>
>>
>>
>> #!/home/pkj/…/recipe-sysroot-native/usr/bin/perl
>>
>> eval 'exec /home/pkj/…/recipe-sysroot-native/usr/bin/perl -S $0
>> ${1+"$@"}'
>>
>>
>>
>> instead of the previous:
>>
>>
>>
>> #!/usr/bin/env nativeperl
>>
>> eval 'exec /usr/bin/env nativeperl -S $0 ${1+"$@"}'
>>
>>
>>
>> I.e., the sed command in perl’s do_install_append_class-native() does not
>> seem to have done anything, which is because there is no
>> “perl-native.*/perl" in the path to match (as can be seen above), it is
>> just “perl”, which is what the old code was looking for.
>>
>>
>>
>> [ In the above examples, I have replaced a longish part of the path with
>> … to protect the innocent. ]
>>
>>
>>
>> //Peter
>>
>>
>>
>> *From:* openembedded-core@lists.openembedded.org <
>> openembedded-core@lists.openembedded.org> *On Behalf Of *Paulo Cesar
>> Zaneti
>> *Sent:* den 19 april 2021 16:13
>> *To:* openembedded-core@lists.openembedded.org
>> *Subject:* Re: [OE-core] [PATCH] perl: fix startperl configuration
>> option for perl-native
>>
>>
>>
>> I just re-send the patch with additional fix for the build failure.
>>
>> I think the basic problem was an inconsistency in the way perl recipe and
>> cpan.bbclass convert the absolute perl path to env path.
>> Version 2 of the patch tries to use same cpan.bbclass approach on the
>> perl recipe.
>>
>> Before submitting I just ran "bitbake -k world". I hope it doesn't break
>> the build again.
>>
>>
>>
>>
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.brhttp://code.ossystems.com.br
> Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151223):
https://lists.openembedded.org/g/openembedded-core/message/151223
Mute This Topic: https://lists.openembedded.org/mt/82154526/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] perl: fix startperl configuration option for perl-native
I just re-send the patch with additional fix for the build failure. I think the basic problem was an inconsistency in the way perl recipe and cpan.bbclass convert the absolute perl path to env path. Version 2 of the patch tries to use same cpan.bbclass approach on the perl recipe. Before submitting I just ran "bitbake -k world". I hope it doesn't break the build again. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#150677): https://lists.openembedded.org/g/openembedded-core/message/150677 Mute This Topic: https://lists.openembedded.org/mt/82154526/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH v2] perl: fix startperl configuration option for perl-native
Unlike vanilla Perl "Configure" script, perl-cross "configure" does not
derive "startperl" from "bin". It instead derives from "perlpath".
This patch aims to fix "startperl" configuration option for perl-native by
correctly setting "perlpath" on perl-cross "configure" script.
It also changes do_install_append_class-native task to comply with
cpan_do_install task.
Signed-off-by: Paulo Cesar Zaneti
---
meta/recipes-devtools/perl/perl_5.32.1.bb | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-devtools/perl/perl_5.32.1.bb
b/meta/recipes-devtools/perl/perl_5.32.1.bb
index b28040c7fb..73d66f6656 100644
--- a/meta/recipes-devtools/perl/perl_5.32.1.bb
+++ b/meta/recipes-devtools/perl/perl_5.32.1.bb
@@ -95,6 +95,7 @@ do_configure_class-nativesdk() {
do_configure_class-native() {
./configure --prefix=${prefix} \
-Dbin=${bindir}/perl-native \
+-Dperlpath=${bindir}/perl-native/perl \
-Duseshrplib \
-Dsoname=libperl.so.5 \
-Dvendorprefix=${prefix} \
@@ -171,8 +172,8 @@ do_install_append_class-native () {
create_wrapper ${D}${bindir}/perl-native/perl
PERL5LIB='$PERL5LIB:${STAGING_LIBDIR}/perl5/site_perl/${PV}:${STAGING_LIBDIR}/perl5/vendor_perl/${PV}:${STAGING_LIBDIR}/perl5/${PV}'
# Use /usr/bin/env nativeperl for the perl script.
-for f in `grep -Il '#! *${bindir}/perl' ${D}/${bindir}/*`; do
-sed -i -e 's|${bindir}/perl|/usr/bin/env nativeperl|' $f
+for f in `grep -Il '#! *${bindir}/perl-native.*/perl' ${D}/${bindir}/*`; do
+sed -i -e 's|${bindir}/perl-native.*/perl|/usr/bin/env
nativeperl|' $f
done
}
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#150676):
https://lists.openembedded.org/g/openembedded-core/message/150676
Mute This Topic: https://lists.openembedded.org/mt/82209004/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] perl: fix startperl configuration option for perl-native
Unlike vanilla Perl "Configure" script, perl-cross "configure" does not
derive "startperl" from "bin". It instead derives from "perlpath".
This patch aims to fix "startperl" configuration option for perl-native by
correctly setting "perlpath" on perl-cross "configure" script.
Signed-off-by: Paulo Cesar Zaneti
---
meta/recipes-devtools/perl/perl_5.32.1.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-devtools/perl/perl_5.32.1.bb
b/meta/recipes-devtools/perl/perl_5.32.1.bb
index b28040c7fb..82c2922066 100644
--- a/meta/recipes-devtools/perl/perl_5.32.1.bb
+++ b/meta/recipes-devtools/perl/perl_5.32.1.bb
@@ -95,6 +95,7 @@ do_configure_class-nativesdk() {
do_configure_class-native() {
./configure --prefix=${prefix} \
-Dbin=${bindir}/perl-native \
+-Dperlpath=${bindir}/perl-native/perl \
-Duseshrplib \
-Dsoname=libperl.so.5 \
-Dvendorprefix=${prefix} \
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#150609):
https://lists.openembedded.org/g/openembedded-core/message/150609
Mute This Topic: https://lists.openembedded.org/mt/82154526/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
