[OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
From: Simon Busch morp...@gravedo.de
In most cases we don't need tslib in std. configuration as touchscreen access
in most
devices today is done with linux input interface. If some specific machine has
a need for
tslib support it should add the dependency in it's machine layer again and
modify the
profile script accordingly.
Signed-off-by: Simon Busch morp...@gravedo.de
Signed-off-by: Martin Jansa martin.ja...@gmail.com
---
meta/recipes-qt/qt4/files/qte.sh |2 +-
meta/recipes-qt/qt4/qt4-embedded.inc |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-qt/qt4/files/qte.sh b/meta/recipes-qt/qt4/files/qte.sh
index 21d6ecb..bb8dfae 100644
--- a/meta/recipes-qt/qt4/files/qte.sh
+++ b/meta/recipes-qt/qt4/files/qte.sh
@@ -2,6 +2,6 @@
if [ -e /dev/input/touchscreen0 ]
then
-QWS_MOUSE_PROTO=Tslib:/dev/input/touchscreen0
+QWS_MOUSE_PROTO=LinuxInput:/dev/input/touchscreen0
export QWS_MOUSE_PROTO
fi
diff --git a/meta/recipes-qt/qt4/qt4-embedded.inc
b/meta/recipes-qt/qt4/qt4-embedded.inc
index bee7345..179de87 100644
--- a/meta/recipes-qt/qt4/qt4-embedded.inc
+++ b/meta/recipes-qt/qt4/qt4-embedded.inc
@@ -2,8 +2,8 @@ DESCRIPTION = Qt is a versatile cross-platform application
framework -- this is
SECTION = libs
LICENSE = LGPLv2.1 | GPLv3
HOMEPAGE = http://qt.nokia.com;
-DEPENDS += directfb tslib
-INC_PR = r36
+DEPENDS += directfb
+INC_PR = r37
QT_BASE_NAME ?= qt4-embedded
QT_BASE_LIB ?= libqt-embedded
@@ -15,7 +15,7 @@ QT_CONFIG_FLAGS += \
-embedded ${QT_ARCH} \
-qtlibinfix ${QT_LIBINFIX} \
-plugin-gfx-transformed -plugin-gfx-qvfb -plugin-gfx-vnc
-plugin-gfx-directfb \
--plugin-mouse-tslib -qt-mouse-pc -qt-mouse-qvfb -qt-mouse-linuxinput \
+-qt-mouse-pc -qt-mouse-qvfb -qt-mouse-linuxinput \
-qt-kbd-tty \
-DQT_KEYPAD_NAVIGATION \
--
1.7.7
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
Hi, Le 12/10/2011 09:45, Martin Jansa a écrit : From: Simon Buschmorp...@gravedo.de In most cases we don't need tslib in std. configuration as touchscreen access in most devices today is done with linux input interface. If some specific machine has a need for tslib support it should add the dependency in it's machine layer again and modify the profile script accordingly. When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ? Eric ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
Op 12 okt. 2011, om 10:02 heeft Eric Bénard het volgende geschreven: Hi, Le 12/10/2011 09:45, Martin Jansa a écrit : From: Simon Buschmorp...@gravedo.de In most cases we don't need tslib in std. configuration as touchscreen access in most devices today is done with linux input interface. If some specific machine has a need for tslib support it should add the dependency in it's machine layer again and modify the profile script accordingly. When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ? We ran into this at work and like Eric, I'm curious how calibration (and e.g. dejitter) works in the linux-input world combined with qt/e. regards, Koen ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
Op 12 okt. 2011 om 20:10 heeft Simon Busch morp...@gravedo.de het volgende geschreven: On 12.10.2011 10:02, Eric Bénard wrote: Hi, Le 12/10/2011 09:45, Martin Jansa a écrit : From: Simon Buschmorp...@gravedo.de In most cases we don't need tslib in std. configuration as touchscreen access in most devices today is done with linux input interface. If some specific machine has a need for tslib support it should add the dependency in it's machine layer again and modify the profile script accordingly. When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ? Thats up to the environment you are using qt4-embedded in. In my case the setup is a little bit more complicated. We're using tslib but not directly in qt4-embedded (we can get rid of tslib completely but time is missing). I removed the dependency from qt4-embedded as qt4-embedded in oe-core should be the general thing used in all environments and therefore should be only a minimal setup with minimal dependencies. No, it should work in most cases, breaking qt:e like is not acceptable. If someone needs tslib for qt4-embedded for his machine layer he should include tslib support in the machine layer itself. regards, Simon -- Simon Busch - http://mm.gravedo.de/blog/ ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
On 12.10.2011 20:14, Koen Kooi wrote: Op 12 okt. 2011 om 20:10 heeft Simon Busch morp...@gravedo.de het volgende geschreven: On 12.10.2011 10:02, Eric Bénard wrote: Hi, Le 12/10/2011 09:45, Martin Jansa a écrit : From: Simon Buschmorp...@gravedo.de In most cases we don't need tslib in std. configuration as touchscreen access in most devices today is done with linux input interface. If some specific machine has a need for tslib support it should add the dependency in it's machine layer again and modify the profile script accordingly. When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ? Thats up to the environment you are using qt4-embedded in. In my case the setup is a little bit more complicated. We're using tslib but not directly in qt4-embedded (we can get rid of tslib completely but time is missing). I removed the dependency from qt4-embedded as qt4-embedded in oe-core should be the general thing used in all environments and therefore should be only a minimal setup with minimal dependencies. No, it should work in most cases, breaking qt:e like is not acceptable. What is breaking qt:e in this case? For me it's just a feature reduction and not a break (as qt:e still works fine with the linux input interface). -- Simon Busch - http://mm.gravedo.de/blog/ ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
On Wed, Oct 12, 2011 at 2:20 AM, Koen Kooi k...@dominion.thruhere.net wrote: Op 12 okt. 2011, om 10:02 heeft Eric Bénard het volgende geschreven: Hi, Le 12/10/2011 09:45, Martin Jansa a écrit : From: Simon Buschmorp...@gravedo.de In most cases we don't need tslib in std. configuration as touchscreen access in most devices today is done with linux input interface. If some specific machine has a need for tslib support it should add the dependency in it's machine layer again and modify the profile script accordingly. When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ? We ran into this at work and like Eric, I'm curious how calibration (and e.g. dejitter) works in the linux-input world combined with qt/e. Not directly applicable, but I keep meaning to take a look at http://atrey.karlin.mff.cuni.cz/~metan/evfilter/ - it seems quite interesting. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
Op 12 okt. 2011, om 20:34 heeft Simon Busch het volgende geschreven: On 12.10.2011 20:14, Koen Kooi wrote: Op 12 okt. 2011 om 20:10 heeft Simon Busch morp...@gravedo.de het volgende geschreven: On 12.10.2011 10:02, Eric Bénard wrote: Hi, Le 12/10/2011 09:45, Martin Jansa a écrit : From: Simon Buschmorp...@gravedo.de In most cases we don't need tslib in std. configuration as touchscreen access in most devices today is done with linux input interface. If some specific machine has a need for tslib support it should add the dependency in it's machine layer again and modify the profile script accordingly. When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ? Thats up to the environment you are using qt4-embedded in. In my case the setup is a little bit more complicated. We're using tslib but not directly in qt4-embedded (we can get rid of tslib completely but time is missing). I removed the dependency from qt4-embedded as qt4-embedded in oe-core should be the general thing used in all environments and therefore should be only a minimal setup with minimal dependencies. No, it should work in most cases, breaking qt:e like is not acceptable. What is breaking qt:e in this case? For me it's just a feature reduction and not a break (as qt:e still works fine with the linux input interface). When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction. ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
Hi, Le 12/10/2011 20:10, Simon Busch a écrit : On 12.10.2011 10:02, Eric Bénard wrote: Le 12/10/2011 09:45, Martin Jansa a écrit : From: Simon Buschmorp...@gravedo.de In most cases we don't need tslib in std. configuration as touchscreen access in most devices today is done with linux input interface. If some specific machine has a need for tslib support it should add the dependency in it's machine layer again and modify the profile script accordingly. When using a resistive touchscreen, tslib is a common solution to handle calibration and raw value processing : do you think this is a good thing to remove this ? Thats up to the environment you are using qt4-embedded in. In my case the setup is a little bit more complicated. We're using tslib but not directly in qt4-embedded (we can get rid of tslib completely but time is missing). I removed the dependency from qt4-embedded as qt4-embedded in oe-core should be the general thing used in all environments and therefore should be only a minimal setup with minimal dependencies. If someone needs tslib for qt4-embedded for his machine layer he should include tslib support in the machine layer itself. removing tslib plugin in qt4e seems not the good solution as this plugin can be built but not installed by default. In my opinion that's only the qte.sh script which could be more generic and maybe could be in its own configuration package so that several machines can share the same qt4e packages (picking the plugins they need) and have their own qte-config (for example) package. Else, why don't you akso remove plugin-gfx-transformed which is not used be many machines, or plugin-gfx-vnc or plugin-gfx-directfb which is only used on machine needing directfb or plugin-gfx-qvfb as real machine don't need a virtual framebuffer or even qt-mouse-pc as you may think that pc with mouses don't need qtembedded ... in the end we may also notice that basic platforms can use qt without a display, so why not removing graphic support at all to make the think even more generic and reduce the number of dependencies ;-) Eric ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
On 12.10.2011 21:09, Koen Kooi wrote: What is breaking qt:e in this case? For me it's just a feature reduction and not a break (as qt:e still works fine with the linux input interface). When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction. You're talking here about one case where tslib is needed to get a working touchscreen. But there are even cases where tslib is not needed to get a working touchscreen. qt:e does not strongly depends on tslib, it can work without. So if you need it you should add it to your machine layer as it is really machine specific if you need tslib or not. regards, Simon -- Simon Busch - http://mm.gravedo.de/blog/ ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
On 12.10.2011 21:24, Simon Busch wrote: On 12.10.2011 21:09, Koen Kooi wrote: What is breaking qt:e in this case? For me it's just a feature reduction and not a break (as qt:e still works fine with the linux input interface). When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction. You're talking here about one case where tslib is needed to get a working touchscreen. But there are even cases where tslib is not needed to get a working touchscreen. qt:e does not strongly depends on tslib, it can work without. So if you need it you should add it to your machine layer as it is really machine specific if you need tslib or not. Eric brings it to the point, only resetting the qte.sh script to a default one which uses a linux input even node should be enough. -- Simon Busch - http://mm.gravedo.de/blog/ ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
On Wed, Oct 12, 2011 at 12:24 PM, Simon Busch morp...@gravedo.de wrote: On 12.10.2011 21:09, Koen Kooi wrote: What is breaking qt:e in this case? For me it's just a feature reduction and not a break (as qt:e still works fine with the linux input interface). When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction. You're talking here about one case where tslib is needed to get a working touchscreen. But there are even cases where tslib is not needed to get a working touchscreen. The base should be the bare min necessary to function in the common case, in my opinion. Touchscreens that don't require calibration are few and far between, so making the majority of machines with touchscreens have to override it seems far from ideal. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
On 12.10.2011 21:29, Simon Busch wrote: On 12.10.2011 21:24, Simon Busch wrote: On 12.10.2011 21:09, Koen Kooi wrote: What is breaking qt:e in this case? For me it's just a feature reduction and not a break (as qt:e still works fine with the linux input interface). When your TS is suddenly uncalibrated and jittery, it's a breakage, not a feature reduction. You're talking here about one case where tslib is needed to get a working touchscreen. But there are even cases where tslib is not needed to get a working touchscreen. qt:e does not strongly depends on tslib, it can work without. So if you need it you should add it to your machine layer as it is really machine specific if you need tslib or not. Eric brings it to the point, only resetting the qte.sh script to a default one which uses a linux input even node should be enough. Sorry for my little generic trip ... :) I will provide another patch in the following days which just makes qte.sh use of a std. linux input dev node instead of a tslib one if nobody has any objections against this. regards, Simon -- Simon Busch - http://mm.gravedo.de/blog/ ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core 1/4] qt4-embedded: remove dependency on tslib and use std. linux input
Hi, Le 12/10/2011 21:52, Simon Busch a écrit : I will provide another patch in the following days which just makes qte.sh use of a std. linux input dev node instead of a tslib one if nobody has any objections against this. maybe moving qt4-embedded-conf in its own recipe would be better : that would allow qte.sh customization without having to rebuild qt4-embedded. Then you could have qte.sh with linux input in your machine's overlay and could keep the default qte.sh as it actually is in oe-core. Also, does defaulting to linux input dev works in qemu machines (for example with qt4e-demo-image ? Eric ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
