Re: [oe-core][PATCH 1/1] blktrace: add rdepends

2021-08-16 Thread Joe Slater 
I will get rid of the RDEPENDS.   Joe

> -Original Message-
> From: Alexandre Belloni 
> Sent: Saturday, August 14, 2021 2:39 AM
> To: Slater, Joseph 
> Cc: openembedded-core@lists.openembedded.org; MacLeod, Randy
> 
> Subject: Re: [oe-core][PATCH 1/1] blktrace: add rdepends
> 
> Hello,
> 
> On 13/08/2021 13:24:16-0700, Joe Slater wrote:
> > bno_plot.py uses gnuplot.  Also change shebangs to
> > python3 because we do not support python2.
> >
> > Signed-off-by: Joe Slater 
> > ---
> >  meta/recipes-kernel/blktrace/blktrace_git.bb  |  6 +++-
> >  .../blktrace/files/python3-shebangs.patch | 30 +++
> >  2 files changed, 35 insertions(+), 1 deletion(-)  create mode 100644
> > meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> >
> > diff --git a/meta/recipes-kernel/blktrace/blktrace_git.bb
> > b/meta/recipes-kernel/blktrace/blktrace_git.bb
> > index d00b1bd0be..36ce282481 100644
> > --- a/meta/recipes-kernel/blktrace/blktrace_git.bb
> > +++ b/meta/recipes-kernel/blktrace/blktrace_git.bb
> > @@ -10,11 +10,15 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
> >
> >  DEPENDS = "libaio"
> >
> > +RDEPENDS:${PN} += "gnuplot"
> > +
> 
> This breaks many builds on the autobuilders with:
> 
> stdio: ERROR: Nothing RPROVIDES 'gnuplot' (but /home/pokybuild/yocto-
> worker/genericx86-64/build/meta/recipes-kernel/blktrace/blktrace_git.bb
> RDEPENDS on or otherwise requires it)
> stdio: ERROR: Nothing RPROVIDES 'blktrace-dev' (but /home/pokybuild/yocto-
> worker/genericx86-64/build/meta/recipes-kernel/blktrace/blktrace_git.bb
> RDEPENDS on or otherwise requires it)
> 
> because gnuplot is part of meta-oe
> 
> >  SRCREV = "366d30b9cdb20345c5d064af850d686da79b89eb"
> >
> >  PV = "1.3.0+git${SRCPV}"
> >
> > -SRC_URI = "git://git.kernel.dk/blktrace.git"
> > +SRC_URI = "git://git.kernel.dk/blktrace.git \
> > +   file://python3-shebangs.patch \
> > +  "
> >
> >  S = "${WORKDIR}/git"
> >
> > diff --git a/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> > b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> > new file mode 100644
> > index 00..70a35c2c3a
> > --- /dev/null
> > +++ b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> > @@ -0,0 +1,30 @@
> > +blktrace: Use python3 shebangs
> > +
> > +blktrace can use either python2 or python3, but we really want
> > +python3, so modify the shebangs.
> > +
> > +Upstream-Status: pending
> > +
> > +Signed-off-by: Joe Slater  > +
> > +
> > +diff --git a/btt/bno_plot.py b/btt/bno_plot.py index 3aa4e19..d7d7159
> > +100644
> > +--- a/btt/bno_plot.py
> >  b/btt/bno_plot.py
> > +@@ -1,4 +1,4 @@
> > +-#! /usr/bin/env python
> > ++#! /usr/bin/env python3
> > + #
> > + # btt blkno plotting interface
> > + #
> > +diff --git a/btt/btt_plot.py b/btt/btt_plot.py index 40bc71f..8620d31
> > +100755
> > +--- a/btt/btt_plot.py
> >  b/btt/btt_plot.py
> > +@@ -1,4 +1,4 @@
> > +-#! /usr/bin/env python
> > ++#! /usr/bin/env python3
> > + #
> > + # btt_plot.py: Generate matplotlib plots for BTT generate data files
> > + #
> > --
> > 2.25.1
> >
> 
> >
> > 
> >
> 
> 
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154841): 
https://lists.openembedded.org/g/openembedded-core/message/154841
Mute This Topic: https://lists.openembedded.org/mt/84872571/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [oe-core][PATCH 1/1] blktrace: add rdepends

2021-08-16 Thread Joe Slater 
I wanted to make /usr/bin/python supplied by python3 but have that overridden 
by a higher priority version in python2, but meta-python2 wouldn't go for it.  
Without that, any alternative python3 supplies would replaced their version.

Joe

> -Original Message-
> From: Khem Raj 
> Sent: Saturday, August 14, 2021 6:34 PM
> To: MacLeod, Randy ; Slater, Joseph
> ; openembedded-core@lists.openembedded.org
> Subject: Re: [oe-core][PATCH 1/1] blktrace: add rdepends
> 
> 
> 
> On 8/13/21 4:34 PM, Randy MacLeod wrote:
> > On 2021-08-13 4:24 p.m., Joe Slater wrote:
> >> bno_plot.py uses gnuplot.  Also change shebangs to
> >> python3 because we do not support python2.
> >
> > We need to get agreement about what 'python' is.
> > That's not something i follow and it's already late on Friday so I'm
> > CCing Trevor, Mr meta-python and pointing you to:
> >
> > https://www.python.org/dev/peps/pep-0394/
> >
> > which from a brief review seems to say that it's up to the
> > distribution! Fun!!
> >
> >
> > My preference without knowing what other distros have done is to have
> > the build system make a soft link:
> >    python -> python3
> >
> 
> Its better to be explicit, making softlink will silently try to run python 
> scripts
> which assume python = python2 and do unexpected things
> 
> 
> >
> >>
> >> Signed-off-by: Joe Slater 
> >> ---
> >>   meta/recipes-kernel/blktrace/blktrace_git.bb  |  6 +++-
> >>   .../blktrace/files/python3-shebangs.patch | 30
> >> +++
> >>   2 files changed, 35 insertions(+), 1 deletion(-)
> >>   create mode 100644
> >> meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> >>
> >> diff --git a/meta/recipes-kernel/blktrace/blktrace_git.bb
> >> b/meta/recipes-kernel/blktrace/blktrace_git.bb
> >> index d00b1bd0be..36ce282481 100644
> >> --- a/meta/recipes-kernel/blktrace/blktrace_git.bb
> >> +++ b/meta/recipes-kernel/blktrace/blktrace_git.bb
> >> @@ -10,11 +10,15 @@ LIC_FILES_CHKSUM =
> >> "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
> >>   DEPENDS = "libaio"
> >> +RDEPENDS:${PN} += "gnuplot"
> >
> > As the DESCRIPTION says:
> >
> > There are three major components:
> >    a kernel component,
> >    a utility to record the i/o trace information for
> >      the kernel to user space,
> > and
> >    utilities to analyse and view the trace information.
> >
> > so shouldn't we split the userspace part up so that the utilities are
> > packaged separately and people who want to collect data on target and
> > analyze it elsewhere don't pull in gnuplot and maybe more?
> >
> >
> >
> > ../Randy
> >
> >> +
> >>   SRCREV = "366d30b9cdb20345c5d064af850d686da79b89eb"
> >>   PV = "1.3.0+git${SRCPV}"
> >> -SRC_URI = "git://git.kernel.dk/blktrace.git"
> >> +SRC_URI = "git://git.kernel.dk/blktrace.git \
> >> +   file://python3-shebangs.patch \
> >> +  "
> >>   S = "${WORKDIR}/git"
> >> diff --git
> >> a/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> >> b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> >> new file mode 100644
> >> index 00..70a35c2c3a
> >> --- /dev/null
> >> +++ b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> >> @@ -0,0 +1,30 @@
> >> +blktrace: Use python3 shebangs
> >> +
> >> +blktrace can use either python2 or python3, but we really want
> >> +python3, so modify the shebangs.
> >> +
> >> +Upstream-Status: pending
> >> +
> >> +Signed-off-by: Joe Slater  >> +
> >> +
> >> +diff --git a/btt/bno_plot.py b/btt/bno_plot.py index
> >> +3aa4e19..d7d7159 100644
> >> +--- a/btt/bno_plot.py
> >>  b/btt/bno_plot.py
> >> +@@ -1,4 +1,4 @@
> >> +-#! /usr/bin/env python
> >> ++#! /usr/bin/env python3
> >> + #
> >> + # btt blkno plotting interface
> >> + #
> >> +diff --git a/btt/btt_plot.py b/btt/btt_plot.py index
> >> +40bc71f..8620d31 100755
> >> +--- a/btt/btt_plot.py
> >>  b/btt/btt_plot.py
> >> +@@ -1,4 +1,4 @@
> >> +-#! /usr/bin/env python
> >> ++#! /usr/bin/env python3
> >> + #
> >> + # btt_plot.py: Generate matplotlib plots for BTT generate data
> >> + files #
> >>
> >
> >
> >
> >
> > 
> >

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154840): 
https://lists.openembedded.org/g/openembedded-core/message/154840
Mute This Topic: https://lists.openembedded.org/mt/84872571/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [oe-core][PATCH 1/1] blktrace: add rdepends

2021-08-14 Thread Khem Raj 



On 8/13/21 4:34 PM, Randy MacLeod wrote:

On 2021-08-13 4:24 p.m., Joe Slater wrote:

bno_plot.py uses gnuplot.  Also change shebangs to
python3 because we do not support python2.


We need to get agreement about what 'python' is.
That's not something i follow and it's already late on Friday so
I'm CCing Trevor, Mr meta-python and pointing you to:

https://www.python.org/dev/peps/pep-0394/

which from a brief review seems to say that it's up to the
distribution! Fun!!


My preference without knowing what other distros have done
is to have the build system make a soft link:
   python -> python3



Its better to be explicit, making softlink will silently try to run
python scripts which assume python = python2 and do unexpected things






Signed-off-by: Joe Slater 
---
  meta/recipes-kernel/blktrace/blktrace_git.bb  |  6 +++-
  .../blktrace/files/python3-shebangs.patch | 30 +++
  2 files changed, 35 insertions(+), 1 deletion(-)
  create mode 100644 
meta/recipes-kernel/blktrace/files/python3-shebangs.patch


diff --git a/meta/recipes-kernel/blktrace/blktrace_git.bb 
b/meta/recipes-kernel/blktrace/blktrace_git.bb

index d00b1bd0be..36ce282481 100644
--- a/meta/recipes-kernel/blktrace/blktrace_git.bb
+++ b/meta/recipes-kernel/blktrace/blktrace_git.bb
@@ -10,11 +10,15 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=393a5ca445f6965873eca0259a17f833"

  DEPENDS = "libaio"
+RDEPENDS:${PN} += "gnuplot"


As the DESCRIPTION says:

There are three major components:
   a kernel component,
   a utility to record the i/o trace information for
     the kernel to user space,
and
   utilities to analyse and view the trace information.

so shouldn't we split the userspace part up so that the utilities are
packaged separately and people who want to collect data on
target and analyze it elsewhere don't pull in gnuplot and maybe more?



../Randy


+
  SRCREV = "366d30b9cdb20345c5d064af850d686da79b89eb"
  PV = "1.3.0+git${SRCPV}"
-SRC_URI = "git://git.kernel.dk/blktrace.git"
+SRC_URI = "git://git.kernel.dk/blktrace.git \
+   file://python3-shebangs.patch \
+  "
  S = "${WORKDIR}/git"
diff --git a/meta/recipes-kernel/blktrace/files/python3-shebangs.patch 
b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch

new file mode 100644
index 00..70a35c2c3a
--- /dev/null
+++ b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
@@ -0,0 +1,30 @@
+blktrace: Use python3 shebangs
+
+blktrace can use either python2 or python3, but we really want
+python3, so modify the shebangs.
+
+Upstream-Status: pending
+
+Signed-off-by: Joe Slater 







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154791): 
https://lists.openembedded.org/g/openembedded-core/message/154791
Mute This Topic: https://lists.openembedded.org/mt/84872571/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [oe-core][PATCH 1/1] blktrace: add rdepends

2021-08-14 Thread Alexandre Belloni 
Hello,

On 13/08/2021 13:24:16-0700, Joe Slater wrote:
> bno_plot.py uses gnuplot.  Also change shebangs to
> python3 because we do not support python2.
> 
> Signed-off-by: Joe Slater 
> ---
>  meta/recipes-kernel/blktrace/blktrace_git.bb  |  6 +++-
>  .../blktrace/files/python3-shebangs.patch | 30 +++
>  2 files changed, 35 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> 
> diff --git a/meta/recipes-kernel/blktrace/blktrace_git.bb 
> b/meta/recipes-kernel/blktrace/blktrace_git.bb
> index d00b1bd0be..36ce282481 100644
> --- a/meta/recipes-kernel/blktrace/blktrace_git.bb
> +++ b/meta/recipes-kernel/blktrace/blktrace_git.bb
> @@ -10,11 +10,15 @@ LIC_FILES_CHKSUM = 
> "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
>  
>  DEPENDS = "libaio"
>  
> +RDEPENDS:${PN} += "gnuplot"
> +

This breaks many builds on the autobuilders with:

stdio: ERROR: Nothing RPROVIDES 'gnuplot' (but 
/home/pokybuild/yocto-worker/genericx86-64/build/meta/recipes-kernel/blktrace/blktrace_git.bb
 RDEPENDS on or otherwise requires it)
stdio: ERROR: Nothing RPROVIDES 'blktrace-dev' (but 
/home/pokybuild/yocto-worker/genericx86-64/build/meta/recipes-kernel/blktrace/blktrace_git.bb
 RDEPENDS on or otherwise requires it)

because gnuplot is part of meta-oe

>  SRCREV = "366d30b9cdb20345c5d064af850d686da79b89eb"
>  
>  PV = "1.3.0+git${SRCPV}"
>  
> -SRC_URI = "git://git.kernel.dk/blktrace.git"
> +SRC_URI = "git://git.kernel.dk/blktrace.git \
> +   file://python3-shebangs.patch \
> +  "
>  
>  S = "${WORKDIR}/git"
>  
> diff --git a/meta/recipes-kernel/blktrace/files/python3-shebangs.patch 
> b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> new file mode 100644
> index 00..70a35c2c3a
> --- /dev/null
> +++ b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> @@ -0,0 +1,30 @@
> +blktrace: Use python3 shebangs
> +
> +blktrace can use either python2 or python3, but we really want
> +python3, so modify the shebangs.
> +
> +Upstream-Status: pending
> +
> +Signed-off-by: Joe Slater  +
> +
> +diff --git a/btt/bno_plot.py b/btt/bno_plot.py
> +index 3aa4e19..d7d7159 100644
> +--- a/btt/bno_plot.py
>  b/btt/bno_plot.py
> +@@ -1,4 +1,4 @@
> +-#! /usr/bin/env python
> ++#! /usr/bin/env python3
> + #
> + # btt blkno plotting interface
> + #
> +diff --git a/btt/btt_plot.py b/btt/btt_plot.py
> +index 40bc71f..8620d31 100755
> +--- a/btt/btt_plot.py
>  b/btt/btt_plot.py
> +@@ -1,4 +1,4 @@
> +-#! /usr/bin/env python
> ++#! /usr/bin/env python3
> + #
> + # btt_plot.py: Generate matplotlib plots for BTT generate data files
> + #
> -- 
> 2.25.1
> 

> 
> 
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154789): 
https://lists.openembedded.org/g/openembedded-core/message/154789
Mute This Topic: https://lists.openembedded.org/mt/84872571/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [oe-core][PATCH 1/1] blktrace: add rdepends

2021-08-13 Thread Randy MacLeod 

On 2021-08-13 4:24 p.m., Joe Slater wrote:

bno_plot.py uses gnuplot.  Also change shebangs to
python3 because we do not support python2.


We need to get agreement about what 'python' is.
That's not something i follow and it's already late on Friday so
I'm CCing Trevor, Mr meta-python and pointing you to:

https://www.python.org/dev/peps/pep-0394/

which from a brief review seems to say that it's up to the
distribution! Fun!!


My preference without knowing what other distros have done
is to have the build system make a soft link:
  python -> python3




Signed-off-by: Joe Slater 
---
  meta/recipes-kernel/blktrace/blktrace_git.bb  |  6 +++-
  .../blktrace/files/python3-shebangs.patch | 30 +++
  2 files changed, 35 insertions(+), 1 deletion(-)
  create mode 100644 meta/recipes-kernel/blktrace/files/python3-shebangs.patch

diff --git a/meta/recipes-kernel/blktrace/blktrace_git.bb 
b/meta/recipes-kernel/blktrace/blktrace_git.bb
index d00b1bd0be..36ce282481 100644
--- a/meta/recipes-kernel/blktrace/blktrace_git.bb
+++ b/meta/recipes-kernel/blktrace/blktrace_git.bb
@@ -10,11 +10,15 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
  
  DEPENDS = "libaio"
  
+RDEPENDS:${PN} += "gnuplot"


As the DESCRIPTION says:

There are three major components:
  a kernel component,
  a utility to record the i/o trace information for
the kernel to user space,
and
  utilities to analyse and view the trace information.

so shouldn't we split the userspace part up so that the utilities are
packaged separately and people who want to collect data on
target and analyze it elsewhere don't pull in gnuplot and maybe more?



../Randy


+
  SRCREV = "366d30b9cdb20345c5d064af850d686da79b89eb"
  
  PV = "1.3.0+git${SRCPV}"
  
-SRC_URI = "git://git.kernel.dk/blktrace.git"

+SRC_URI = "git://git.kernel.dk/blktrace.git \
+   file://python3-shebangs.patch \
+  "
  
  S = "${WORKDIR}/git"
  
diff --git a/meta/recipes-kernel/blktrace/files/python3-shebangs.patch b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch

new file mode 100644
index 00..70a35c2c3a
--- /dev/null
+++ b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
@@ -0,0 +1,30 @@
+blktrace: Use python3 shebangs
+
+blktrace can use either python2 or python3, but we really want
+python3, so modify the shebangs.
+
+Upstream-Status: pending
+
+Signed-off-by: Joe Slater 


--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154787): 
https://lists.openembedded.org/g/openembedded-core/message/154787
Mute This Topic: https://lists.openembedded.org/mt/84872571/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[oe-core][PATCH 1/1] blktrace: add rdepends

2021-08-13 Thread Joe Slater 
bno_plot.py uses gnuplot.  Also change shebangs to
python3 because we do not support python2.

Signed-off-by: Joe Slater 
---
 meta/recipes-kernel/blktrace/blktrace_git.bb  |  6 +++-
 .../blktrace/files/python3-shebangs.patch | 30 +++
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-kernel/blktrace/files/python3-shebangs.patch

diff --git a/meta/recipes-kernel/blktrace/blktrace_git.bb 
b/meta/recipes-kernel/blktrace/blktrace_git.bb
index d00b1bd0be..36ce282481 100644
--- a/meta/recipes-kernel/blktrace/blktrace_git.bb
+++ b/meta/recipes-kernel/blktrace/blktrace_git.bb
@@ -10,11 +10,15 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
 
 DEPENDS = "libaio"
 
+RDEPENDS:${PN} += "gnuplot"
+
 SRCREV = "366d30b9cdb20345c5d064af850d686da79b89eb"
 
 PV = "1.3.0+git${SRCPV}"
 
-SRC_URI = "git://git.kernel.dk/blktrace.git"
+SRC_URI = "git://git.kernel.dk/blktrace.git \
+   file://python3-shebangs.patch \
+  "
 
 S = "${WORKDIR}/git"
 
diff --git a/meta/recipes-kernel/blktrace/files/python3-shebangs.patch 
b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
new file mode 100644
index 00..70a35c2c3a
--- /dev/null
+++ b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
@@ -0,0 +1,30 @@
+blktrace: Use python3 shebangs
+
+blktrace can use either python2 or python3, but we really want
+python3, so modify the shebangs.
+
+Upstream-Status: pending
+
+Signed-off-by: Joe Slater 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154784): 
https://lists.openembedded.org/g/openembedded-core/message/154784
Mute This Topic: https://lists.openembedded.org/mt/84872571/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-