Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK toolchain

2020-03-25 Thread Richard Purdie
openembedded.org > > Subject: Re: [OE-core][PATCH] security_flags.inc: fix flags missing > > from SDK toolchain > > > > I've therefore taken Tom's version with some tweaks to the commit > > message. > > Thanks. Can we get this on zeus? Do I need to cherry-pic

Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK toolchain

2020-03-24 Thread Tom Hochstein
> -Original Message- > From: Richard Purdie > Sent: Tuesday, March 24, 2020 5:58 PM > To: Antoine Manache ; Tom Hochstein > > Cc: openembedded-core@lists.openembedded.org > Subject: Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK > toolc

Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK toolchain

2020-03-24 Thread Richard Purdie
On Tue, 2020-03-24 at 20:06 +0100, Antoine Manache wrote: > Absolutely. > I would add an example of issue I've seen in a software project. > Someone developing a new application and using the image-based SDK > that I provided got the right functional behaviour on target. > Once this application

Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK toolchain

2020-03-24 Thread Antoine Manache
, Tom Hochstein a écrit : > > > > -Original Message- > > From: Richard Purdie > > Sent: Tuesday, March 24, 2020 1:03 PM > > To: Antoine Manache ; Tom Hochstein < > tom.hochst...@nxp.com> > > Cc: openembedded-core@lists.openembedded.org > > Su

Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK toolchain

2020-03-24 Thread Tom Hochstein
> -Original Message- > From: Richard Purdie > Sent: Tuesday, March 24, 2020 1:03 PM > To: Antoine Manache ; Tom Hochstein > > Cc: openembedded-core@lists.openembedded.org > Subject: Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK > toolch

Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK toolchain

2020-03-24 Thread Richard Purdie
On Tue, 2020-03-24 at 18:25 +0100, Antoine Manache wrote: > I've already sent this patch few months ago but not taken into > account yet. Can someone explain more about the issue here please? Shouldn't these flags be added to the SDK toolchain environment files rather than coded into the

Re: [OE-core][PATCH] security_flags.inc: fix flags missing from SDK toolchain

2020-03-24 Thread Antoine Manache
I've already sent this patch few months ago but not taken into account yet. AM >From : Antoine Manache Date: mer. 20 nov. 2019 at 16:44 Subject: [OE-core] [PATCH v2] sdk: environment script doesn't set security options in CC and LDFLAGS variables To: When building a SDK from a DISTRO with

[OE-core][PATCH] security_flags.inc: fix flags missing from SDK toolchain

2020-03-24 Thread Tom Hochstein
The security flags were missing from the SDK toolchain because they were added specifically to class-target. Add them to class-cross-canadian as well. Signed-off-by: Tom Hochstein --- meta/conf/distro/include/security_flags.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git