Re: [OE-core] [PATCH][v4] mmc-utils: fix the building failure when DEBUG_BUILD is 1

2015-06-25 Thread Rongqing Li
On 2015年06月24日 22:16, Burton, Ross wrote: On 24 June 2015 at 02:42, Rongqing Li rongqing...@windriver.com mailto:rongqing...@windriver.com wrote: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp] | # warning _FORTIFY_SOURCE requires compiling with

Re: [OE-core] [PATCH][v4] mmc-utils: fix the building failure when DEBUG_BUILD is 1

2015-06-25 Thread Burton, Ross
On 25 June 2015 at 07:59, Rongqing Li rongqing...@windriver.com wrote: How about the below patch From 6de0180f5332880195e315fdaf4899406dc54d99 Mon Sep 17 00:00:00 2001 From: Roy Li rongqing...@windriver.com Date: Thu, 25 Jun 2015 14:44:05 +0800 Subject: [PATCH] mmc-utils: fix the building

Re: [OE-core] [PATCH][v4] mmc-utils: fix the building failure when DEBUG_BUILD is 1

2015-06-24 Thread Burton, Ross
On 24 June 2015 at 02:42, Rongqing Li rongqing...@windriver.com wrote: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp] | # warning _FORTIFY_SOURCE requires compiling with optimization (-O) So security_flags and debug build are mutually exclusive, and no

Re: [OE-core] [PATCH][v4] mmc-utils: fix the building failure when DEBUG_BUILD is 1

2015-06-23 Thread Burton, Ross
On 3 June 2015 at 02:24, rongqing...@windriver.com wrote: +CFLAGS += -U_FORTIFY_SOURCE So Richard made the valid point that this is disabling the security flags in mmc-utils globally to fix builds in the very few cases when DEBUG_BUILD is enabled. Would it be sensible to have an include file

Re: [OE-core] [PATCH][v4] mmc-utils: fix the building failure when DEBUG_BUILD is 1

2015-06-23 Thread Rongqing Li
On 2015年06月23日 19:23, Burton, Ross wrote: On 3 June 2015 at 02:24, rongqing...@windriver.com mailto:rongqing...@windriver.com wrote: +CFLAGS += -U_FORTIFY_SOURCE So Richard made the valid point that this is disabling the security flags in mmc-utils globally to fix builds in the very

Re: [OE-core] [PATCH][v4] mmc-utils: fix the building failure when DEBUG_BUILD is 1

2015-06-18 Thread Rongqing Li
ping -R On 2015年06月03日 09:24, rongqing...@windriver.com wrote: From: Roy Li rongqing...@windriver.com AM_CFLAGS in Makefile includes -D_FORTIFY_SOURCE=2 which will lead to building failure when DEBUG_BUILD is 1. Cancel the definition of _FORTIFY_SOURCE by passing -U_FORTIFY_SOURCE via CFLAGS

Re: [OE-core] [PATCH][v4] mmc-utils: fix the building failure when DEBUG_BUILD is 1

2015-06-10 Thread Rongqing Li
ping -Roy On 2015年06月03日 09:24, rongqing...@windriver.com wrote: From: Roy Li rongqing...@windriver.com AM_CFLAGS in Makefile includes -D_FORTIFY_SOURCE=2 which will lead to building failure when DEBUG_BUILD is 1. Cancel the definition of _FORTIFY_SOURCE by passing -U_FORTIFY_SOURCE via

[OE-core] [PATCH][v4] mmc-utils: fix the building failure when DEBUG_BUILD is 1

2015-06-02 Thread rongqing.li
From: Roy Li rongqing...@windriver.com AM_CFLAGS in Makefile includes -D_FORTIFY_SOURCE=2 which will lead to building failure when DEBUG_BUILD is 1. Cancel the definition of _FORTIFY_SOURCE by passing -U_FORTIFY_SOURCE via CFLAGS Signed-off-by: Roy Li rongqing...@windriver.com ---