Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes

2020-05-06 Thread Adrian Bunk
On Sun, May 03, 2020 at 12:21:38PM -0700, Andre McCurdy wrote: > On Sun, May 3, 2020 at 10:39 AM Khem Raj wrote: > > > > I think add it globally to BUILD_CFLAGS perhaps is > > Right thing to do once we upgrade to gcc10 cross compiler I have a patch to > > add it to gcc defaults > > Adding

Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes

2020-05-04 Thread Khem Raj
On Sun, May 3, 2020 at 12:21 PM Andre McCurdy wrote: > > On Sun, May 3, 2020 at 10:39 AM Khem Raj wrote: > > > > I think add it globally to BUILD_CFLAGS perhaps is > > Right thing to do once we upgrade to gcc10 cross compiler I have a patch to > > add it to gcc defaults > > Adding -fcommon

Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes

2020-05-03 Thread Adrian Bunk
On Sun, May 03, 2020 at 10:26:40AM +0200, Daniel Mack wrote: > When building on a gcc 10 enabled host distribution (such as Fedora 32), > a number of recipies need explicit treatment to enable '-fcommon' in > BUILD_CFLAGS. There might be more of those fixes needed. >... These are not fixes, just

Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes

2020-05-03 Thread Andre McCurdy
On Sun, May 3, 2020 at 10:39 AM Khem Raj wrote: > > I think add it globally to BUILD_CFLAGS perhaps is > Right thing to do once we upgrade to gcc10 cross compiler I have a patch to > add it to gcc defaults Adding -fcommon to CFLAGS or BUILD_CFLAGS globally could interact badly with components

Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes

2020-05-03 Thread Khem Raj
I think add it globally to BUILD_CFLAGS perhaps is Right thing to do once we upgrade to gcc10 cross compiler I have a patch to add it to gcc defaults Perhaps we will have apps ported to gcc10 by then On Sun, May 3, 2020 at 1:07 AM Daniel Mack wrote: > When building on a gcc 10 enabled host

Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes

2020-05-03 Thread Daniel Mack
Hi Richard, Thanks a lot for checking! On 5/3/20 12:04 PM, Richard Purdie wrote: > On Sun, 2020-05-03 at 10:26 +0200, Daniel Mack wrote: >> When building on a gcc 10 enabled host distribution (such as Fedora >> 32), >> a number of recipies need explicit treatment to enable '-fcommon' in >>

Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes

2020-05-03 Thread Richard Purdie
On Sun, 2020-05-03 at 10:26 +0200, Daniel Mack wrote: > When building on a gcc 10 enabled host distribution (such as Fedora > 32), > a number of recipies need explicit treatment to enable '-fcommon' in > BUILD_CFLAGS. There might be more of those fixes needed. > > Commit 46827b8616 ("recipes: Use

[OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes

2020-05-03 Thread Daniel Mack
When building on a gcc 10 enabled host distribution (such as Fedora 32), a number of recipies need explicit treatment to enable '-fcommon' in BUILD_CFLAGS. There might be more of those fixes needed. Commit 46827b8616 ("recipes: Use -fcommon explicitly") already addressed that for some places, but