Re: [OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-19 Thread Burton, Ross
On 19 April 2017 at 04:45, Kyle Russell wrote: > Thank you. Do I need to submit an amended patch to the mailing list, or > will your fixup get merged in from your staging branch pending no problems? > Don't worry about it, I've fixed it. Ross --

Re: [OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Kyle Russell
Thank you. Do I need to submit an amended patch to the mailing list, or will your fixup get merged in from your staging branch pending no problems? On Tue, Apr 18, 2017 at 3:17 PM, Burton, Ross wrote: > > On 18 April 2017 at 19:53, Khem Raj wrote: >

Re: [OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Burton, Ross
On 18 April 2017 at 19:53, Khem Raj wrote: > dont use == here that will make it bash specific. > Well spotted Khem. I've merged this into my staging branch with the test changed to = for POSIXness. Thanks, Ross -- ___

Re: [OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Khem Raj
On Tue, Apr 18, 2017 at 8:02 AM, Kyle Russell wrote: > If CMAKE_SYSTEM_NAME is defined, CMake assumes we're cross-compiling, > which is not necessarily the case. > --- > meta/classes/cmake.bbclass | 4 > 1 file changed, 4 insertions(+) > > diff --git

[OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Kyle Russell
If CMAKE_SYSTEM_NAME is defined, CMake assumes we're cross-compiling, which is not necessarily the case. Signed-off-by: Kyle Russell --- meta/classes/cmake.bbclass | 4 1 file changed, 4 insertions(+) diff --git a/meta/classes/cmake.bbclass

[OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Kyle Russell
If CMAKE_SYSTEM_NAME is defined, CMake assumes we're cross-compiling, which is not necessarily the case. --- meta/classes/cmake.bbclass | 4 1 file changed, 4 insertions(+) diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass index 9e74599..2dbaa8c 100644 ---